New: Resume from suspend stopped working
https://bugzilla.kernel.org/show_bug.cgi?id=216697
Bug ID: 216697
Summary: Resume from suspend stopped working
Product: Drivers
Version: 2.5
Kernel Version: 6.0.7
Hardware: Intel
OS: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: USB
Assignee: [email protected]
Reporter: [email protected]
Regression: NoCreated attachment 303190
--> https://bugzilla.kernel.org/attachment.cgi?id=303190&action=edit
photo of errors on resume
It seems like changes made here [1] breake resume from suspend on my laptop. Archlinux kernel 6.0.6: resumes fine
Archlinux kernel 6.0.7 - 6.1.0-rc5-1-mainline: hangs on resume, laptop appears to stuck, nothing works except GUI displayed but not updated and I get errors saying something like
RIP: 0010:ucsi_resume+0x2a/0x70
see attached photo
Lenovo ThinkBook 13s-IML
If it's inappropriate to report such issue here, could you please guide me how to report, I'm totally new to kernel issue reporting.
1. - https://bugzilla.kernel.org/show_bug.cgi?id=210425
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #1 from Heikki Krogerus ([email protected]) --- Can you blacklist typec_ucsi and ucsi_acpi modules to confirm that it really is a ucsi problem?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #2 from Dennis ([email protected]) --- Yep, blacklisting these modules fix the problem.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
Roman Belikin ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #3 from Roman Belikin ([email protected]) --- Hi, I got the similar issue, that I've explained here -
https://bbs.archlinux.org/viewtopic.php?id=281375
Blacklisting this module also helps me
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #4 from Heikki Krogerus ([email protected]) --- (In reply to Roman Belikin from comment #3)
Quoted 3 lines
Hi, I got the similar issue, that I've explained here -
https://bbs.archlinux.org/viewtopic.php?id=281375
Blacklisting this module also helps me
I think that problem is related to bug 216706 (maybe). I'll figure out a fix for that first. Let's see if it helps with this problem as well.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #5 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- (In reply to Heikki Krogerus from comment #4)
Quoted 2 lines
I think that problem is related to bug 216706 (maybe). I'll figure out a fix for that first. Let's see if it helps with this problem as well.
What the status here? was this ever resolved?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #6 from Heikki Krogerus ([email protected]) --- There is a fix for bug 216706, but it hasn't made it into the mainline nor the stable kernels yet. Can somebody test that fix separately, if it helps with this bug as well?
https://bugzilla.kernel.org/attachment.cgi?id=303247
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #7 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- (In reply to Heikki Krogerus from comment #6)
Quoted 4 lines
There is a fix for bug 216706, but it hasn't made it into the mainline nor the stable kernels yet. Can somebody test that fix separately, if it helps with this bug as well?
https://bugzilla.kernel.org/attachment.cgi?id=303247
Denis, Roman, did you try?
Heikki, just btw, there was another issue (bug 216788) where that patch helped.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #8 from Denis ([email protected]) ---
I would love to try, but I'm afraid I'm not experienced enough to build the kernel.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #9 from Alexander Chernaev ([email protected]) --- Created attachment 303449
--> https://bugzilla.kernel.org/attachment.cgi?id=303449&action=edit
screenshot of error with patch
Tested with mentioned patch applied to kernel 6.1.0, unfortunately the issue is not resolved.
Patch tested: https://bugzilla.kernel.org/attachment.cgi?id=303247
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #10 from Heikki Krogerus ([email protected]) --- Thanks for checking that. I'll try to figure out what's happening.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
[email protected] changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #11 from [email protected] ---
I also got a similar issue, I've explained here.
<https://bbs.archlinux.org/viewtopic.php?pid=2081073>.
In https://bugzilla.kernel.org/show_bug.cgi?id=216706, it has been reported that USBC resume callback takes far too long, between 650ms and 1200ms. However, after the same commit mentioned there, my laptop just freezes instead of taking a long time to resume.
Noticed you merged a patch in 6.2-rc5, but I just tried 6.2-rc5 and it didn't work.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #12 from Heikki Krogerus ([email protected]) --- Created attachment 303643
--> https://bugzilla.kernel.org/attachment.cgi?id=303643&action=edit
Test fix
I got a bit more information related to this from Fan Chengwei on the linux-usb ml. I now have here a potential fix for the problem. Can anybody test does it work?
Thanks!
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
Oliver Reeh ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #13 from Oliver Reeh ([email protected]) --- Is this fix suitable for kernel 6.1.x?
If yes then I'm willing to test it.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #14 from Heikki Krogerus ([email protected]) --- (In reply to Oliver Reeh from comment #13)
Quoted 2 lines
Is this fix suitable for kernel 6.1.x?
If yes then I'm willing to test it.
Great, thanks! The patch should apply just fine on top of 6.1.x.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #15 from Oliver Reeh ([email protected]) --- I figured that already ...
I'm running a patched kernel 6.1.8 for two days with lots of USB-C/Thunderbolt plugging and unplugging without any issues.
No more lockups after suspend and no more kernel oops in the logs.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #16 from Oliver Reeh ([email protected]) --- The fix in kernel 6.1.9 doesn't work.
02.02.23 09:59 darkstar kernel RIP: 0010:ucsi_resume_work+0x2e/0x80
[typec_ucsi]
The system hangs after resuming from suspend.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #17 from Heikki Krogerus ([email protected]) --- The patch for this bug has not been applied to any tree yet.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #18 from Oliver Reeh ([email protected]) ---
That explains it ... I thought commit 3d7f77e55da3455c8844b651e37779c90e201f48 included this fix.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #19 from Oliver Reeh ([email protected]) --- No issues with kernel 6.1.9.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #20 from Denis ([email protected]) --- Yep, can't reproduce with kernel 6.1.9 too.
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 216697] Resume from suspend stopped working
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=216697
--- Comment #21 from Oliver Reeh ([email protected]) --- No problems with the patch and kernel 6.1.10
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.