New: Regression in USB DWC3 driver in kernel 5.15 branch

https://bugzilla.kernel.org/show_bug.cgi?id=217670

            Bug ID: 217670
           Summary: Regression in USB DWC3 driver in kernel 5.15 branch
           Product: Drivers
           Version: 2.5
          Hardware: ARM
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

The backport commit to 5.15 branch:
9d4f84a15f9c9727bc07f59d9dafc89e65aadb34 "arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes" (from upstream commit 5c3d5ecf48ab06c709c012bf1e8f0c91e1fcd7ad)
switched from "snps,dis-u2-freeclk-exists-quirk" to "snps,gfladj-refclk-lpm-sel-quirk".

The problem is that the gfladj-refclk-lpm-sel-quirk quirk is not implemented / backported to 5.15 branch.

This commit should be either reverted, or the commit introducing gfladj-refclk-lpm-sel-quirk needs to be merged to 5.15 kernel branch.

As a result of this patch, on Gateworks Venice GW7400 revB board the USB 3.x devices which are connected to the USB Type C port does not enumerate and the following errors are generated:

[   14.906302] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for setup device
command
[   15.122383] usb 2-1: device not accepting address 2, error -62
[   25.282195] xhci-hcd xhci-hcd.0.auto: Abort failed to stop command ring:
-110
[   25.297408] xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding,
assume dead
[   25.305345] xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
[   25.311058] xhci-hcd xhci-hcd.0.auto: Timeout while waiting for stop
endpoint command
[   25.334361] usb usb2-port1: couldn't allocate usb_device

When the commit is reverted the USB 3.x drives works fine.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #1 from Tomasz Rostanski ([email protected]) --- Created attachment 304637
--> https://bugzilla.kernel.org/attachment.cgi?id=304637&action=edit
dmesg with USB 3.2 stick inserted

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #2 from Tomasz Rostanski ([email protected]) --- Created attachment 304638
--> https://bugzilla.kernel.org/attachment.cgi?id=304638&action=edit
dmesg with usb 2.0 stick inserted

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #3 from Tomasz Rostanski ([email protected]) --- The USB 2.0 devices are properly enumerated. Only USB 3.x devices are affected in our configuration.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

What commit exactly needs to be backported?

thanks,

greg k-h

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #4 from Greg Kroah-Hartman ([email protected]) ---

What commit exactly needs to be backported?

thanks,

greg k-h

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #5 from Tomasz Rostanski ([email protected]) --- I believe the missing commit is:

commit a6fc2f1b092787e9d7dbe472d720cede81680315

Author: Alexander Stein <[email protected]>
Date:   Thu Sep 15 08:28:53 2022 +0200

usb: dwc3: core: add gfladj_refclk_lpm_sel quirk

This selects the SOF/ITP counter be running on ref_clk. As documented U2_FREECLK_EXISTS has to be set to 0 as well.

Link:
https://lore.kernel.org/r/[email protected]

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #6 from Tomasz Rostanski ([email protected]) --- The commit a6fc2f1b092787e9d7dbe472d720cede81680315 has dependencies of previous commits, so at the minimum the following commits needs to be backported:

7bee318838890 usb: dwc3: reference clock period configuration a5ae3cbe9dfcc usb: dwc3: Get clocks individually 5114c3ee24875 usb: dwc3: Calculate REFCLKPER based on reference clock 596c87856e08d usb: dwc3: Program GFLADJ
a6fc2f1b09278 usb: dwc3: core: add gfladj_refclk_lpm_sel quirk

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Can you test this to verify that it does actually work for you?

thanks,

greg k-h

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #7 from Greg Kroah-Hartman ([email protected]) ---

Can you test this to verify that it does actually work for you?

thanks,

greg k-h

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #8 from Tomasz Rostanski ([email protected]) --- I confirm. It works for me.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #9 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- (In reply to Tomasz Rostanski from comment #8)

Tomasz, was a fix ever merged to 5.15.y – either a revert or the changes listed above? Doesn't look like it from here, but I have the strong suspicion that I'm missing something here.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #10 from Tomasz Rostanski ([email protected]) --- No it's not fixed in 5.15.y.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #11 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- Greg, guess it fell through the cracks on your side then. You afaics intended
to apply these to 5.15.y to fix the regression that was caused by backporting
5c3d5ecf48a ("arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB
nodes") [v6.1-rc1] to 5.15.y:

Thomas confirmed that they fix the regression here:
https://bugzilla.kernel.org/show_bug.cgi?id=217670#c8

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Those ids do not match up properly. Can we please take this to email on the [email protected] list? I thought we resolved this there already, if not, I need a real list of ids, in the correct order, to apply please.

thanks,

greg k-h

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #12 from Greg Kroah-Hartman ([email protected]) ---

Those ids do not match up properly. Can we please take this to email on the [email protected] list? I thought we resolved this there already, if not, I need a real list of ids, in the correct order, to apply please.

thanks,

greg k-h

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #13 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- Tomasz, can you do what Greg asked for? It seems the commits you listed in
comment 6 do not apply cleanly any more (I just checked), so you are in the
best position to help here, as something might have changed since your comment
6 and 8.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #14 from Tomasz Rostanski ([email protected]) --- Created attachment 305003
--> https://bugzilla.kernel.org/attachment.cgi?id=305003&action=edit
0001-usb-dwc3-reference-clock-period-configuration.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #15 from Tomasz Rostanski ([email protected]) --- Created attachment 305004
--> https://bugzilla.kernel.org/attachment.cgi?id=305004&action=edit
0002-usb-dwc3-Get-clocks-individually.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #16 from Tomasz Rostanski ([email protected]) --- Created attachment 305005
--> https://bugzilla.kernel.org/attachment.cgi?id=305005&action=edit
0003-usb-dwc3-Calculate-REFCLKPER-based-on-reference-cloc.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #17 from Tomasz Rostanski ([email protected]) --- Created attachment 305006
--> https://bugzilla.kernel.org/attachment.cgi?id=305006&action=edit
0004-usb-dwc3-Program-GFLADJ.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #18 from Tomasz Rostanski ([email protected]) --- Created attachment 305007
--> https://bugzilla.kernel.org/attachment.cgi?id=305007&action=edit
0005-usb-dwc3-core-add-gfladj_refclk_lpm_sel-quirk.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz Rostanski ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

 Attachment #305003|0                           |1

is obsolete| |

--- Comment #19 from Tomasz Rostanski ([email protected]) --- Created attachment 305008
--> https://bugzilla.kernel.org/attachment.cgi?id=305008&action=edit
0001-usb-dwc3-reference-clock-period-configuration.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz Rostanski ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

 Attachment #305004|0                           |1

is obsolete| |

--- Comment #20 from Tomasz Rostanski ([email protected]) --- Created attachment 305009
--> https://bugzilla.kernel.org/attachment.cgi?id=305009&action=edit
0002-usb-dwc3-Get-clocks-individually.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz Rostanski ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

 Attachment #305005|0                           |1

is obsolete| |

--- Comment #21 from Tomasz Rostanski ([email protected]) --- Created attachment 305010
--> https://bugzilla.kernel.org/attachment.cgi?id=305010&action=edit
0003-usb-dwc3-Calculate-REFCLKPER-based-on-reference-cloc.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz Rostanski ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

 Attachment #305006|0                           |1

is obsolete| |

--- Comment #22 from Tomasz Rostanski ([email protected]) --- Created attachment 305011
--> https://bugzilla.kernel.org/attachment.cgi?id=305011&action=edit
0004-usb-dwc3-Program-GFLADJ.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

Tomasz Rostanski ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

 Attachment #305007|0                           |1

is obsolete| |

--- Comment #23 from Tomasz Rostanski ([email protected]) --- Created attachment 305012
--> https://bugzilla.kernel.org/attachment.cgi?id=305012&action=edit
0005-usb-dwc3-core-add-gfladj_refclk_lpm_sel-quirk.patch

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #24 from Tomasz Rostanski ([email protected]) --- I have attached rebased patches against 5.15.129:
0001-usb-dwc3-reference-clock-period-configuration.patch 0002-usb-dwc3-Get-clocks-individually.patch 0003-usb-dwc3-Calculate-REFCLKPER-based-on-reference-cloc.patch 0004-usb-dwc3-Program-GFLADJ.patch 0005-usb-dwc3-core-add-gfladj_refclk_lpm_sel-quirk.patch
apply with git am.

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #25 from The Linux kernel's regression tracker (Thorsten Leemhuis) ([email protected]) --- That won't fly, bugzilla is not used like that by the kernel developers (and
the changelog is lost afaics, which is a no-go, too). Please submit them as
outline in
https://www.kernel.org/doc/html/next/process/stable-kernel-rules.html (you
likely need option 3 in case the patches need to be adjusted for the 5.15.y
branch, otherwise option 2 would do the trick)

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=217670

--- Comment #26 from Greg Kroah-Hartman ([email protected]) ---

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.