New: Mistake in example in mount_namespaces(7)
https://bugzilla.kernel.org/show_bug.cgi?id=217709
Bug ID: 217709
Summary: Mistake in example in mount_namespaces(7)
Product: Documentation
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: low
Priority: P3
Component: man-pages
Assignee: [email protected]
Reporter: [email protected]
Regression: No
In the example showing how locked mounts in a less privileged mount namespace can not be split, a command "umount /mnt/dir" is shown. Surely, that should have been "umount /etc/shadow".
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
https://bugzilla.kernel.org/show_bug.cgi?id=217709
Rajesh ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #1 from Rajesh ([email protected]) --- Hi Göran,
You are right. It needs to be "umount /etc/shadow". Let me see whether I can make the change.
Rajesh
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #2 from Rajesh ([email protected]) --- Hi Göran,
Patch has been submitted. Once it's merged it will show up.
Rajesh
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #3 from Göran Uddeborg ([email protected]) --- Great!
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #4 from Göran Uddeborg ([email protected]) --- Did something go wrong with the patch?
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
Alejandro Colomar ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
--- Comment #5 from Alejandro Colomar ([email protected]) --- Hi Göran,
(In reply to Göran Uddeborg from comment #4)
Quoted 1 line
Did something go wrong with the patch?
It didn't meet the minimums to be merged, and Rajesh didn't follow up.
If you're interested in it, you can pick up from where he left:
<https://lore.kernel.org/linux-man/CAKkEDkWJa+BbexSD1OGa=RhKuaETmYZUJaLJKZPvsVW9=Vr=JQ@mail.gmail.com/>
Cheers,
Alex
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #6 from Göran Uddeborg ([email protected]) --- Hi Alex,
I've tried to submit a patch of my own now. While the patch itself is trivial, it took me a little while to figure out how to submit it. Did I get it right?
I couldn't find any way to state in the message the patch would solve this bugzilla. Did I miss something, or is there no such connection?
Regards,
Göran
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #7 from Alejandro Colomar ([email protected]) --- Hi Göran,
Quoted 8 lines · On Sun, Feb 16, 2025 at 07:02:46PM +0000, [email protected] wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #6 from Göran Uddeborg ([email protected]) --- Hi Alex,
I've tried to submit a patch of my own now. While the patch itself is trivial,
it took me a little while to figure out how to submit it. Did I get it right?
Yup, the submission looks right. Is there anything we could improve in the contributing guidelines that would have made it easier to figure it out?
Quoted 2 lines
I couldn't find any way to state in the message the patch would solve this bugzilla. Did I miss something, or is there no such connection?
You could add the following line in the commit message:
Quoted 3 lines
Regards,
Göran
Have a lovely day!
Alex
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
Alejandro Colomar ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |CODE_FIXSignature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #8 from Göran Uddeborg ([email protected]) ---
Quoted 3 lines
Is there anything we could improve in
the contributing guidelines that would have made it easier to figure it out?
I didn't mean to say it was something bad or missing in the guidelines. Just that it takes a little time to understand a new and unfamiliar workflow.
It didn't take THAT long time! :-)
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
[Bug 217709] Mistake in example in mount_namespaces(7)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=217709
--- Comment #9 from Alejandro Colomar ([email protected]) --- Makes sense. Thanks! :-)
Signature · 4 lines
You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.