Skip to contentSkip to conversation

New: USB string order in dmesg

Bug 218762 [email protected] 2 participants 4 messages Apr 22, 2024 – Apr 23, 2024 USB

lore
Share & tools
lore

[email protected]

author
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=218762

            Bug ID: 218762
           Summary: USB string order in dmesg
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Hi,

Is there any good reason why the code
https://github.com/torvalds/linux/blob/c85af715cac0a951eea97393378e84bb49384734/drivers/usb/core/hub.c#L2361
is declaring string (show_string) values in a different order than they are specified in dev_info?

dev_info(&udev->dev,
"New USB device strings: Mfr=%d, Product=%d,
SerialNumber=%d\n",

                udev->descriptor.iManufacturer,
                udev->descriptor.iProduct,
                udev->descriptor.iSerialNumber);
        show_string(udev, "Product", udev->product);
        show_string(udev, "Manufacturer", udev->manufacturer);
        show_string(udev, "SerialNumber", udev->serial);

Now
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Product: BM5100ADW series
usb 4-1: Manufacturer: Pantum
usb 4-1: SerialNumber: CK1A8823765

Expected
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Manufacturer: Pantum
usb 4-1: Product: BM5100ADW series
usb 4-1: SerialNumber: CK1A8823765

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
maintainer
#1 lore raw
Quoted 22 lines · On Mon, Apr 22, 2024 at 07:34:17PM +0000, [email protected] wrote:

Is there any good reason why the code
https://github.com/torvalds/linux/blob/c85af715cac0a951eea97393378e84bb49384734/drivers/usb/core/hub.c#L2361
is declaring string (show_string) values in a different order than they are specified in dev_info?

dev_info(&udev->dev,
"New USB device strings: Mfr=%d, Product=%d,
SerialNumber=%d\n",

                udev->descriptor.iManufacturer,
                udev->descriptor.iProduct,
                udev->descriptor.iSerialNumber);
        show_string(udev, "Product", udev->product);
        show_string(udev, "Manufacturer", udev->manufacturer);
        show_string(udev, "SerialNumber", udev->serial);

Now
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Product: BM5100ADW series
usb 4-1: Manufacturer: Pantum
usb 4-1: SerialNumber: CK1A8823765

Quoted 5 lines

Expected
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Manufacturer: Pantum
usb 4-1: Product: BM5100ADW series
usb 4-1: SerialNumber: CK1A8823765

No specific reaason, just has always been that way for 20+ years and no one has noticed.

author
#2 lore raw

[Bug 218762] USB string order in dmesg

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=218762

--- Comment #1 from [email protected] ---

Quoted 23 lines · On Mon, Apr 22, 2024 at 07:34:17PM +0000, [email protected] wrote:

Is there any good reason why the code

https://github.com/torvalds/linux/blob/c85af715cac0a951eea97393378e84bb49384734/drivers/usb/core/hub.c#L2361
is declaring string (show_string) values in a different order than they are specified in dev_info?

dev_info(&udev->dev,
"New USB device strings: Mfr=%d, Product=%d,
SerialNumber=%d\n",

                udev->descriptor.iManufacturer,
                udev->descriptor.iProduct,
                udev->descriptor.iSerialNumber);
        show_string(udev, "Product", udev->product);
        show_string(udev, "Manufacturer", udev->manufacturer);
        show_string(udev, "SerialNumber", udev->serial);

Now
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Product: BM5100ADW series
usb 4-1: Manufacturer: Pantum
usb 4-1: SerialNumber: CK1A8823765

Quoted 5 lines

Expected
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 usb 4-1: Manufacturer: Pantum
usb 4-1: Product: BM5100ADW series
usb 4-1: SerialNumber: CK1A8823765

No specific reaason, just has always been that way for 20+ years and no one has noticed.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.
author
#3 lore raw

[Bug 218762] USB string order in dmesg

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=218762

Artem S. Tashkinov ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |ANSWERED
Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.