New: makedevs-unused-but-set-variable.patch

https://bugs.busybox.net/show_bug.cgi?id=4171

Summary: makedevs-unused-but-set-variable.patch
Product: buildroot
Version: 2010.11
Platform: PC
OS/Version: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: hector.oron at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Hello,

makedevs package in buildroot fails to build when `-Wunused-but-set-variable'
is set in the compiler. The following patch attempts to fix this issue:

Index: buildroot-2010.11/package/makedevs/makedevs.c
===================================================================
--- buildroot-2010.11.orig/package/makedevs/makedevs.c 2011-09-09 22:33:32.948124813 +0100
+++ buildroot-2010.11/package/makedevs/makedevs.c 2011-09-09
22:33:55.044124824 +0100
@@ -531,5 +531,5 @@

        if (system("/bin/sync"))
                bb_error_msg("sync failed, continuing anyway");

- return 0;
+ return ret;
}

Best regards,
-- Hector Oron

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=4171

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Peter Korsgaard <[email protected]> --- Thanks. I had to apply manually as your patch was against an old BR version (/bin/sync call got removed back in March). I guess that's also the reason why you brought this up as we previously built makedevs with -Werror, which we don't do any more.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=4171

Danomi Mocelopolis <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |d_mo1234 at yahoo.com

--- Comment #2 from Danomi Mocelopolis <[email protected]> 2011-10-23 17:50:41 UTC --- *** Bug 4375 has been marked as a duplicate of this bug. ***

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.