New: busybox built fails if we use an override src dir BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config
https://bugs.busybox.net/show_bug.cgi?id=5030
Summary: busybox built fails if we use an override src dir
BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config
Product: buildroot
Version: 2012.02
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: korkakak at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0
when one tries to make busybox this fails because the BUSYBOX_POST_EXTRACT_HOOKS are not run (we rsync from another directory).
The solution to that I've came up with is to either change the BUSYBOX_POST_EXTRACT_HOOKS to BUSYBOX_PRE_CONFIGURE_HOOKS or add another hook BUSYBOX_PRE_CONFIGURE_HOOKS += BUSYBOX_COPY_CONFIG
(the worst case scenario with the two hooks will be to copy the same file twice)
the proposed solution is the following:
package/busybox/busybox.mk +1 -1
@@ -138,7 +138,7 @@ define BUSYBOX_INSTALL_LOGGING_SCRIPT endef # We do this here to avoid busting a modified .config in configure -BUSYBOX_POST_EXTRACT_HOOKS += BUSYBOX_COPY_CONFIG +BUSYBOX_PRE_CONFIGURE_HOOKS += BUSYBOX_COPY_CONFIG define BUSYBOX_CONFIGURE_CMDS $(BUSYBOX_SET_LARGEFILE)
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5030] busybox built fails if we use an override src dir BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config
https://bugs.busybox.net/show_bug.cgi?id=5030
--- Comment #1 from Thomas De Schampheleire <[email protected]> 2014-02-08 21:24:30 UTC --- A question to buildroot developers: what do we do with this patch? The
different components using .config files all handle it differently:
busybox copies its .config from the post-extract hook. linux copies its .config in the configure_cmds. uclibc copies its .config from the post-patch hook.
The busybox behavior allows a user to change .config, then re-run the configure step and keep the user's changes.
For linux this is not true: if you change your config and re-run the configure step, your changes are lost. If you change your .config and expect to keep the changes, you can only rebuild, not reconfigure.
This patch proposes to line-up busybox more with how the linux kernel handles it.
This raises the question: what do we want, what should the behavior be?
Personally, I haven't had a big problem with the linux way, and thus would accept the principle of this patch. But I don't have a very strong opinion on this...
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
[Buildroot] [Bug 5030] busybox built fails if we use an override src dir BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=5030
Thomas De Schampheleire <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED--- Comment #2 from Thomas De Schampheleire <[email protected]> 2014-02-20 08:17:22 UTC --- This bug has been fixed with commit
http://git.buildroot.org/buildroot/commit/?id=eedfc7121cf5b9a8dee8546c85b3bd36e9a743a4
Thanks for reporting!
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.