Skip to contentSkip to conversation

New: arch/x86/kvm/svm.c: svm_vcpu_reset() and uninitialized dummy variable?

Bug 60652 [email protected] 1 participant 3 messages Jul 29, 2013 – Nov 13, 2013 KVM

lore
Share & tools
lore

[email protected]

author
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=60652

            Bug ID: 60652
           Summary: arch/x86/kvm/svm.c: svm_vcpu_reset() and uninitialized
                    dummy variable?
           Product: Virtualization
           Version: unspecified
    Kernel Version: 3.11rc2
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: kvm
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Coverity CID 751495 feels a bit like a false positive. Is the dummy variable not initialized on purpose?

1196static void svm_vcpu_reset(struct kvm_vcpu *vcpu) 1197{
1198 struct vcpu_svm *svm = to_svm(vcpu);
1. var_decl: Declaring variable "dummy" without initializer.
1199 u32 dummy;
1200 u32 eax = 1;
1201
1202 init_vmcb(svm);
1203

CID 751495 (#1 of 1): Uninitialized scalar variable (UNINIT)
2. uninit_use_in_call: Using uninitialized value "dummy" when calling "kvm_cpuid(struct kvm_vcpu *, u32 *, u32 *, u32 *, u32 *)". [hide details]
1204 kvm_cpuid(vcpu, &eax, &dummy, &dummy, &dummy);
/arch/x86/kvm/cpuid.c
646void kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, u32 *ecx, u32 *edx)
647{
1. read_parm: Reading a parameter value.
648 u32 function = *eax, index = *ecx;
649 struct kvm_cpuid_entry2 *best;
650
651 best = kvm_find_cpuid_entry(vcpu, function, index);
652
653 if (!best)
654 best = check_cpuid_limit(vcpu, function, index);
655

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
author
#1 lore raw

[Bug 60652] arch/x86/kvm/svm.c: svm_vcpu_reset() and uninitialized dummy variable?

https://bugzilla.kernel.org/show_bug.cgi?id=60652

Alan <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
                 CC|                            |[email protected]
         Resolution|---                         |WILL_NOT_FIX

--- Comment #1 from Alan <[email protected]> --- Coverity is being paranoid.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.