i40e MBUF_FAST_FREE wrong check

https://bugs.dpdk.org/show_bug.cgi?id=665

            Bug ID: 665
           Summary: i40e MBUF_FAST_FREE wrong check
           Product: DPDK
           Version: 20.05
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

In i40e_rxtx.c in i40e_set_tx_function_flag there's an assignment to ad->tx_simple_allowed that includes a check for enabling "tx_simple_allowed":

txq->offloads == (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE)

This appears to be wrong to me. If no offload flags are set then 0 == 0 & <anything> is true. This means that if DEV_TX_OFFLOAD_MBUF_FAST_FREE is NOT set (and no other flags are set) then this check will still enable tx_simple_allowed.

As best I can tell, this causes an issue with multiple mbuf pools are being used to feed a single TX queue and no offload flags enable.

You are receiving this mail because:
You are the assignee for the bug.