New: Does not resume from suspend (bisected)
https://bugzilla.kernel.org/show_bug.cgi?id=66751
Bug ID: 66751
Summary: Does not resume from suspend (bisected)
Product: Power Management
Version: 2.5
Kernel Version: v3.13-rc3
Hardware: x86-64
OS: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: cpufreq
Assignee: [email protected]
Reporter: [email protected]
Regression: NoCreated attachment 117791
--> https://bugzilla.kernel.org/attachment.cgi?id=117791&action=edit
config for 3.13-rc3
This is on a Thinkpad T510. If a try to wake up the machine from suspend, only the start button light changes from "blink" to "on". The screen remains black and the machine is unresponsive. All I can do is a hard reboot by holding down the start button.
I bisected between v3.13-rc2 and v3.13-rc3 and got
commit 2167e2399dc5e69c62db56d933e9c8cbe107620a
Author: Bjørn Mork <[email protected]>
Date: Tue Dec 3 12:14:32 2013 +0100
cpufreq: fix garbage kobjects on errors during suspend/resume
as the first bad commit
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] Does not resume from suspend (bisected)
https://bugzilla.kernel.org/show_bug.cgi?id=66751
--- Comment #1 from Martin Ziegler <[email protected]> --- reverting 2167e2399dc5e69c62db56d933e9c8cbe107620a solves the problem
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
Martin Ziegler <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Regression|No |Yes
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] [BISECTED]Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
Alan <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected], | |[email protected] Summary|Does not resume from |[BISECTED]Does not resume |suspend (bisected) |from suspend (bisected)
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] [BISECTED]Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
--- Comment #2 from Alan <[email protected]> --- Adding Bjørn to the cc
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] [BISECTED]Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
--- Comment #3 from Bjørn Mork <[email protected]> ---
Yes, this is a pretty interesting one. The bug is caused by the combination of two commits added between -rc2 and -rc3:
5a87182aa21d cpufreq: suspend governors on system suspend/hibernate 2167e2399dc5 cpufreq: fix garbage kobjects on errors during suspend/resume
The order these are applied is really arbitrary, and the bisect will point to the last one applied. Which happens to be 2167e2399dc5. But I will still claim that it was commit 5a87182aa21d that caused this bug by adding even more special handling of cpufreq suspend. This needs to be done properly if it is done at all, including hooks for drivers and governors. Adding special cases and "if suspending" tests here and there with subtle implicit dependencies between the different code blocks is not going to fly.
Note that reverting only 5a87182aa21d will fix the problem, with simpler code and no dangling sysfs files as a result.
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] [BISECTED]Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
Lan Tianyu <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |[email protected]
Resolution|--- |PATCH_ALREADY_AVAILABLE--- Comment #4 from Lan Tianyu <[email protected]> ---
Both Commit 2167e2399dc5 and 5a87182aa21d have been reverted in the linux-pm tree. bleeding-edge branch. So close this bug.
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.
[Bug 66751] [BISECTED]Does not resume from suspend (bisected)
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=66751
Lan Tianyu <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
Signature · 2 lines
You are receiving this mail because: You are the assignee for the bug.