New: genext2fs: e2fsck must run before tunefs -U random

https://bugs.busybox.net/show_bug.cgi?id=6752

Summary: genext2fs: e2fsck must run before tunefs -U random
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: major
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: daniel at exxm.de
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Created attachment 5138
--> https://bugs.busybox.net/attachment.cgi?id=5138
patch

In fs/ext2/genext2fs.sh, e2fsck must run after changing filesystem options and before setting the UUID with "tune2fs -U random". Otherwise, the latter command will fail.

I previously got this error message

"tune2fs 1.42.9 (28-Dec-2013)

Please run e2fsck on the filesystem."

It worked for me after moving e2fsck before "tune2fs -U random"

This is based on commit bfbe4dd19e94fb24037e3b6080acd75435adbb67

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #1 from Daniel Mentz <[email protected]> 2014-01-05 21:03:06 UTC --- Created attachment 5144
--> https://bugs.busybox.net/attachment.cgi?id=5144
Build log

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |yann.morin.1998 at free.fr

--- Comment #2 from Yann E. MORIN <[email protected]> 2014-01-05 22:09:06 UTC --- This is working fine for me.

Besides, in the comment you moved, there is an explanation on why adding the UID has to be done *before* calling fsck:

---8<---

# genext2fs does not generate a UUID, but fsck will whine if one is
# is missing, so we need to add a UUID.
# Of course, this has to happend _before_ we run fsck.
---8<---

So, moving this block after fsck is not correct.

Also, I'm using ext2/3/4 quite a lot, and I did not catch any issue with them so far.

I suspect there is another problem with your filesystem. One such potential problem is missing space and/or inodes in the filesystem, which prevents tune2fs and/or e2fsck to work correctly.

Can you attach your defconfig, please?

You can get a defconfig by running:
make savedefconfig

Regards,
Yann E. MORIN.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #3 from Yann E. MORIN <[email protected]> 2014-01-05 22:19:58 UTC --- Hmm, it seems that indeed ext4 is broken since the last bump
of e2fsprogs.

Thanks for the report, I'll investigate.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #4 from Daniel Mentz <[email protected]> 2014-01-05 22:30:13 UTC --- Created attachment 5150
--> https://bugs.busybox.net/attachment.cgi?id=5150
defconfig

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #5 from Daniel Mentz <[email protected]> 2014-01-05 22:31:32 UTC --- Created attachment 5156
--> https://bugs.busybox.net/attachment.cgi?id=5156
This commit to e2fsprogs probably broke buildroot

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #6 from Yann E. MORIN <[email protected]> 2014-01-05 22:37:28 UTC --- Yes, this does indeed look like the cause of your issue,
which I am now able to reproduce with ext4.

ext2 and ext3 are not affected by this.

Thank you! :-)

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

--- Comment #7 from Yann E. MORIN <[email protected]> 2014-01-05 22:59:33 UTC --- Daniel,

This should be fixed by:

    http://patchwork.ozlabs.org/patch/307025/

Care to check on your side, please?

Thanks again for the report!

Regards,
Yann E. MORIN.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Yann E. MORIN <[email protected]> 2014-01-05 23:20:21 UTC --- Fix in the repository, with:
http://git.buildroot.org/buildroot/commit/?id=9e680d0ada829f1cd7e2e1bff138d5e3ec32d0fd

Regards,
Yann E. MORIN.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6752

Daniel Mentz <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED

--- Comment #9 from Daniel Mentz <[email protected]> 2014-01-05 23:25:38 UTC --- It works for me with the fix in the repository. Thanks!

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.