New: toolchainfile.cmake has absolut path references

https://bugs.busybox.net/show_bug.cgi?id=6818

Summary: toolchainfile.cmake has absolut path references
Product: buildroot
Version: unspecified
Platform: All
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: u.strempel at googlemail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

On build process of buildroot the toolchainfile.cmake is created, but with wrong absolut path.
When shareing the toolchain or move the folder you get problems this path settings.
i.e.
set(CMAKE_C_COMPILER /home/dev/Buildroot/../Toolchain/arm-toolchain//usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc) set(CMAKE_CXX_COMPILER /home/dev/Buildroot/../Toolchain/arm-toolchain//usr/bin/arm-buildroot-linux-uclibcgnueabi-g++)

A workarround for cmake files is
- get the path of the toolchainfile.cmake
And set the the variables.

get_filename_component(CMAKE_TOOLCHAIN_PATH ${CMAKE_CURRENT_LIST_FILE} PATH) set(CMAKE_C_COMPILER ${CMAKE_TOOLCHAIN_PATH}/usr/bin/arm-buildroot-linux-uclibcgnueabi-gcc) set(CMAKE_CXX_COMPILER ${CMAKE_TOOLCHAIN_PATH}/usr/bin/arm-buildroot-linux-uclibcgnueabi-g++)

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6818

--- Comment #1 from Thomas Petazzoni <[email protected]> 2014-02-01 08:39:04 UTC --- That seems like a very good idea indeed! Do you mind sending a proper patch to
the mailing list implementing this idea?

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6818

--- Comment #2 from u.strempel at googlemail.com 2014-02-01 11:27:50 UTC --- Created attachment 5192
--> https://bugs.busybox.net/attachment.cgi?id=5192
Patch for generating toolchainfile.cmake with relative-paths

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6818

--- Comment #3 from Thomas De Schampheleire <[email protected]> 2014-02-07 08:36:49 UTC --- Hi u.strempel,

Thanks for the patch. Would you mind sending it to the mailing list directly? This will facilitate review and discussion on the patch.
(you need to be subscribed to the list first).

For example, a comment on the patch is that there is now some duplication between e.g. TARGET_CROSS and TARGET_CROSS_WITHOUT_HOST_DIR. This could be fixed by changing the existing assignments to assign to the _WITHOUT_HOST_DIR version, and then have one:
TARGET_CROSS = $(HOST_DIR)/$(TARGET_CROSS_WITHOUT_HOST_DIR)

Thanks,
Thomas

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=6818

Thomas De Schampheleire <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Thomas De Schampheleire <[email protected]> 2014-02-13 14:56:44 UTC --- Apparently, the submitter has sent the patch in the meantime:
http://patchwork.ozlabs.org/patch/316696/

I will therefore close this bug and let the patch follow standard patch submission and review process.

Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.