New: [PATCH] lua - add shared library patch and config option for readline/ncurses support
https://bugs.busybox.net/show_bug.cgi?id=803
Summary: [PATCH] lua - add shared library patch and config option
for readline/ncurses support
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Windows
Status: NEW
Severity: enhancement
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: rvpaasen at t3i.nl
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Created an attachment (id=831)
--> (https://bugs.busybox.net/attachment.cgi?id=831)
lua patch
This patch includes a shared library patch (based on a patch from the debian repository). It also adds a config option to build without readline and ncurses, and a config option to choose if the compiler and interpreter should be installed.
It applies to the current git repository.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
https://bugs.busybox.net/show_bug.cgi?id=803
Gustavo Zacarias <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gustavo at zacarias.com.ar
--- Comment #1 from Gustavo Zacarias <[email protected]> 2009-12-14 20:16:31 UTC ---
You're probably missing a patch in your patch file since normally lua doesn't build shared libs (a patch to lua's Makefile to be precise), maybe you forgot to include it?
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
Quoted 12 lines · bugzilla at busybox.net
https://bugs.busybox.net/show_bug.cgi?id=803
Gustavo Zacarias <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gustavo at zacarias.com.ar
Quoted 6 lines
--- Comment #1 from Gustavo Zacarias <[email protected]> 2009-12-14 20:16:31 UTC ---
You're probably missing a patch in your patch file since normally lua doesn't build shared libs (a patch to lua's
Makefileto be precise), maybe you forgot to include it?
Depends on the version - but the current and recent version have had the makefile reorganized to always build-in the standard libraries;
So yes, the makefile needs to be un-reorganized (by a patch?) to get Lua + shared libraries out of it.
(The prior to 5.0 organization).
Mike
Quoted 1 line
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
Quoted 7 lines · Michael S. Zick
Depends on the version - but the current and recent version have had the makefile reorganized to always build-in the standard libraries;
So yes, the makefile needs to be un-reorganized (by a patch?) to get Lua + shared libraries out of it.
(The prior to 5.0 organization).Mike
I think we're on a different tune here.
I'm commenting about the proposed patch that changes the lua package in the following ways:
1) Makes a shared liblua instead of a static one.
2) Allows the package to just install liblua with options for lua and luac.
3) Also allows for lua to be built without readline support. Plain upstream 5.1.4 lua (current in buildroot) doesn't build shared libraries by default, and that's what i talking about (point 1) and the proposed change in buildroot is probably lacking a patch (or the libtool hooks to do so in the .mk file).
Regards.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
Quoted 8 lines · Gustavo Zacarias
Quoted 6 lines · Michael S. Zick
Depends on the version - but the current and recent version have had the makefile reorganized to always build-in the standard libraries;
So yes, the makefile needs to be un-reorganized (by a patch?) to get Lua + shared libraries out of it.
(The prior to 5.0 organization).
Quoted 4 lines
Quoted 1 line
Mike
I think we're on a different tune here.
No, I follow you, there is just two interpertations of "Lua" - See my post on recommending that its inclusion in Buildroot should be reorganized before too much time is spent doing these "special case" changes. I.E: the reorganization described in my post will also give you what you are trying to achieve here.
Mike
Quoted 12 lines
I'm commenting about the proposed patch that changes the lua package in the following ways:
1) Makes a shared liblua instead of a static one.
2) Allows the package to just install liblua with options for lua and luac.
3) Also allows for lua to be built without readline support. Plain upstream 5.1.4 lua (current in buildroot) doesn't build shared libraries by default, and that's what i talking about (point 1) and the proposed change in buildroot is probably lacking a patch (or the libtool hooks to do so in the .mk file).
Regards.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
rvpaasen <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #831 is|0 |1
obsolete| |
--- Comment #2 from rvpaasen <[email protected]> 2009-12-14 22:05:45 UTC --- Created an attachment (id=845)
--> (https://bugs.busybox.net/attachment.cgi?id=845)
lua patch
fixed patch: now created with git format-patch
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
--- Comment #3 from Gustavo Zacarias <[email protected]> 2009-12-15 14:24:28 UTC --- Could you add -DLUA_USE_DLOPEN to MYCFLAGS?
That way we'll enable the extension loader for shared objects which we most definitely want.
Otherwise it's working good now for me.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
rvpaasen <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #845 is|0 |1
obsolete| |
--- Comment #4 from rvpaasen <[email protected]> 2009-12-15 23:54:45 UTC --- Created an attachment (id=857)
--> (https://bugs.busybox.net/attachment.cgi?id=857)
lua patch with -DLUA_USE_DLOPEN
Patch with -DLUA_USE_DLOPEN added.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
Gustavo Zacarias <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |719
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
Thomas Petazzoni <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2010.05
--- Comment #5 from Thomas Petazzoni <[email protected]> 2010-02-21 22:33:07 UTC --- Move milestone to 2010.05 since enhancements will not be handled before the
release of 2010.02.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
Gustavo Zacarias <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #857 is|0 |1
obsolete| |
AssignedTo|unassigned at buildroot.uclibc.|gustavo at zacarias.com.ar
|org |
Status|NEW |ASSIGNED--- Comment #6 from Gustavo Zacarias <[email protected]> 2010-04-29 21:08:24 UTC --- Created an attachment (id=1597)
--> (https://bugs.busybox.net/attachment.cgi?id=1597)
Migrate lua to gentargets and improve it
Convert the lua package to gentargets.
It also enables new options to install selectively the lua interpreter, compiler and shared library.
This allows us to build lua modules and packages for them in the future among other things.
It defaults to build just the static liblua, users have to enable extra functionality now (interpreter, compiler, shared liblua in target).
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED--- Comment #7 from Peter Korsgaard <[email protected]> --- Thanks, committed. I've fixed up Config.in though, as lua/luac dynamically links to liblua.so.*, so they need to select it.
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
PATCH 1/1 lua - add shared library patch and config option for readline/ncurses support
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=803
--- Comment #8 from Gustavo Zacarias <[email protected]> --- Sure about that?
lua/luac just link to liblua.so only when it's built.
When the SHARED option is disabled liblua.so isn't built so they just link statically against liblua.a ...
Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.