i40e PMD contains copy-pasted bug from mempool library

https://bugs.dpdk.org/show_bug.cgi?id=923

Bug ID: 923
Summary: i40e PMD contains copy-pasted bug from mempool library
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

The mempool library does not flush its cache correctly, but leaves it full after flushing.
This bug is fixed in [1], but remains in the i40e PMD, which contains copy-pasted code [2] from the mempool library.

Other PMDs with copy-pasted code may have the same bug.

[1]
http://inbox.dpdk.org/dev/[email protected]/T/#u

[2]
http://code.dpdk.org/dpdk/latest/source/drivers/net/i40e/i40e_rxtx_vec_avx512.c#L919

You are receiving this mail because:
You are the assignee for the bug.

To: i40e, iavf, ice PMD maintainers
CC: mempool library maintainers

Grep rte_mempool_default_cache could indicate that the AVX512 code in the iavf and ice PMDs also have this bug.

https://bugs.dpdk.org/show_bug.cgi?id=923

Morten Brørup ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Morten Brørup ([email protected]) --- Copy-pasting internal code and not using the mempool API causes more problems than just the risk of spreading bugs from the library it is copied from to the destinations where it is copied.

*** This bug has been marked as a duplicate of bug 1052 ***

You are receiving this mail because:
You are the assignee for the bug.