New: toolchain-external misses lib directory when copying sysroot
https://bugs.busybox.net/show_bug.cgi?id=9771
Bug ID: 9771
Summary: toolchain-external misses lib directory when copying
sysroot
Product: buildroot
Version: 2016.11
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: sir.ferdek+buildroot at gmail.com
CC: buildroot at uclibc.org
Target Milestone: ---
I have x86_64 cross-toolchain build using crosstool-ng framework, not too old commit from master branch, circa half month old. I was unable to use it with buildroot due to wrong toolchain installation performed by buildroot.
Packages' autoconf scripts complain about unusable compiler, due to missing libgcc_s.so which is in x86_64-unknown-linux-gnu/sysroot/lib
The lib directory is not copied by buildroot during install phase.
This little fix below allowed me to build my system image, although I would like to ask you if this is complete - I guess no. The reason I ask is that I saw very complicated logic somewhere in pkg-toolchain-external.mk and I suspect that this is the place where it should be fixed...
toolchain/helpers.mk +1 -1
@@ -88,7 +88,7 @@ copy_toolchain_sysroot = \ ARCH_SUBDIR="$(strip $3)"; \ ARCH_LIB_DIR="$(strip $4)" ; \ SUPPORT_LIB_DIR="$(strip $5)" ; \ - for i in etc $${ARCH_LIB_DIR} sbin usr usr/$${ARCH_LIB_DIR}; do \ + for i in etc lib $${ARCH_LIB_DIR} sbin usr usr/$${ARCH_LIB_DIR}; do \ if [ ! -d $${ARCH_SYSROOT_DIR}/$$i ] ; then \ continue ; \ fi ; \
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
https://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #1 from Thomas Petazzoni <[email protected]> --- Your patch shouldn't be necessary because $${ARCH_LIB_DIR} in the loop should be responsible for copying the contents of lib/.
Can you share a tarball of the toolchain you have built with Crosstool-NG, so we can see why it doesn't work as expected?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #2 from sir.ferdek+buildroot at gmail.com --- I hope this is OK:
https://drive.google.com/open?id=0B-dCRyKJ6D3zTTJJU192VTZJLWc
From what I remember while debugging this, $${ARCH_LIB_DIR} is equal to lib64, while there are still some libraries in lib dir that need to be copied.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #3 from Arnout Vandecappelle <[email protected]> --- Can you try if http://patchwork.ozlabs.org/patch/725387/ fixes this? You'll have to apply the preceding 3 patches as well, and there may be a few merge issues.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #4 from Thomas Petazzoni <[email protected]> --- (In reply to Arnout Vandecappelle from comment #3)
Arnout, what makes you think those patches will fix the issue? From a quick look at the toolchain, I don't see anything being in <sysroot>/lib/<variant>, all libraries are in <sysroot>/lib64, which is the standard organization that we should just support fine today.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #5 from Thomas Petazzoni <[email protected]> --- OK, so the issue is that some libraries are in <sysroot>/lib64 (C library) and some others are in <sysroot>/lib (gcc runtime), which is not something Buildroot handles I believe.
Buildroot does a:
$ ./bin/x86_64-unknown-linux-gnu-gcc -print-file-name=libc.a /home/thomas/dl/x86_64-unknown-linux-gnu/bin/../x86_64-unknown-linux-gnu/sysroot/usr/lib/../lib64/libc.a
And therefore decides that ARCH_LIB_DIR is "lib64", and therefore looks only in <sysroot>/lib64 for libraries and not in <sysroot>/lib.
Is this a recent change in Crosstool-NG ? The old Crosstool-NG toolchain we have at
http://autobuild.buildroot.net/toolchains/tarballs/x86_64-ctng_locales-linux-gnu.tar.xz
has everything in <sysroot>/lib, with <sysroot>/lib64 being a symbolic link to <sysroot>/lib.
So, are we looking at a Buildroot bug, or a Crosstool-NG bug?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #6 from sir.ferdek+buildroot at gmail.com --- (In reply to Thomas Petazzoni from comment #5)
Quoted 1 line
So, are we looking at a Buildroot bug, or a Crosstool-NG bug?
Looks like this is known and ongoing development. I have found a recent activity regarding this issue in Crostool-NG.
https://github.com/crosstool-ng/crosstool-ng/pull/639
And then, look at this commit message from 12 days ago (included in merged pull request):
https://github.com/crosstool-ng/crosstool-ng/pull/639/commits/63b2a19de4b33f304b236850028b6c6f32ce51e2
I guess it might require both Buildroot and CT-NG to synchronize on this issue... :D
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #7 from Thomas De Schampheleire <[email protected]> --- In the mentioned ct-ng issue I see they are 'working on' a buildroot patch. However, my toolchain patches already make a fair amount of changes to the logic, and it makes no sense that other toolchain patches would now be developed unless based on top of my changes. Would it be possible to apply my patches first, then see what are the remaining issues for some toolchains?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
Thomas Petazzoni <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at buildroot.uclibc |patrickdepinguin at gmail.com
|.org |
--- Comment #8 from Thomas Petazzoni <[email protected]> --- I tested with the latest Buildroot (which includes the changes Thomas DS was mentioning in his comment), and indeed the separation of lib/ (for gcc libraries) and lib64/ has the consequence that libgcc_s.so is not copied to staging nor to target.
The proposal to include "lib" in the list of folders from the sysroot to copy seems sensible to me, perhaps we should add "usr/lib" as well.
Thomas DS, any comment on this ?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #9 from Carlos Santos <[email protected]> ---
This bug has been dormant for more that one year. Is it still relevant now that both buildroot's patch 725387 and ct-NG'a PR 639 were merged?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
--- Comment #10 from Thomas De Schampheleire <[email protected]> --- Sorry, it seems I never saw comment #8.
Copying the entire 'lib' from the external toolchain's sysroot into staging/target will copy too much for some multilib toolchains, e.g. similar to the octeon toolchain described in http://patchwork.ozlabs.org/patch/725387/ but with 'lib/octeon2' instead of 'lib32/octeon2'. I think there are also other toolchains where this will be a problem.
So, if the original problem is still an issue with current Buildroot and reasonably recent toolchains, then I think a better solution should be found.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 9771] toolchain-external misses lib directory when copying sysroot
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=9771
Yann E. MORIN <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |MOVED
CC| |[email protected]
Status|NEW |RESOLVED--- Comment #11 from Yann E. MORIN <[email protected]> --- THank you for your report.
The issue tracker for the Buildroot project has been moved to the Gitlab.com issue tracker:
https://gitlab.com/buildroot.org/buildroot/-/issues
We are taking this opportunity to close old issues in this old tracker. If you believe your issue is still relevant, please open one in the new issue tracker.
Thank you!
Signature · 6 lines
You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot