Skip to contentSkip to conversation

New: Build fails with "unexpected EOF while looking for matching `"'" if PATH contains a newline

Buildroot bugzilla at busybox.net 1 participant 4 messages May 20, 2017 – Jun 8, 2017

lore
Share & tools
lore

bugzilla at busybox.net

author
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=9886

Bug ID: 9886
Summary: Build fails with "unexpected EOF while looking for
matching `"'" if PATH contains a newline
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: ciro.santilli at gmail.com
CC: buildroot at uclibc.org
Target Milestone: ---

I know newlines in PATH are bad, but we shouldn't punish unsuspecting users with unhelpful error messages because of it :-)

Reproduce:

    git checkout 4d1c2c82e8945a5847d636458f3825c55529835b
    make qemu_x86_64_defconfig
    PATH="$PATH:"$'\n'":lalala" make

Gives:

Quoted 1 line
Quoted 1 line
Quoted 1 line

host-lzip 1.18 Downloading

/bin/bash: -c: line 0: unexpected EOF while looking for matching `"' /bin/bash: -c: line 1: syntax error: unexpected end of file package/pkg-generic.mk:139: recipe for target '/data/git/buildroot/output/build/host-lzip-1.18/.stamp_downloaded' failed make[1]: *** [/data/git/buildroot/output/build/host-lzip-1.18/.stamp_downloaded] Error 1 Makefile:79: recipe for target '_all' failed
make: *** [_all] Error 2

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
author
#1 lore raw

[Buildroot] [Bug 9886] Build fails with "unexpected EOF while looking for matching `"'" if PATH contains a newline

https://bugs.busybox.net/show_bug.cgi?id=9886

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

           Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
                   |.org                        |
             Status|NEW                         |ASSIGNED
                 CC|                            |yann.morin.1998 at free.fr

--- Comment #1 from Yann E. MORIN <[email protected]> --- Ciro,

Thanks for the report.

Indeed, having a \n in PATH is a bit stupid... :-/

I've sent a patch that detects that and fails early:

    https://patchwork.ozlabs.org/patch/764947/

Regards,
Yann E. MORIN.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.
author
#3 lore raw

[Buildroot] [Bug 9886] Build fails with "unexpected EOF while looking for matching `"'" if PATH contains a newline

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=9886

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Yann E. MORIN <[email protected]> --- A patch has been applied in master to fix that:

https://git.buildroot.org/buildroot/commit/?id=f00d6ec67bd6fed6ff8fd322d60d026ec87d8a6e

Thanks for the report.

Signature · 2 lines
You are receiving this mail because:
You are on the CC list for the bug.