Skip to contentSkip to conversation

irq 0?

DISCUSSION Miles Bader 2 participants 3 messages Nov 7, 2005

lore
Share & tools
lore
#0 lore raw

I notice that arch/v850/kernel/irq.c has been updated with a "show_interrupts" function; in this function it contains the following bit of code:

	if (i == 0) {
		seq_puts(p, "           ");
		for (i=0; i < 1 /*smp_num_cpus*/; i++)
			seq_printf(p, "CPU%d       ", i);
		seq_putc(p, '\n');
	}

	if (i < NR_IRQS) {
                ... show interrupt i ...
	} else if (i == NR_IRQS)
		seq_printf(p, "ERR: %10lu\n", irq_err_count);

where "i" is iterated (by procfs) from 0...NR_IRQS.

On the v850, irq 0 is a real interrupt, so this doesn't really work properly -- it doesn't display an entry for irq 0.

Is it now illegal for irq 0 to be a real interrupt (was it illegal before)? Or is the procfs code just bogus?

Thanks,

-miles

Signature · 1 line
Occam's razor split hairs so well, I bought the whole argument!
#1 lore raw
Quoted 17 lines · Miles Bader

I notice that arch/v850/kernel/irq.c has been updated with a "show_interrupts" function; in this function it contains the following bit of code:

	if (i == 0) {
		seq_puts(p, "           ");
		for (i=0; i < 1 /*smp_num_cpus*/; i++)
			seq_printf(p, "CPU%d       ", i);
		seq_putc(p, '\n');
	}

	if (i < NR_IRQS) {
                ... show interrupt i ...
	} else if (i == NR_IRQS)
		seq_printf(p, "ERR: %10lu\n", irq_err_count);
Quoted 4 lines

where "i" is iterated (by procfs) from 0...NR_IRQS.

On the v850, irq 0 is a real interrupt, so this doesn't really work properly -- it doesn't display an entry for irq 0.

What makes you say that? The i==0 code seems to fall through and therefore should print IRQ0 just fine.

Ian.

Signature · 4 lines
Ian Campbell
Current Noise: Vader - The Final Massacre

Ignore previous fortune.
#2 lore raw
Quoted 5 lines · Ian Campbell
Quoted 2 lines

On the v850, irq 0 is a real interrupt, so this doesn't really work properly -- it doesn't display an entry for irq 0.

What makes you say that? The i==0 code seems to fall through and therefore should print IRQ0 just fine.

Gee you're right... silly me. :-/

Thanks,

-miles

Signature · 1 line
Run away!  Run away!