nvme: check at least one ns identification reported
PATCH 1/1 nvme: check at least one ns identification reported
Per 2.1 base NVMe spec:
At least one Namespace Identification Descriptor identifying the namespace (i.e., NIDT field set to 1h, 2h, or 3h).
Check there is at least one reported.
--- drivers/nvme/host/core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/nvme/host/core.c +14 -2
@@ -1426,7 +1426,7 @@ static int nvme_identify_ctrl(struct nvme_ctrl *dev, struct nvme_id_ctrl **id) }static int nvme_process_ns_desc (struct nvme_ctrl *ctrl,struct nvme_ns_ids *ids, -struct nvme_ns_id_desc *cur,bool *csi_seen) +struct nvme_ns_id_desc *cur,bool *csi_seen,bool *has_id) {const char *warn_str ="ctrl returned bogus length:" ;void *data = cur;
@@ -1438,6 +1438,7 @@ static int nvme_process_ns_desc(struct nvme_ctrl *ctrl, struct nvme_ns_ids *ids, warn_str, cur->nidl);return -1 ; } + *has_id = true;if (ctrl->quirks &NVME_QUIRK_BOGUS_NID )return NVME_NIDT_EUI64_LEN ;memcpy (ids->eui64, data +sizeof (*cur),NVME_NIDT_EUI64_LEN );
@@ -1448,6 +1449,7 @@ static int nvme_process_ns_desc(struct nvme_ctrl *ctrl, struct nvme_ns_ids *ids, warn_str, cur->nidl);return -1 ; } + *has_id = true;if (ctrl->quirks &NVME_QUIRK_BOGUS_NID )return NVME_NIDT_NGUID_LEN ;memcpy (ids->nguid, data +sizeof (*cur),NVME_NIDT_NGUID_LEN );
@@ -1458,6 +1460,7 @@ static int nvme_process_ns_desc(struct nvme_ctrl *ctrl, struct nvme_ns_ids *ids, warn_str, cur->nidl);return -1 ; } + *has_id = true;if (ctrl->quirks &NVME_QUIRK_BOGUS_NID )return NVME_NIDT_UUID_LEN ;uuid_copy (&ids->uuid, data +sizeof (*cur));
@@ -1482,6 +1485,7 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl, {struct nvme_command c = { };bool csi_seen = false; +bool has_id = false;int status, pos, len;void *data;
@@ -1513,13 +1517,21 @@ static int nvme_identify_ns_descs(struct nvme_ctrl *ctrl,if (cur->nidl ==0 )break ; - len =nvme_process_ns_desc (ctrl, &info->ids, cur, &csi_seen); + len =nvme_process_ns_desc (ctrl, &info->ids, cur, + &csi_seen, &has_id);if (len <0 )break ; len +=sizeof (*cur); } +if (!has_id) { +dev_warn (ctrl->device, +"No identification reported for nsid:%d\n" , + info->nsid); + status = -EINVAL ; + } +if (nvme_multi_css (ctrl) && !csi_seen) {dev_warn (ctrl->device,"Command set not reported for nsid:%d\n" , info->nsid);
Signature · 1 line
2.43.0
Christoph Hellwig
maintainerQuoted 4 lines · Guixin Liu
Per 2.1 base NVMe spec:
At least one Namespace Identification Descriptor identifying the namespace (i.e., NIDT field set to 1h, 2h, or 3h).
Check there is at least one reported.
NVMe 1.0 didn't have any of these identifier, so it's unfortunate but perfectly valid if devices don't have any.
Quoted 7 lines · Christoph Hellwig
Quoted 4 lines · Guixin Liu
Per 2.1 base NVMe spec:
At least one Namespace Identification Descriptor identifying the namespace (i.e., NIDT field set to 1h, 2h, or 3h).
Check there is at least one reported.NVMe 1.0 didn't have any of these identifier, so it's unfortunate but perfectly valid if devices don't have any.
Maybe I can add a "NVME_VS > 1.0" check?
Best Regards,
Guixin Liu