net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
PATCH 1/1 net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
In RGMII mode the 10Mbps link speed is supported only when CPSW2G MAC SL is configured for External Control ("in band") mode CPSW_PN_MAC_CONTROL_REG.CTL_EN(18) = 1
Hence update am65_cpsw_update_link() to follow documentation.
--- drivers/net/ti/am65-cpsw-nuss.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ti/am65-cpsw-nuss.c +4 -0
@@ -61,6 +61,7 @@#define AM65_CPSW_MACSL_CTL_REG 0x0#define AM65_CPSW_MACSL_CTL_REG_IFCTL_A BIT(15) +#define AM65_CPSW_MACSL_CTL_EXT_EN BIT(18)#define AM65_CPSW_MACSL_CTL_REG_GIG BIT(7)#define AM65_CPSW_MACSL_CTL_REG_GMII_EN BIT(5)#define AM65_CPSW_MACSL_CTL_REG_LOOPBACK BIT(1)
@@ -187,6 +188,9 @@ static int am65_cpsw_update_link(struct am65_cpsw_priv *priv)AM65_CPSW_MACSL_CTL_REG_GMII_EN ;if (phy->speed ==1000 ) mac_control |=AM65_CPSW_MACSL_CTL_REG_GIG ; +if (phy->speed ==10 &&phy_interface_is_rgmii (phy)) +/* Can be used with in band mode only */ + mac_control |=AM65_CPSW_MACSL_CTL_EXT_EN ;if (phy->duplex ==DUPLEX_FULL ) mac_control |=AM65_CPSW_MACSL_CTL_REG_FULL_DUPLEX ;if (phy->speed ==100 )
Signature · 1 line
2.17.0
PATCH 1/1 net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
+ Lokesh
Quoted 34 lines · Murali Karicheri
In RGMII mode the 10Mbps link speed is supported only when CPSW2G MAC SL is configured for External Control ("in band") mode
CPSW_PN_MAC_CONTROL_REG.CTL_EN(18)= 1Hence update
am65_cpsw_update_link()to follow documentation.Signed-off-by Murali Karicheri <[email protected]>--- drivers/net/ti/am65-cpsw-nuss.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/ti/am65-cpsw-nuss.c +4
-0@@ -61,6 +61,7 @@#define AM65_CPSW_MACSL_CTL_REG 0x0#define AM65_CPSW_MACSL_CTL_REG_IFCTL_A BIT(15) +#define AM65_CPSW_MACSL_CTL_EXT_EN BIT(18)#define AM65_CPSW_MACSL_CTL_REG_GIG BIT(7)#define AM65_CPSW_MACSL_CTL_REG_GMII_EN BIT(5)#define AM65_CPSW_MACSL_CTL_REG_LOOPBACK BIT(1)@@ -187,6 +188,9 @@ static int am65_cpsw_update_link(struct am65_cpsw_priv *priv)AM65_CPSW_MACSL_CTL_REG_GMII_EN ;if (phy->speed ==1000 ) mac_control |=AM65_CPSW_MACSL_CTL_REG_GIG ; +if (phy->speed ==10 &&phy_interface_is_rgmii (phy)) +/* Can be used with in band mode only */ + mac_control |=AM65_CPSW_MACSL_CTL_EXT_EN ;if (phy->duplex ==DUPLEX_FULL ) mac_control |=AM65_CPSW_MACSL_CTL_REG_FULL_DUPLEX ;if (phy->speed ==100 )
Signature · 2 lines
Murali Karicheri Texas Instruments
PATCH 1/1 net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
Quoted 28 lines · Murali Karicheri
+ Lokesh
Quoted 25 lines · Murali Karicheri
In RGMII mode the 10Mbps link speed is supported only when CPSW2G MAC SL is configured for External Control ("in band") mode
CPSW_PN_MAC_CONTROL_REG.CTL_EN(18)= 1Hence update
am65_cpsw_update_link()to follow documentation.Signed-off-by Murali Karicheri <[email protected]>---
?drivers/net/ti/am65-cpsw-nuss.c| 4 ++++
? 1 file changed, 4 insertions(+)drivers/net/ti/am65-cpsw-nuss.c +0
-0@@ -61,6 +61,7 @@? #define
AM65_CPSW_MACSL_CTL_REG???????????0x0? #defineAM65_CPSW_MACSL_CTL_REG_IFCTL_A??????? BIT(15) +#defineAM65_CPSW_MACSL_CTL_EXT_EN??????? BIT(18) ? #defineAM65_CPSW_MACSL_CTL_REG_GIG??????? BIT(7) ? #defineAM65_CPSW_MACSL_CTL_REG_GMII_EN??????? BIT(5) ? #defineAM65_CPSW_MACSL_CTL_REG_LOOPBACK??? BIT(1)drivers/net/ti/am65-cpsw-nuss.c +0
-0@@ -187,6 +188,9 @@ static int am65_cpsw_update_link(struct am65_cpsw_priv *priv) ??????????????????? AM65_CPSW_MACSL_CTL_REG_GMII_EN; ????????? if (phy->speed == 1000)
Quoted 9 lines
drivers/net/ti/am65-cpsw-nuss.c static int am65_cpsw_update_link(struct am65_cpsw_priv *priv) · line 196
Quoted 8 lines
drivers/net/ti/am65-cpsw-nuss.c +3
-0????????????? mac_control |= AM65_CPSW_MACSL_CTL_REG_GIG; +??????? if (phy->speed == 10 && phy_interface_is_rgmii(phy)) +??????????? /* Can be used with in band mode only */ +??????????? mac_control |= AM65_CPSW_MACSL_CTL_EXT_EN; ????????? if (phy->duplex == DUPLEX_FULL) ????????????? mac_control |= AM65_CPSW_MACSL_CTL_REG_FULL_DUPLEX; ????????? if (phy->speed == 100)
Signature · 2 lines
Best regards, grygorii
PATCH 1/1 net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
Hi Joe,
Quoted 5 lines · Grygorii Strashko
Quoted 2 lines · Murali Karicheri
+ Lokesh
Quoted 8 lines
Quoted 8 lines · Murali Karicheri
Quoted 7 lines
In RGMII mode the 10Mbps link speed is supported only when CPSW2G MAC SL is configured for External Control ("in band") mode
CPSW_PN_MAC_CONTROL_REG.CTL_EN(18)= 1Hence update
am65_cpsw_update_link()to follow documentation.Signed-off-by Murali Karicheri <[email protected]>
I see this in my patchworks. Do you want me to pick it up or will you pick it up? Can you provide your review if you want me to pick it up?
Thanks and regards,
Lokesh
PATCH 1/1 net: ethernet: ti: am65-cpsw-nuss: enable 10Mbps link speed in rgmii mode
In reply to Murali KaricheriQuoted 10 lines · Murali Karicheri
+ Lokesh
Quoted 7 lines · Murali Karicheri
In RGMII mode the 10Mbps link speed is supported only when CPSW2G MAC SL is configured for External Control ("in band") mode
CPSW_PN_MAC_CONTROL_REG.CTL_EN(18)= 1Hence update
am65_cpsw_update_link()to follow documentation.Signed-off-by Murali Karicheri <[email protected]>
Merged into u-boot-ti.
Thanks and regards,
Lokesh