Skip to contentSkip to conversation

fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()

PATCH Applied Vasily Averin 2 participants 2 messages Aug 19, 2019 – Oct 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()

Currently fuse_writepages_fill() calls get_fuse_inode() few times with the same argument.

---
 fs/fuse/file.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/fuse/file.c +1 -3
index e076c2cf65b0..bc9b64ef7b5d 100644
@@ -1874,7 +1874,7 @@ static int fuse_writepages_fill(struct page *page,
 
 	if (!data->ff) {
 		err = -EIO;
-		data->ff = fuse_write_file_get(fc, get_fuse_inode(inode));
+		data->ff = fuse_write_file_get(fc, fi);
 		if (!data->ff)
 			goto out_unlock;
 	}
@@ -1919,8 +1919,6 @@ static int fuse_writepages_fill(struct page *page,
 	 * under writeback, so we can release the page lock.
 	 */
 	if (data->req == NULL) {
-		struct fuse_inode *fi = get_fuse_inode(inode);
-
 		err = -ENOMEM;
 		req = fuse_request_alloc_nofs(FUSE_REQ_INLINE_PAGES);
 		if (!req) {
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Vasily Averin

Currently fuse_writepages_fill() calls get_fuse_inode() few times with the same argument.

Thanks, applied.

Miklos