Skip to contentSkip to conversation

arm64: Default to 4K translation granule

PATCH In review Oliver Upton 5 participants 7 messages May 2, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: Default to 4K translation granule

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

---
 configure | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
configure +2 -6
index 49f047cb2d7d..4ac2ff3e6106 100755
@@ -75,7 +75,7 @@ usage() {
 	                           (s390x only)
 	    --page-size=PAGE_SIZE
 	                           Specify the page size (translation granule) (4k, 16k or
-	                           64k, default is 64k, arm64 only)
+	                           64k, default is 4k, arm64 only)
 	    --earlycon=EARLYCON
 	                           Specify the UART name, type and address (optional, arm and
 	                           arm64 only). The specified address will overwrite the UART
@@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
 fi
 
 if [ -z "$page_size" ]; then
-    if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
-        page_size="4096"
-    elif [ "$arch" = "arm64" ]; then
-        page_size="65536"
-    elif [ "$arch" = "arm" ]; then
+    if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
         page_size="4096"
     fi
 else
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
#1 lore raw
Quoted 7 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

What about using "getconf PAGESIZE" to get the page size of the host environment? Would that work, too?

Thomas

#2 lore raw

Hi,

Quoted 11 lines · Thomas Huth
Quoted 7 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

What about using "getconf PAGESIZE" to get the page size of the host environment? Would that work, too?

That would definitely make the tests run, but I'm worried about reproducibility. If you want to re-run a failed test on a different machine, this introduces a new variable, the host's page size, which might be different between the machines. Or, if you want to look it another way, another configuration knob that the user has to be aware of and control.

Unless there's a system out there that doesn't support 4K pages, I'm in favour of having 4K the default.

Thanks,
Alex

Quoted 4 lines

Thomas

#3 lore raw
In reply to Oliver Upton
Quoted 7 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

Yeah, this makes sense. The original 64k default didn't have any real justification. I only selected it since I had been drinking the "64k pages will rule the world" Kool-Aid for too long. The effects of that Kool-Aid have already long worn off though, so I'll get this merged.

Thanks,
drew

Quoted 35 lines
---
 configure | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
configure +2 -6
index 49f047cb2d7d..4ac2ff3e6106 100755
@@ -75,7 +75,7 @@ usage() {
 	                           (s390x only)
 	    --page-size=PAGE_SIZE
 	                           Specify the page size (translation granule) (4k, 16k or
-	                           64k, default is 64k, arm64 only)
+	                           64k, default is 4k, arm64 only)
 	    --earlycon=EARLYCON
 	                           Specify the UART name, type and address (optional, arm and
 	                           arm64 only). The specified address will overwrite the UART
@@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
 fi
 
 if [ -z "$page_size" ]; then
-    if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
-        page_size="4096"
-    elif [ "$arch" = "arm64" ]; then
-        page_size="65536"
-    elif [ "$arch" = "arm" ]; then
+    if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
         page_size="4096"
     fi
 else
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
#4 lore raw
Quoted 11 lines · Andrew Jones
Quoted 7 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

I had been drinking the "64k pages will rule the world" Kool-Aid for too long.

Hey, your words not mine! :-)

Quoted 1 line

Kool-Aid have already long worn off though, so I'll get this merged.

Thanks drew.

Signature · 2 lines
Best,
Oliver
Acked-by on v1 1/1
#5 lore raw
In reply to Oliver Upton
Quoted 4 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Yup, I had to manually specify the translation granule before building (and running) these tests on M1.

./configure --arch=aarch64 --page-size={4k,16k} --cross-prefix=aarch64-elf-

Quoted 4 lines

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

#6 lore raw
In reply to Oliver Upton
Quoted 42 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

---
 configure | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
configure +2 -6
index 49f047cb2d7d..4ac2ff3e6106 100755
@@ -75,7 +75,7 @@ usage() {
 	                           (s390x only)
 	    --page-size=PAGE_SIZE
 	                           Specify the page size (translation granule) (4k, 16k or
-	                           64k, default is 64k, arm64 only)
+	                           64k, default is 4k, arm64 only)
 	    --earlycon=EARLYCON
 	                           Specify the UART name, type and address (optional, arm and
 	                           arm64 only). The specified address will overwrite the UART
@@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
 fi
 
 if [ -z "$page_size" ]; then
-    if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
-        page_size="4096"
-    elif [ "$arch" = "arm64" ]; then
-        page_size="65536"
-    elif [ "$arch" = "arm" ]; then
+    if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
         page_size="4096"
     fi
 else
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog

Merged.

Thanks,
drew