be2net: fix data race in be_get_new_eqd
Subsystems (3)
PATCH 1/1 be2net: fix data race in be_get_new_eqd
In be_get_new_eqd(), statistics of pkts, protected by u64_stats_sync, are read and accumulated in ignorance of possible u64_stats_fetch_retry() events. Before the commit in question, these statistics were retrieved one by one directly from queues. Fix this by reading them into temporary variables first.
--- drivers/net/ethernet/emulex/benet/be_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/net/ethernet/emulex/benet/be_main.c +5 -3
@@ -2141,7 +2141,7 @@ static int be_get_new_eqd(struct be_eq_obj *eqo)struct be_aic_obj *aic;struct be_rx_obj *rxo;struct be_tx_obj *txo; -u64 rx_pkts =0 , tx_pkts =0 ; +u64 rx_pkts =0 , tx_pkts =0 , pkts;ulong now;u32 pps, delta;int i;
@@ -2157,15 +2157,17 @@ static int be_get_new_eqd(struct be_eq_obj *eqo) for_all_rx_queues_on_eq(adapter, eqo, rxo, i) {do { start =u64_stats_fetch_begin (&rxo->stats.sync); - rx_pkts += rxo->stats.rx_pkts; + pkts = rxo->stats.rx_pkts; }while (u64_stats_fetch_retry (&rxo->stats.sync, start)); + rx_pkts += pkts; } for_all_tx_queues_on_eq(adapter, eqo, txo, i) {do { start =u64_stats_fetch_begin (&txo->stats.sync); - tx_pkts += txo->stats.tx_reqs; + pkts = txo->stats.tx_reqs; }while (u64_stats_fetch_retry (&txo->stats.sync, start)); + tx_pkts += pkts; }/* Skip, if wrapped around or first calculation */
Signature · 1 line
2.51.0
Quoted 8 lines · David Yang
In
be_get_new_eqd(), statistics of pkts, protected byu64_stats_sync, are read and accumulated in ignorance of possibleu64_stats_fetch_retry()events. Before the commit in question, these statistics were retrieved one by one directly from queues. Fix this by reading them into temporary variables first.Fixes 209477704187 ("be2net: set interrupt moderation for Skyhawk-R using EQ-DB")Signed-off-by David Yang <[email protected]>
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 19 Jan 2026 23:34:36 +0800 you wrote:
In
be_get_new_eqd(), statistics of pkts, protected byu64_stats_sync, are read and accumulated in ignorance of possibleu64_stats_fetch_retry()events. Before the commit in question, these statistics were retrieved one by one directly from queues. Fix this by reading them into temporary variables first.Fixes 209477704187 ("be2net: set interrupt moderation for Skyhawk-R using EQ-DB")Signed-off-by David Yang <[email protected]>[...]
Here is the summary with links:
- [net] be2net: fix data race in be_get_new_eqd
https://git.kernel.org/netdev/net/c/302e5b481caa
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html