fixes for cmd_fpga.c
PATCH 1/1 fixes for cmd_fpga.c
The attached patch:
1) fixes a bug with the 'fpga loadb' command
The bug is in calculating the config data size - 4 bytes of length info were being read as signed chars, casted to long, shifted and added. The cast to long was doing sign extension and causing an incorrect result if a byte was greater than 0x80. For me this caused the fpga load to end early and time out waiting for the hardware completion.
2) removes compilation warnings about using __FUNCTION__ concatenated with strings
3) changes the fpga loadb to always print the file header info during a load.
I realize this patch is a mishmash - hopefully it's helpful to someone.
Signature · 6 lines
Hardware, n.:
The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-cmdfpga-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050111/6208c8b0/attachment.txt PATCH 1/1 fixes for cmd_fpga.c
Quoted 4 lines · In message <[email protected]> you wrote:
The attached patch:
1) fixes a bug with the 'fpga loadb' command
...
Quoted 4 lines
2) removes compilation warnings about using
__FUNCTION__concatenated with strings3) changes the fpga loadb to always print the file header info during a load.
Added, thanks.
Next time please don't forget to include a CHANGELOG entry!
Best regards,
Wolfgang Denk
Signature · 7 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Many companies that have made themselves dependent on [the equipment
of a certain major manufacturer] (and in doing so have sold their
soul to the devil) will collapse under the sheer weight of the un-
mastered complexity of their data processing systems.
-- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5