Skip to contentSkip to conversation

tools/bmp_logo.c using incorrect offset to pixel data

PATCH New Andrew Dyer 2 participants 2 messages Feb 1, 2005 – Sep 25, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/bmp_logo.c using incorrect offset to pixel data

The attached patch makes bmp_logo.c use the header information about the start of pixel data in the bmp file instead of trying to find the start itself. If someone wants a test case bmp file that will produce incorrect output with the current code e-mail me and I can send it along. The bug was seen with the tool compiled/running under redhat 7.3 on x86 arch. The visual indication was that the bitmap was shifted to the right with a section of garbage displayed in the lower left corner. The source bmp displays fine with Win2000.

I would suggest it's worth noting in the somewhere in docs that include/bmp_logo.h is overwritten by the default build environment (with the Denx logo :-( ). I added a line like this to my board config.mk file to override this behavior.

#logo bitmap
LOGO_BMP = ../board/eldorado/rht_small_logo.bmp

Signature · 6 lines
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-bmp_logo-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050131/73d71123/attachment.txt 
#1 lore raw

PATCH 1/1 tools/bmp_logo.c using incorrect offset to pixel data

Quoted 9 lines · In message <[email protected]> you wrote:

The attached patch makes bmp_logo.c use the header information about the start of pixel data in the bmp file instead of trying to find the start itself. If someone wants a test case bmp file that will produce incorrect output with the current code e-mail me and I can send it along. The bug was seen with the tool compiled/running under redhat 7.3 on x86 arch. The visual indication was that the bitmap was shifted to the right with a section of garbage displayed in the lower left corner. The source bmp displays fine with Win2000.

Added, thanks. But please provide a CHANGELOG entry next time. And make sure to use TAB for indentation.

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a man sits with a pretty girl for  an  hour,  it  seems  like  a
minute.  But let him sit on a hot stove for a minute -- and it's lon-
ger than any hour. That's relativity.              -- Albert Einstein