Skip to contentSkip to conversation

libxl: except Dom0 from setting PoD target

PATCH In review Jan Beulich 3 participants 4 messages Aug 27, 2025 – Sep 8, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl: except Dom0 from setting PoD target

Dom0 is never started in PoD mode, and hence it can at "best" do harm if we try to set a PoD target for it.

tools/libs/light/libxl_mem.c +1 -1
@@ -306,7 +306,7 @@ retry_transaction:
         }
     }
 
-    if (d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
+    if (domid && d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
         r = xc_domain_set_pod_target(ctx->xch, domid,
                 (new_target_memkb + size) / 4, NULL, NULL, NULL);
         if (r != 0) {
#2 lore raw
Quoted 7 lines · Jason Andryuk
Quoted 4 lines · Jan Beulich

Dom0 is never started in PoD mode, and hence it can at "best" do harm if we try to set a PoD target for it.

Thanks.

Quoted 1 line

Did you observe an issue, or just notice this when inspecting the code?

It simply caught my eye while investigating the ballooning issue I sent a mail about.

Quoted 1 line

If an issue, please add to the commit message.

I would have, sure.

Jan