Skip to contentSkip to conversation

Fix building eth_p_all demo with Mercury core

PATCH Applied Vitaly Chikunov 2 participants 3 messages Sep 24, 2020 – Sep 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix building eth_p_all demo with Mercury core

Error message:

In file included from eth_p_all.c:43:
/usr/include/xenomai/boilerplate/ancillaries.h:56:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__early_panic’
56 | void __noreturn __early_panic(const char *fn,

      |                 ^~~~~~~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:59:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘___panic’
   59 | void __noreturn ___panic(const char *fn,
      |                 ^~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:63:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__panic’
   63 | void __noreturn __panic(const char *fn,
      |                 ^~~~~~~
---
 demo/posix/cobalt/eth_p_all.c | 1 +
 1 file changed, 1 insertion(+)
demo/posix/cobalt/eth_p_all.c +1 -0
index 91aef9fbd..ad4c54878 100644
@@ -40,6 +40,7 @@
 #include <net/if.h>
 #include <arpa/inet.h>
 #include <netinet/ether.h>
+#include <boilerplate/compiler.h>
 #include <boilerplate/ancillaries.h>
 
 char buffer[10*1024];
Signature · 1 line
2.21.0
Applied
#1 lore raw
Quoted 24 lines · Vitaly Chikunov

Error message:

In file included from eth_p_all.c:43:
/usr/include/xenomai/boilerplate/ancillaries.h:56:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__early_panic’
56 | void __noreturn __early_panic(const char *fn,

      |                 ^~~~~~~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:59:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘___panic’
   59 | void __noreturn ___panic(const char *fn,
      |                 ^~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:63:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__panic’
   63 | void __noreturn __panic(const char *fn,
      |                 ^~~~~~~
---
 demo/posix/cobalt/eth_p_all.c | 1 +
 1 file changed, 1 insertion(+)
demo/posix/cobalt/eth_p_all.c +0 -0
index 91aef9fbd..ad4c54878 100644

demo/posix/cobalt/eth_p_all.c line 46

Quoted 7 lines
demo/posix/cobalt/eth_p_all.c +1 -0
@@ -40,6 +40,7 @@
 #include <net/if.h>
 #include <arpa/inet.h>
 #include <netinet/ether.h>
+#include <boilerplate/compiler.h>
 #include <boilerplate/ancillaries.h>
 
 char buffer[10*1024];

Thanks, applied.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
#2 lore raw
Quoted 30 lines · Jan Kiszka via Xenomai
Quoted 29 lines · Vitaly Chikunov

Error message:

In file included from eth_p_all.c:43:
/usr/include/xenomai/boilerplate/ancillaries.h:56:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__early_panic’
56 | void __noreturn __early_panic(const char *fn,

      |                 ^~~~~~~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:59:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘___panic’
   59 | void __noreturn ___panic(const char *fn,
      |                 ^~~~~~~~
/usr/include/xenomai/boilerplate/ancillaries.h:63:17: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__panic’
   63 | void __noreturn __panic(const char *fn,
      |                 ^~~~~~~
---
 demo/posix/cobalt/eth_p_all.c | 1 +
 1 file changed, 1 insertion(+)
demo/posix/cobalt/eth_p_all.c +1 -0
index 91aef9fbd..ad4c54878 100644
@@ -40,6 +40,7 @@
 #include <net/if.h>
 #include <arpa/inet.h>
 #include <netinet/ether.h>
+#include <boilerplate/compiler.h>
 #include <boilerplate/ancillaries.h>
 
Quoted 7 lines

demo/posix/cobalt/eth_p_all.c line 46

Quoted 2 lines
demo/posix/cobalt/eth_p_all.c +0 -0
 char buffer[10*1024];

Thanks, applied.

Jan

Strictly spoken, this is under "cobalt", originally not intended for mercury. But nothing speaks against making this compile with any core.

But looking at the code again, the intention was not make it depend on xenomai-specifics (boilerplate/ancillaries.h) which is now causing the problem on mercury. Let's rather get rid of namecpy.

Pulling this back, will send a different fix.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux