Skip to contentSkip to conversation

nvme-trace: Add fabrics command opcode name

PATCH New Minwoo Im 3 participants 5 messages May 5, 2019 – May 6, 2019 NVMe

lore
Share & tools
lore

Minwoo Im

author
#0 lore raw

PATCH 1/1 nvme-trace: Add fabrics command opcode name

Opcode 0x7F is for fabrics commands. We can also print it out "nvme_fabrics_command" instead of 0x7f in raw.

Before this patch:
cmd=(0x7f cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ......

After this patch:
cmd=(nvme_fabrics_command cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ....

It would be nicer if trace can show which command in fabrics commands are now being excuted, but not for this time.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
---
 drivers/nvme/host/trace.h | 1 +
 1 file changed, 1 insertion(+)
drivers/nvme/host/trace.h +1 -0
index 97d3c77365b8..f91580bf2e2f 100644
@@ -37,6 +37,7 @@
 		nvme_admin_opcode_name(nvme_admin_directive_send),	\
 		nvme_admin_opcode_name(nvme_admin_directive_recv),	\
 		nvme_admin_opcode_name(nvme_admin_dbbuf),		\
+		nvme_admin_opcode_name(nvme_fabrics_command),		\
 		nvme_admin_opcode_name(nvme_admin_format_nvm),		\
 		nvme_admin_opcode_name(nvme_admin_security_send),	\
 		nvme_admin_opcode_name(nvme_admin_security_recv),	\
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 nvme-trace: Add fabrics command opcode name

Please do not mix admin and fabric commands.

Quoted 30 lines · Minwoo Im

Opcode 0x7F is for fabrics commands. We can also print it out "nvme_fabrics_command" instead of 0x7f in raw.

Before this patch:

   cmd=(0x7f cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ......

After this patch:

   cmd=(nvme_fabrics_command cdw10=00 00 00 00 1f 00 00 00 98 3a 00 00 ....

It would be nicer if trace can show which command in fabrics commands are now being excuted, but not for this time.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>
---
  drivers/nvme/host/trace.h | 1 +
  1 file changed, 1 insertion(+)
drivers/nvme/host/trace.h +1 -0
index 97d3c77365b8..f91580bf2e2f 100644
@@ -37,6 +37,7 @@
  		nvme_admin_opcode_name(nvme_admin_directive_send),	\
  		nvme_admin_opcode_name(nvme_admin_directive_recv),	\
  		nvme_admin_opcode_name(nvme_admin_dbbuf),		\
+		nvme_admin_opcode_name(nvme_fabrics_command),		\
  		nvme_admin_opcode_name(nvme_admin_format_nvm),		\
  		nvme_admin_opcode_name(nvme_admin_security_send),	\
  		nvme_admin_opcode_name(nvme_admin_security_recv),	\
#2 lore raw

PATCH 1/1 nvme-trace: Add fabrics command opcode name

Quoted 1 line · Chaitanya Kulkarni

Please do not mix admin and fabric commands.

Well, "the" fabrics command is an opcode that can show up on admin or I/O queues. "the" because it actually is a multiplexer, and we probably want to decode it instead of just saying fabrics command in the traces.

author
#3 lore raw

PATCH 1/1 nvme-trace: Add fabrics command opcode name

Quoted 8 lines · Christoph Hellwig
Quoted 1 line · Chaitanya Kulkarni

Please do not mix admin and fabric commands.

Well, "the" fabrics command is an opcode that can show up on admin or I/O queues. "the" because it actually is a multiplexer, and we probably want to decode it instead of just saying fabrics command in the traces.

I'll prepare V2 patch with decoding opcode to show which fabrics commands are going on in the trace.

Thanks,

author
#4 lore raw

PATCH 1/1 nvme-trace: Add fabrics command opcode name

In reply to Chaitanya Kulkarni
Quoted 1 line · Chaitanya Kulkarni

Please do not mix admin and fabric commands.

Chaitanya,

Thanks for your review. I'll prepare V2 for this.

Thanks,