Skip to contentSkip to conversation

travis.yml: Drop the default softmmu builds

RFC PATCH In review Thomas Huth 4 participants 7 messages Aug 5, 2020 – Sep 16, 2020

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 travis.yml: Drop the default softmmu builds

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)
.travis.yml +0 -14
index 6695c0620f..18290bc51d 100644
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:
Signature · 1 line
2.18.1
#1 lore raw
Quoted 31 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)
.travis.yml +0 -7
index 6695c0620f..18290bc51d 100644
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-

.travis.yml jobs: · line 128

Quoted 10 lines
.travis.yml +0 -7
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:

Ping?

Thomas

#2 lore raw
Quoted 36 lines · Thomas Huth
Quoted 35 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)
.travis.yml +0 -12
index 6695c0620f..18290bc51d 100644
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
Quoted 8 lines

.travis.yml jobs: · line 128

Quoted 6 lines
.travis.yml +0 -2
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:

Ping?

Ping^2 ... Alex, Philippe, any opinions on this patch?

Thomas

Acked-by
#3 lore raw
Quoted 46 lines · Thomas Huth
Quoted 36 lines · Thomas Huth
Quoted 35 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)
.travis.yml +0 -12
index 6695c0620f..18290bc51d 100644
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
Quoted 8 lines

.travis.yml jobs: · line 128

Quoted 6 lines
.travis.yml +0 -2
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:

Ping?

Quoted 1 line

Ping^2 ... Alex, Philippe, any opinions on this patch?

I'm agnostic on this. Is it worth slightly reducing our coverage for ~50 minutes of runtime out of 10 hours? I guess it would be a bit greener.

Signature · 1 line
Alex Bennée
#4 lore raw
Quoted 49 lines · Alex Bennée
Quoted 46 lines · Thomas Huth
Quoted 44 lines · Thomas Huth
Quoted 31 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)
.travis.yml +0 -7
index 6695c0620f..18290bc51d 100644
@@ -123,20 +123,6 @@ jobs:
         - CONFIG="--disable-system --static"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
 
-
-    # we split the system builds as it takes a while to build them all
-    - name: "GCC (main-softmmu)"
-      env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-

.travis.yml jobs: · line 128

Quoted 10 lines
.travis.yml +0 -7
-
-    - name: "GCC (other-softmmu)"
-      env:
-       - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-
-
     # Just build tools and run minimal unit and softfloat checks
     - name: "GCC check-softfloat (user)"
       env:

Ping?

Quoted 4 lines
Quoted 1 line

Ping^2 ... Alex, Philippe, any opinions on this patch?

I'm agnostic on this. Is it worth slightly reducing our coverage for ~50 minutes of runtime out of 10 hours? I guess it would be a bit greener.

For the last Travis run that succeeded for me, I've got:

Ran for 1 hr 48 min 32 sec
Total time 7 hrs 58 min 6 sec

That means the total run time was less than 2h, it's just the total summed up time of all jobs that is ~8h.

Since both Gitlab und Cirrus jobs finish within one hour, it would be very convenient to have Travis also finish within one hour, so once you've pushed your branches to gitlab and github, you could be sure to get an answer from these three CI systems within 1 hour.

Quoted 1 line

Thanks!

Thomas

Reviewed-by on v1 1/1
#5 lore raw
In reply to Thomas Huth
Quoted 11 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

Yep, we explicitly don't care about Xenial. Even if we did care about Xenial, we could put such a job on GitLab CI instead.

IIUC, the main unique feature wrt Travis vs GitLab are potential for non-x86 hardware testing, and functional use of KVM. So if the job isn't using one of the unique Travis features, we should cull it from Travis and GitLab if the job is still appicable.

Quoted 2 lines
 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#6 lore raw
Quoted 13 lines · Daniel P. Berrangé
Quoted 11 lines · Thomas Huth

The total runtime of all Travis jobs is very long and we are testing all softmmu targets in the gitlab-CI already - so we can speed up the Travis testing a little bit by not testing the softmmu targets here anymore.

---
Well, ok, we do not test all the softmmu targets on gitlab-CI with that same ancient version of Ubuntu ... but do we still care about testing all softmmut targets on Ubuntu Xenial at all? ... at least according to our support policy, we do not care about Xenial anymore.

Quoted 7 lines

Yep, we explicitly don't care about Xenial. Even if we did care about Xenial, we could put such a job on GitLab CI instead.

IIUC, the main unique feature wrt Travis vs GitLab are potential for non-x86 hardware testing, and functional use of KVM. So if the job isn't using one of the unique Travis features, we should cull it from Travis and GitLab if the job is still appicable.

Agreed.

(Sorry for missing this patch)

Quoted 11 lines
Quoted 3 lines
 .travis.yml | 14 --------------
 1 file changed, 14 deletions(-)

Regards,
Daniel