Skip to contentSkip to conversation

dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt schema

PATCH Superseded Kanak Shilledar 2 participants 4 messages Jun 20, 2024 – Jun 24, 2024

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt schema

Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts, clocks, #address-cells and #size-cells as required properties.

Additional changes to the original .txt binding
- added maintainer from the MAINTAINERS file.
- added resets property required by the corresponding DTS files.

---
Changes in v2:
- updated subject line to include device name.
- changed removed description from properties except clock-frequency.
- updated MAINTAINERS to track this file.

---
 .../devicetree/bindings/i2c/i2c-lpc2k.txt     | 33 -----------
 .../bindings/i2c/nxp,lpc1788-i2c.yaml         | 56 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 57 insertions(+), 34 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml
Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt deleted +0 -33
deleted file mode 100644
index 4101aa621ad4..000000000000
@@ -1,33 +0,0 @@
-NXP I2C controller for LPC2xxx/178x/18xx/43xx
-
-Required properties:
- - compatible: must be "nxp,lpc1788-i2c"
- - reg: physical address and length of the device registers
- - interrupts: a single interrupt specifier
- - clocks: clock for the device
- - #address-cells: should be <1>
- - #size-cells: should be <0>
-
-Optional properties:
-- clock-frequency: the desired I2C bus clock frequency in Hz; in
-  absence of this property the default value is used (100 kHz).
-
-Example:
-i2c0: i2c@400a1000 {
-	compatible = "nxp,lpc1788-i2c";
-	reg = <0x400a1000 0x1000>;
-	interrupts = <18>;
-	clocks = <&ccu1 CLK_APB1_I2C0>;
-	#address-cells = <1>;
-	#size-cells = <0>;
-};
-
-&i2c0 {
-	clock-frequency = <400000>;
-
-	lm75@48 {
-		compatible = "nxp,lm75";
-		reg = <0x48>;
-	};
-};
-
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +56 -0

56 lines not on this page · raw message

MAINTAINERS +1 -1
index cf9c9221c388..920e4f28b5ae 100644
@@ -2374,7 +2374,7 @@ ARM/LPC18XX ARCHITECTURE
 M:	Vladimir Zapolskiy <[email protected]>
 L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
-F:	Documentation/devicetree/bindings/i2c/i2c-lpc2k.txt
+F:	Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml
 F:	arch/arm/boot/dts/nxp/lpc/lpc43*
 F:	drivers/i2c/busses/i2c-lpc2k.c
 F:	drivers/memory/pl172.c
Signature · 1 line
2.45.2
#1 lore raw
Quoted 5 lines · Kanak Shilledar

Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts, clocks, #address-cells and #size-cells as required properties.

Thank you for your patch. There is something to discuss/improve.

Quoted 7 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +7 -0
+  clocks:
+    maxItems: 1
+
+  clock-frequency:
+    description: the desired I2C bus clock frequency in Hz
+    default: 100000
+

Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 41

Quoted 10 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +10 -0
+  resets:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - "#address-cells"
+  - "#size-cells"

These should not be required, because you can have an enabled I2C controller without children in DT.

Quoted 1 line

+

Best regards,
Krzysztof

#2 lore raw
Quoted 23 lines · Krzysztof Kozlowski
Quoted 5 lines · Kanak Shilledar

Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx to newer DT schema. Created DT schema based on the .txt file which had compatible, reg, interrupts, clocks, #address-cells and #size-cells as required properties.

Thank you for your patch. There is something to discuss/improve.

Quoted 12 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +12 -0
+  clocks:
+    maxItems: 1
+
+  clock-frequency:
+    description: the desired I2C bus clock frequency in Hz
+    default: 100000
+
+  resets:
+    maxItems: 1
+
+required:
+  - compatible
Quoted 8 lines

Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 41

Quoted 5 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +5 -0
+  - reg
+  - interrupts
+  - clocks
+  - "#address-cells"
+  - "#size-cells"

These should not be required, because you can have an enabled I2C controller without children in DT.

You suggest removing the address cells and size cells from the required properties?
I saw a few i2c dt-bindings and these had the address cells and size cells in the required
property.

Quoted 4 lines

Best regards,
Krzysztof

Thanks and Regards,
Kanak Shilledar

#3 lore raw
Quoted 12 lines · Kanak Shilledar
Quoted 11 lines

Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml line 41

Quoted 8 lines
Documentation/devicetree/bindings/i2c/nxp,lpc1788-i2c.yaml new file +8 -0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - "#address-cells"
+  - "#size-cells"

These should not be required, because you can have an enabled I2C controller without children in DT.

Quoted 2 lines

You suggest removing the address cells and size cells from the required properties?

Yes.

Quoted 3 lines

I saw a few i2c dt-bindings and these had the address cells and size cells in the required
property.

Could be.

Best regards,
Krzysztof