drm/amdgpu: Fix the uninitialized variable warning
Subsystems (2)
PATCH v3 1/1 drm/amdgpu: Fix the uninitialized variable warning
Check the user input and phy_id value range to fix "Using uninitialized value phy_id"
Signed-off-by Ma Jun <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c +4 -0
@@ -135,6 +135,10 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __umutex_unlock (&psp->securedisplay_context.mutex);break ;case 2 : +if (size <3 || phy_id >=TA_SECUREDISPLAY_MAX_PHY ) { +dev_err (adev->dev,"Invalid input: %s\n" , str); +return -EINVAL ; + }mutex_lock (&psp->securedisplay_context.mutex);psp_prep_securedisplay_cmd_buf (psp, &securedisplay_cmd,TA_SECUREDISPLAY_COMMAND__SEND_ROI_CRC );
Signature · 1 line
2.34.1
ping ...
Quoted 23 lines · Ma Jun
Check the user input and
phy_idvalue range to fix "Using uninitialized valuephy_id"Signed-off-by Ma Jun <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c +4
-0@@ -135,6 +135,10 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __umutex_unlock (&psp->securedisplay_context.mutex);break ;case 2 : +if (size <3 || phy_id >=TA_SECUREDISPLAY_MAX_PHY ) { +dev_err (adev->dev,"Invalid input: %s\n" , str); +return -EINVAL ; + }mutex_lock (&psp->securedisplay_context.mutex);psp_prep_securedisplay_cmd_buf (psp, &securedisplay_cmd,TA_SECUREDISPLAY_COMMAND__SEND_ROI_CRC );
Quoted 5 lines · Ma Jun
Check the user input and
phy_idvalue range to fix "Using uninitialized valuephy_id"Signed-off-by Ma Jun <[email protected]>
Reviewed-by Alex Deucher <[email protected]>
Quoted 22 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c +4
-1@@ -135,6 +135,10 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __umutex_unlock (&psp->securedisplay_context.mutex);break ;case 2 : +if (size <3 || phy_id >=TA_SECUREDISPLAY_MAX_PHY ) { +dev_err (adev->dev,"Invalid input: %s\n" , str); +return -EINVAL ; + }mutex_lock (&psp->securedisplay_context.mutex);psp_prep_securedisplay_cmd_buf (psp, &securedisplay_cmd,TA_SECUREDISPLAY_COMMAND__SEND_ROI_CRC ); --2.34.1