Skip to contentSkip to conversation

vfs: fs_context: Modify mismatched function name

PATCH In review Jiapeng Chong 2 participants 2 messages Oct 20, 2022 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vfs: fs_context: Modify mismatched function name

No functional modification involved.

fs/fs_context.c:347: warning: expecting prototype for vfs_dup_fc_config(). Prototype was for vfs_dup_fs_context() instead.

---
 fs/fs_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fs_context.c +1 -1
index df04e5fc6d66..be45701cd998 100644
@@ -340,7 +340,7 @@ void fc_drop_locked(struct fs_context *fc)
 static void legacy_fs_context_free(struct fs_context *fc);
 
 /**
- * vfs_dup_fc_config: Duplicate a filesystem context.
+ * vfs_dup_fs_context: Duplicate a filesystem context.
  * @src_fc: The context to copy.
  */
 struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw

Hi--

Quoted 16 lines · Jiapeng Chong

No functional modification involved.

fs/fs_context.c:347: warning: expecting prototype for vfs_dup_fc_config(). Prototype was for vfs_dup_fs_context() instead.

---
 fs/fs_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fs_context.c +0 -0
index df04e5fc6d66..be45701cd998 100644

fs/fs_context.c void fc_drop_locked(struct fs_context *fc) · line 343

Quoted 5 lines
fs/fs_context.c +1 -1
@@ -340,7 +340,7 @@ void fc_drop_locked(struct fs_context *fc)
 static void legacy_fs_context_free(struct fs_context *fc);
 
 /**
- * vfs_dup_fc_config: Duplicate a filesystem context.
+ * vfs_dup_fs_context: Duplicate a filesystem context.

That is still not the correct kernel-doc format (or syntax). The ':' should be a '-' instead.

Also, I see scripts/kernel-doc reporting 16 kernel-doc format problems in this file. How about fixing more than just one of them, please.

fs_context.c:95: warning: No description found for return value of 'vfs_parse_fs _param_source'
fs_context.c:128: warning: No description found for return value of 'vfs_parse_f s_param'
fs_context.c:168: warning: Function parameter or member 'fc' not described in 'v fs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'key' not described in ' vfs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'value' not described in
'vfs_parse_fs_string'
fs_context.c:168: warning: Function parameter or member 'v_size' not described i n 'vfs_parse_fs_string'
fs_context.c:168: warning: No description found for return value of 'vfs_parse_f s_string'
fs_context.c:202: warning: Function parameter or member 'fc' not described in 'g eneric_parse_monolithic'
fs_context.c:202: warning: Excess function parameter 'ctx' description in 'gener ic_parse_monolithic'
fs_context.c:202: warning: No description found for return value of 'generic_par se_monolithic'
fs_context.c:252: warning: No description found for return value of 'alloc_fs_co ntext'
fs_context.c:340: warning: No description found for return value of 'vfs_dup_fs_ context'
fs_context.c:386: warning: Function parameter or member 'log' not described in ' logfc'
fs_context.c:386: warning: Function parameter or member 'prefix' not described i n 'logfc'
fs_context.c:386: warning: Function parameter or member 'level' not described in
'logfc'
fs_context.c:386: warning: Excess function parameter 'fc' description in 'logfc' 16 warnings

Quoted 3 lines
fs/fs_context.c +0 -0
  * @src_fc: The context to copy.
  */
 struct fs_context *vfs_dup_fs_context(struct fs_context *src_fc)
Signature · 1 line
~Randy