Skip to contentSkip to conversation

drm/amdgpu: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

PATCH In review Alex Deucher 2 participants 2 messages Feb 18, 2019 – Feb 19, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

Based on a similar patch from Rafael for radeon.

When using ATPX to control dGPU power, the state is not retained across suspend and resume cycles by default. This can probably be loosened for Hybrid Graphics (_PR3) laptops where I think the state is properly retained.

Fixes c62ec4610c40 ("PM / core: Fix direct_complete handling for devices with no callbacks")
Cc Rafael J. Wysocki <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -0
index d63cb53ff2bb..eaf90cdc848d 100644
@@ -212,6 +212,7 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
 	}
 
 	if (amdgpu_device_is_px(dev)) {
+		dev_pm_set_driver_flags(dev->dev, DPM_FLAG_NEVER_SKIP);
 		pm_runtime_use_autosuspend(dev->dev);
 		pm_runtime_set_autosuspend_delay(dev->dev, 5000);
 		pm_runtime_set_active(dev->dev);
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190218221948.3602-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 10 lines · Alex Deucher

Based on a similar patch from Rafael for radeon.

When using ATPX to control dGPU power, the state is not retained across suspend and resume cycles by default. This can probably be loosened for Hybrid Graphics (_PR3) laptops where I think the state is properly retained.

Fixes c62ec4610c40 ("PM / core: Fix direct_complete handling for devices with no callbacks")
Cc Rafael J. Wysocki <[email protected]>
Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +0 -0
index d63cb53ff2bb..eaf90cdc848d 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags) · line 218

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +1 -0
@@ -212,6 +212,7 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
  	}
 
  	if (amdgpu_device_is_px(dev)) {
+		dev_pm_set_driver_flags(dev->dev, DPM_FLAG_NEVER_SKIP);
  		pm_runtime_use_autosuspend(dev->dev);
  		pm_runtime_set_autosuspend_delay(dev->dev, 5000);
  		pm_runtime_set_active(dev->dev);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx