ARMv8.4-TTST extension
cover ARMv8.4-TTST extension
Hello,
The following changes since commit 6d3fd902ab9c4d6762532d4b5cce2275e458aa32:
target/arm: refactor vae1_tlbmask() (2020-12-18 12:27:56 +0200)
follow. They add support for small translation tables, allowing for translation regimes as small as 16-bits. This extension is nominally a required dependency of Secure EL2.
----------------------------------------------------------------
Rémi Denis-Courmont (3):
target/arm: keep translation start level unsigned target/arm: ARMv8.4-TTST extension target/arm: enable Small Translation tables in max CPU
target/arm/cpu.h | 5 +++++ target/arm/cpu64.c | 1 + target/arm/helper.c | 25 +++++++++++++++---------- 3 files changed, 21 insertions(+), 10 deletions(-)
Signature · 1 line
Rémi Denis-Courmont
PATCH 1/3 target/arm: keep translation start level unsigned
From: Rémi Denis-Courmont <[email protected]>
--- target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
target/arm/helper.c +6 -8
@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck; -/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } - startsizecheck = inputsize - ((3 - level) * stride + grainsize);if (startsizecheck <1 || startsizecheck > stride +4 ) {return false;
@@ -10856,6 +10851,9 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level,if (level ==0 && pamax <=42 ) {return false; } +if (level ==3 ) { +return false; + }break ;default :g_assert_not_reached ();
@@ -10871,7 +10869,7 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level,/* AArch32 only supports 4KB pages. Assert on that. */ assert (stride ==9 ); -if (level ==0 ) { +if (level ==0 || level >=3 ) {return false; } }
@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address,if (!aarch64 || stride ==9 ) {/* AArch32 or 4KB pages */ - startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ; }else {/* 16KB or 64KB pages */ startlevel =3 - sl0;
Signature · 1 line
2.29.2
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 6 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>--- target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
The patch does more than what is described above.
Quoted 11 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level, +static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, uint32_t level,
target/arm/helper.c do_fault: · line 10834
Quoted 10 lines
target/arm/helper.c +0
-5int inputsize, int stride) {const int grainsize = stride +3 ;int startsizecheck; -/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -
I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
r~
Quoted 32 lines
target/arm/helper.c +5
-2startsizecheck = inputsize - ((3 - level) * stride + grainsize);if (startsizecheck <1 || startsizecheck > stride +4 ) {return false;@@ -10856,6 +10851,9 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level,if (level ==0 && pamax <=42 ) {return false; } +if (level ==3 ) { +return false; + }break ;default :g_assert_not_reached ();@@ -10871,7 +10869,7 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level,/* AArch32 only supports 4KB pages. Assert on that. */ assert (stride ==9 ); -if (level ==0 ) { +if (level ==0 || level >=3 ) {return false; } }@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address,if (!aarch64 || stride ==9 ) {/* AArch32 or 4KB pages */ - startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ; }else {/* 16KB or 64KB pages */ startlevel =3 - sl0;
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 26 lines · Richard Henderson
Quoted 6 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>--- target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
Quoted 16 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck;
Quoted 8 lines
target/arm/helper.c do_fault: · line 10834
Quoted 5 lines
target/arm/helper.c +0
-5-/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
Having read the next patch, I think you should drop this type change.
Quoted 6 lines
target/arm/helper.c static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, · line 11204
Quoted 6 lines
target/arm/helper.c +1
-1@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address,if (!aarch64 || stride ==9 ) {/* AArch32 or 4KB pages */ - startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ;
This hunk belongs with the next patch, implementing TTST, and should be conditional. I.e.
if (stride == 9) {
startlevel = 2 - sl0;
if (aarch64 &&
cpu_isar_feature(aa64_st, env_archcpu(env)) {
startlevel &= 3;
}
...r~
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 56 lines · Le jeudi 31 décembre 2020, 00:38:14 EET Richard Henderson a écrit :
Quoted 32 lines · Richard Henderson
Quoted 7 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>---
target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
Quoted 21 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck;Quoted 8 lines
target/arm/helper.c do_fault: · line 10834
Quoted 5 lines
target/arm/helper.c +0
-5-/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
Having read the next patch, I think you should drop this type change.
Quoted 8 lines
target/arm/helper.c static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, · line 11204
Quoted 8 lines
target/arm/helper.c +0
-0@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env,
uint64_taddress,>>if (!aarch64 || stride == 9) { /* AArch32 or 4KB pages */target/arm/helper.c +1
-1- startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ;This hunk belongs with the next patch, implementing TTST, and should be conditional. I.e.
Quoted 6 lines
if (stride == 9) {
startlevel = 2 - sl0;
if (aarch64 &&
cpu_isar_feature(aa64_st, env_archcpu(env)) {
startlevel &= 3;
}You can do that but:
1) Nothing in the spec says that SL0 == b11 without ST means start level -1. It's undefined, and I don't see any reasons to treat it differently than with ST.
2) Functionally, checking for ST seems to belong naturally within check_s2_mmu_setup() in this particular case.
Quoted 4 lines
...r~
Signature · 1 line
Rémi Denis-Courmont
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 64 lines · Rémi Denis-Courmont
Quoted 56 lines · Le jeudi 31 décembre 2020, 00:38:14 EET Richard Henderson a écrit :
Quoted 32 lines · Richard Henderson
Quoted 7 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>---
target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
Quoted 21 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck;Quoted 8 lines
target/arm/helper.c do_fault: · line 10834
Quoted 5 lines
target/arm/helper.c +0
-5-/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
Having read the next patch, I think you should drop this type change.
Quoted 8 lines
target/arm/helper.c static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, · line 11204
Quoted 8 lines
target/arm/helper.c +0
-0@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env,
uint64_taddress,>>if (!aarch64 || stride == 9) { /* AArch32 or 4KB pages */target/arm/helper.c +1
-1- startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ;This hunk belongs with the next patch, implementing TTST, and should be conditional. I.e.
Quoted 6 lines
if (stride == 9) { startlevel = 2 - sl0; if (aarch64 && cpu_isar_feature(aa64_st, env_archcpu(env)) { startlevel &= 3; }
Quoted 4 lines
You can do that but:
1) Nothing in the spec says that SL0 == b11 without ST means start level -1. It's undefined, and I don't see any reasons to treat it differently than with ST.
By that logic there's no reason to treat it differently at all; you could drop the feature check entirely. In lieu, -1 makes a decent error indicator.
Quoted 2 lines
2) Functionally, checking for ST seems to belong naturally within
check_s2_mmu_setup()in this particular case.
I guess. I'll leave it to Peter's preference.
r~
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 71 lines · Richard Henderson
Quoted 64 lines · Rémi Denis-Courmont
Quoted 56 lines · Le jeudi 31 décembre 2020, 00:38:14 EET Richard Henderson a écrit :
Quoted 32 lines · Richard Henderson
Quoted 7 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>---
target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
Quoted 21 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck;Quoted 8 lines
target/arm/helper.c do_fault: · line 10834
Quoted 5 lines
target/arm/helper.c +0
-5-/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
Having read the next patch, I think you should drop this type change.
Quoted 8 lines
target/arm/helper.c static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address, · line 11204
Quoted 8 lines
target/arm/helper.c +0
-0@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env,
uint64_taddress,>>if (!aarch64 || stride == 9) { /* AArch32 or 4KB pages */target/arm/helper.c +1
-1- startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ;This hunk belongs with the next patch, implementing TTST, and should be conditional. I.e.
Quoted 6 lines
if (stride == 9) { startlevel = 2 - sl0; if (aarch64 && cpu_isar_feature(aa64_st, env_archcpu(env)) { startlevel &= 3; }Quoted 4 lines
You can do that but:
1) Nothing in the spec says that SL0 == b11 without ST means start level -1. It's undefined, and I don't see any reasons to treat it differently than with ST.
Quoted 7 lines
By that logic there's no reason to treat it differently at all; you could drop the feature check entirely. In lieu, -1 makes a decent error indicator.
Quoted 2 lines
2) Functionally, checking for ST seems to belong naturally within
check_s2_mmu_setup()in this particular case.I guess. I'll leave it to Peter's preference.
You've reviewed the patchset, I'm happy to go with whatever your preference is (because I don't want to have to duplicate the review work to form an opinion).
thanks
-- PMM
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
In reply to Richard HendersonQuoted 10 lines · Le jeudi 31 décembre 2020, 00:10:09 EET Richard Henderson a écrit :
Quoted 7 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>---
target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
No? It removes generating negative values, and handling them, for translation levels.
Quoted 20 lines
Quoted 20 lines
target/arm/helper.c +1
-1@@ -10821,17 +10821,12 @@ do_fault:* Returns true if the suggested S2 translation parameters are OK and * false otherwise. */ -static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,int level, +static bool check_s2_mmu_setup (ARMCPU *cpu,bool is_aa64,uint32_t level,int inputsize,int stride) {const int grainsize = stride +3 ;int startsizecheck;
Quoted 8 lines
target/arm/helper.c do_fault: · line 10834
Quoted 5 lines
target/arm/helper.c +0
-5-/* Negative levels are never allowed. */ -if (level <0 ) { -return false; - } -I would expect this to be the only hunk from the patch description. Probably changing this negative check to a >= 3 check.
You could do that but you'd end up relying on implicity conversion from signed to unsigned negative. That seems needlessly confusing to me in this case, considering that (positive) values larger than 3 cannot actually happen.
Quoted 52 lines
r~
Quoted 49 lines
startsizecheck = inputsize - ((3 - level) * stride + grainsize); if (startsizecheck < 1 || startsizecheck > stride + 4) { return false;target/arm/helper.c +0
-0@@ -10856,6 +10851,9 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool
is_aa64, int level,>if (level == 0 && pamax <= 42) { return false; }target/arm/helper.c +3
-0+if (level ==3 ) { +return false; + }break ;default :g_assert_not_reached ();@@ -10871,7 +10869,7 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool
is_aa64, int level,>/* AArch32 only supports 4KB pages. Assert on that. */ assert(stride == 9);target/arm/helper.c +1
-1-if (level ==0 ) { +if (level ==0 || level >=3 ) {return false; } }@@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env,
uint64_taddress,>if (!aarch64 || stride == 9) { /* AArch32 or 4KB pages */target/arm/helper.c +1
-1- startlevel =2 - sl0; + startlevel = (2 - sl0) &3 ; }else {/* 16KB or 64KB pages */ startlevel =3 - sl0;
Signature · 1 line
Rémi Denis-Courmont
Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Quoted 7 lines · Rémi Denis-Courmont
Quoted 6 lines · Le jeudi 31 décembre 2020, 00:10:09 EET Richard Henderson a écrit :
Quoted 5 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>---
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
target/arm/helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)The patch does more than what is described above.
No? It removes generating negative values, and handling them, for translation levels.
But the removal of generating negative values, i.e. the mask with 3, is clearly tied to TTST and makes no sense by itself.
Maybe the whole thing is clearer all squashed together...
r~
PATCH 2/3 target/arm: ARMv8.4-TTST extension
In reply to Rémi Denis-CourmontFrom: Rémi Denis-Courmont <[email protected]>
This adds for the Small Translation tables extension in AArch64 state.
--- target/arm/cpu.h | 5 +++++ target/arm/helper.c | 13 ++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)
target/arm/cpu.h +5 -0
@@ -3991,6 +3991,11 @@ static inline bool isar_feature_aa64_uao(const ARMISARegisters *id)return FIELD_EX64 (id->id_aa64mmfr2,ID_AA64MMFR2 ,UAO ) !=0 ; } +static inline bool isar_feature_aa64_st (const ARMISARegisters *id) +{ +return FIELD_EX64 (id->id_aa64mmfr2,ID_AA64MMFR2 ,ST ) !=0 ; +} +static inline bool isar_feature_aa64_bti (const ARMISARegisters *id) {return FIELD_EX64 (id->id_aa64pfr1,ID_AA64PFR1 ,BT ) !=0 ;
target/arm/helper.c +10 -3
@@ -10851,7 +10851,7 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, uint32_t level,if (level ==0 && pamax <=42 ) {return false; } -if (level ==3 ) { +if (level ==3 && !cpu_isar_feature (aa64_st, cpu)) {return false; }break ;
@@ -10946,7 +10946,7 @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, {uint64_t tcr =regime_tcr (env, mmu_idx)->raw_tcr;bool epd, hpd, using16k, using64k; -int select, tsz, tbi; +int select, tsz, tbi, max_tsz;if (!regime_has_2_ranges (mmu_idx)) { select =0 ;
@@ -10981,7 +10981,14 @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, hpd =extract64 (tcr,42 ,1 ); } } - tsz =MIN (tsz,39 );/* TODO: ARMv8.4-TTST */ + +if (cpu_isar_feature (aa64_st,env_archcpu (env))) { + max_tsz =48 - using64k; + }else { + max_tsz =39 ; + } + + tsz =MIN (tsz, max_tsz); tsz =MAX (tsz,16 );/* TODO: ARMv8.2-LVA */ /* Present TBI as a composite with TBID. */
Signature · 1 line
2.29.2
Re: [PATCH 2/3] target/arm: ARMv8.4-TTST extension
Quoted 31 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
This adds for the Small Translation tables extension in AArch64 state.
Signed-off-by Rémi Denis-Courmont <[email protected]>--- target/arm/cpu.h | 5 +++++ target/arm/helper.c | 13 ++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-)target/arm/cpu.h +5
-0@@ -3991,6 +3991,11 @@ static inline bool isar_feature_aa64_uao(const ARMISARegisters *id)return FIELD_EX64 (id->id_aa64mmfr2,ID_AA64MMFR2 ,UAO ) !=0 ; } +static inline bool isar_feature_aa64_st (const ARMISARegisters *id) +{ +return FIELD_EX64 (id->id_aa64mmfr2,ID_AA64MMFR2 ,ST ) !=0 ; +} +static inline bool isar_feature_aa64_bti (const ARMISARegisters *id) {return FIELD_EX64 (id->id_aa64pfr1,ID_AA64PFR1 ,BT ) !=0 ;target/arm/helper.c +0
-0
target/arm/helper.c static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, uint32_t level, · line 10857
Quoted 8 lines
target/arm/helper.c +1
-1@@ -10851,7 +10851,7 @@ static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, uint32_t level,if (level ==0 && pamax <=42 ) {return false; } -if (level ==3 ) { +if (level ==3 && !cpu_isar_feature (aa64_st, cpu)) {return false; }break ;
As mentioned vs patch 1, I think this hunk should be handled differently.
Quoted 16 lines
target/arm/helper.c +2
-2@@ -10946,7 +10946,7 @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, {uint64_t tcr =regime_tcr (env, mmu_idx)->raw_tcr;bool epd, hpd, using16k, using64k; -int select, tsz, tbi; +int select, tsz, tbi, max_tsz;if (!regime_has_2_ranges (mmu_idx)) { select =0 ;@@ -10981,7 +10981,14 @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, hpd =extract64 (tcr,42 ,1 ); } } - tsz =MIN (tsz,39 );/* TODO: ARMv8.4-TTST */ +
target/arm/helper.c ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va, · line 10994
Quoted 10 lines
target/arm/helper.c +7
-0+if (cpu_isar_feature (aa64_st,env_archcpu (env))) { + max_tsz =48 - using64k; + }else { + max_tsz =39 ; + } + + tsz =MIN (tsz, max_tsz); tsz =MAX (tsz,16 );/* TODO: ARMv8.2-LVA */ /* Present TBI as a composite with TBID. */
But the rest of the patch looks good.
r~
PATCH 3/3 target/arm: enable Small Translation tables in max CPU
In reply to Rémi Denis-CourmontFrom: Rémi Denis-Courmont <[email protected]>
--- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+)
target/arm/cpu64.c +1 -0
@@ -670,6 +670,7 @@ static void aarch64_max_initfn(Object *obj) t = cpu->isar.id_aa64mmfr2; t =FIELD_DP64 (t,ID_AA64MMFR2 ,UAO ,1 ); t =FIELD_DP64 (t,ID_AA64MMFR2 ,CNP ,1 );/* TTCNP */ + t =FIELD_DP64 (t,ID_AA64MMFR2 ,ST ,1 );/* TTST */ cpu->isar.id_aa64mmfr2 = t;/* Replicate the same data to the 32-bit id registers. */
Signature · 1 line
2.29.2
Re: [PATCH 3/3] target/arm: enable Small Translation tables in max CPU
Quoted 6 lines · On 12/18/20 6:33 AM, [email protected] wrote:
From: Rémi Denis-Courmont <[email protected]>
Signed-off-by Rémi Denis-Courmont <[email protected]>--- target/arm/cpu64.c | 1 + 1 file changed, 1 insertion(+)
r~