Skip to contentSkip to conversation

arm64: dts: Introduce r8a774a1-beacon-rzg2m-kit

PATCH Superseded Adam Ford 3 participants 8 messages Jul 14, 2020 – Jul 15, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/2 arm64: dts: Introduce r8a774a1-beacon-rzg2m-kit

Beacon EmebeddedWorks, formerly Logic PD is introducing a new SOM and development kit based on the RZ/G2M SoC from Renesas.

The SOM supports eMMC, WiFi and Bluetooth, along with a Cat-M1 cellular radio.

The Baseboard has Ethernet, USB, HDMI, stereo audio in and out, along with a variety of push buttons and LED's, and support for a parallel RGB and an LVDS display.

---
V2: Add support for RGB display, second backlight, fix clock references,
fix Makefile, remove unsupported versaclock features, and fix typos.

arch/arm64/boot/dts/renesas/Makefile +1 -0
index 9b4e7074557c..7bce6ac522b8 100644
@@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2-ex.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2-ex-idk-1110wr.dtb
+dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-beacon-rzg2m-kit.dtb
 
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n.dtb
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n-ex.dtb
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +759 -0

759 lines not on this page · raw message

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi new file +312 -0

312 lines not on this page · raw message

arch/arm64/boot/dts/renesas/r8a774a1-beacon-rzg2m-kit.dts new file +29 -0
new file mode 100644
index 000000000000..2c5b057c30c6
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2020, Compass Electronics Group, LLC
+ */
+
+/dts-v1/;
+
+#include "r8a774a1.dtsi"
+#include "beacon-renesom-som.dtsi"
+#include "beacon-renesom-baseboard.dtsi"
+
+/ {
+	model = "Beacon EmbeddedWorks RZ/G2M Development Kit";
+	compatible = "beacon,beacon-rzg2m", "renesas,r8a774a1";
+
+	aliases {
+		serial0 = &scif2;
+		serial1 = &hscif0;
+		serial2 = &hscif1;
+		serial3 = &scif0;
+		serial4 = &hscif2;
+		serial5 = &scif5;
+		ethernet0 = &avb;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/2 dt-bindings: arm: renesas: Document beacon-rzg2m

Beacon EmbeddedWorks in introducing a development kit based on the Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

---
V2: New to series

Documentation/devicetree/bindings/arm/renesas.yaml +1 -0
index d8fd25bccbf5..0d4dabb4a164 100644
@@ -118,6 +118,7 @@ properties:
         items:
           - enum:
               - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
+              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit
           - const: renesas,r8a774a1
 
       - items:
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH V2 2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

Hello!

Quoted 1 line · Adam Ford

Beacon EmbeddedWorks in introducing a development kit based on the

s/in/is/?

Quoted 12 lines

Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

---
V2: New to series

Documentation/devicetree/bindings/arm/renesas.yaml +0 -0
index d8fd25bccbf5..0d4dabb4a164 100644

Documentation/devicetree/bindings/arm/renesas.yaml properties: · line 121

Quoted 4 lines
Documentation/devicetree/bindings/arm/renesas.yaml +1 -0
@@ -118,6 +118,7 @@ properties:
          items:
            - enum:
                - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
+              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit

Why the vendor-prefixes.yaml file calls it Compass Electronics Group?

[...]

MBR, Sergei

#3 lore raw

Re: [PATCH V2 2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

Hi Sergei,

Quoted 7 lines · Sergei Shtylyov
Quoted 5 lines · Adam Ford

Beacon EmbeddedWorks in introducing a development kit based on the Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

Quoted 9 lines

Documentation/devicetree/bindings/arm/renesas.yaml properties: · line 121

Quoted 7 lines
Documentation/devicetree/bindings/arm/renesas.yaml +1 -0
@@ -118,6 +118,7 @@ properties:
          items:
            - enum:
                - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
+              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit

Why the vendor-prefixes.yaml file calls it Compass Electronics Group?

See commit f756619f26edf74a ("dt-bindings: vendor-prefixes: Add Beacon vendor prefix"):

Beacon EmebeddedWorks is the brand owned by Compass Electronics Group, LLC based out of the United States.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH V2 2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

In reply to Adam Ford
Quoted 5 lines · Adam Ford

Beacon EmbeddedWorks in introducing a development kit based on the Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

i.e. will queue in renesas-devel for v5.9, with the typo pointed out by Sergei fixed.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author
#5 lore raw

Re: [PATCH V2 2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

Quoted 11 lines · Geert Uytterhoeven
Quoted 5 lines · Adam Ford

Beacon EmbeddedWorks in introducing a development kit based on the Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

i.e. will queue in renesas-devel for v5.9, with the typo pointed out by Sergei fixed.

Since you pointed out some stuff I should correct in patch 1/2. Should I just re-submit the first patch by itself, or do you want me to submit 2/2 with these fixes?

adam

Quoted 11 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#6 lore raw

Re: [PATCH V2 2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

Hi Adam,

Quoted 8 lines · Adam Ford
Quoted 7 lines · Geert Uytterhoeven
Quoted 5 lines · Adam Ford

Beacon EmbeddedWorks in introducing a development kit based on the Renesas RZ/G2M platform. This patch adds the entry to the bindings list.

Quoted 7 lines
Quoted 3 lines

i.e. will queue in renesas-devel for v5.9, with the typo pointed out by Sergei fixed.

Since you pointed out some stuff I should correct in patch 1/2. Should I just re-submit the first patch by itself, or do you want me to submit 2/2 with these fixes?

Just resubmitting the first patch is fine for me.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#7 lore raw
In reply to Adam Ford

Hi Adam,

Quoted 6 lines · Adam Ford

Beacon EmebeddedWorks, formerly Logic PD is introducing a new SOM and development kit based on the RZ/G2M SoC from Renesas.

The SOM supports eMMC, WiFi and Bluetooth, along with a Cat-M1 cellular radio.

Quoted 8 lines

The Baseboard has Ethernet, USB, HDMI, stereo audio in and out, along with a variety of push buttons and LED's, and support for a parallel RGB and an LVDS display.

---
V2: Add support for RGB display, second backlight, fix clock references,
fix Makefile, remove unsupported versaclock features, and fix typos.

Thanks for the update!
Looks mostly OK to me, "make dtbs_check" found a few issues, though.

arch/arm64/boot/dts/renesas/Makefile dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb · line 8

Quoted 7 lines
arch/arm64/boot/dts/renesas/Makefile +1 -0
@@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2-ex.dtb
 dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-rev2-ex-idk-1110wr.dtb
+dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-beacon-rzg2m-kit.dtb

Please preserve alphabetical sort order.

Quoted 18 lines
arch/arm64/boot/dts/renesas/Makefile +0 -0
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n.dtb
 dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n-ex.dtb
 
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +11 -0
 
+       lvds {
+               compatible = "panel-lvds";
+               power-supply = <&reg_lcd_reset>;
+               width-mm = <223>;
+               height-mm = <125>;
+               backlight = <&backlight_lvds>;
+               data-mapping = "vesa-24";
+
+               panel-timing {
+                       /* 800x480@60Hz */
+                       clock-frequency = <30000000>;

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 125

Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +10 -0
+                       hactive = <800>;
+                       vactive = <480>;
+                       hsync-len = <48>;
+                       hfront-porch = <40>;
+                       hback-porch = <40>;
+                       vfront-porch = <13>;
+                       vback-porch = <29>;
+                       vsync-len = <3>;
+                       hsync-active = <1>;
+                       vsync-active = <3>;

"make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/panel-timing.yaml":
lvds: panel-timing:vsync-active:0:0: 3 is not one of [0, 1]

Quoted 11 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +11 -0
+                       de-active = <1>;
+                       pixelclk-active = <0>;
+               };
+
+               port {
+                       panel_in: endpoint {
+                               remote-endpoint = <&lvds0_out>;
+                       };
+               };
+       };
+

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 146

Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +10 -0
+       rgb {
+               /* Different LCD with compatible timings */
+               compatible = "rocktech,rk070er9427";
+               backlight = <&backlight_rgb>;
+               enable-gpios = <&gpio1 21 GPIO_ACTIVE_HIGH>;
+               port {
+                       rgb_panel: endpoint {
+                               remote-endpoint = <&du_out_rgb>;
+                       };
+               };

Documentation/devicetree/bindings/display/panel/panel-simple.yaml
rgb: 'power-supply' is a required property

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 348

Quoted 3 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +2 -0
+       };
 
+       versaclock6_bb: versaclock@6a {

As per DT generic node name rules, this should be called "clock-controller@6a". I'm aware that would cause issues with the current driver implementation, so I'll accept this for now. But it would be good to resolve this later.

Quoted 25 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +24 -0
+               compatible = "idt,5p49v6965";
+               reg = <0x6a>;
+               #clock-cells = <1>;
+               clocks = <&x304_clk>;
+               clock-names = "xin";
+               /* CSI0_MCLK, CSI1_MCLK, AUDIO_CLKIN, USB_HUB_MCLK_BB */
+               assigned-clocks = <&versaclock6_bb 1>,
+                                  <&versaclock6_bb 2>,
+                                  <&versaclock6_bb 3>,
+                                  <&versaclock6_bb 4>;
+               assigned-clock-rates =  <24000000>, <24000000>, <24000000>, <24576000>;
+       };
+};
 
+       hd3ss3220@47 {
+               compatible = "ti,hd3ss3220";
+               reg = <0x47>;
+               interrupt-parent = <&gpio6>;
+               interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
+
+               connector {
+                       compatible = "usb-c-connector";
+                       label = "USB-C";
+                       data-role = "dual";
+

arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi line 445

Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +10 -0
+                       ports {
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+
+                               port@1 {
+                                       reg = <1>;
+                                       hd3ss3220_ep: endpoint {
+                                               remote-endpoint = <&usb3_role_switch>;
+                                       };
+                               };

Documentation/devicetree/bindings/connector/usb-connector.yaml
connector: ports: 'port@0' is a required property

For now, I'd ignore that, as it's a contradiction between the usb-connector and the hd3ss3220 bindings.

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi

Quoted 10 lines
arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi new file +4 -0
+                       };
+               };
+       };
+};

index 000000000000..97272f5fa0ab

arch/arm64/boot/dts/renesas/beacon-renesom-som.dtsi new file +1 -0
 
+       versaclock5: versaclock_som@6a {

Same comment: "clock-controller@6a" (ignored for now).

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds