Bluetooth: btmtksdio: Add in-band wakeup support
Subsystems (2)
PATCH v2 1/1 Bluetooth: btmtksdio: Add in-band wakeup support
From: Sean Wang <[email protected]>
Commit ce64b3e94919 ("Bluetooth: mt7921s: Support wake on bluetooth") adds the wake on bluethooth via a dedicated GPIO.
Extend the wake-on-bluetooth to use the SDIO DAT1 pin (in-band wakeup), when supported by the SDIO host driver.
---
v2: enhance the patch description and comments
--- drivers/bluetooth/btmtksdio.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/bluetooth/btmtksdio.c +8 -0
@@ -118,6 +118,7 @@ MODULE_DEVICE_TABLE(sdio, btmtksdio_table);#define BTMTKSDIO_FUNC_ENABLED 3#define BTMTKSDIO_PATCH_ENABLED 4#define BTMTKSDIO_HW_RESET_ACTIVE 5 +#define BTMTKSDIO_INBAND_WAKEUP 6struct mtkbtsdio_hdr {__le16 len;
@@ -1294,6 +1295,9 @@ static bool btmtksdio_sdio_wakeup(struct hci_dev *hdev) .wakeup_delay = cpu_to_le16(0x20), }; +if (test_bit (BTMTKSDIO_INBAND_WAKEUP , &bdev->tx_state)) +return may_wakeup; +if (may_wakeup && bdev->data->chipid ==0x7921 ) {struct sk_buff *skb;
@@ -1384,6 +1388,10 @@ static int btmtksdio_probe(struct sdio_func *func,*/ pm_runtime_put_noidle (bdev->dev); +/* Mark if MMC host supports wake on bluetooth by SDIO */ +if (device_can_wakeup (func->card->host->parent)) +set_bit (BTMTKSDIO_INBAND_WAKEUP , &bdev->tx_state); + err =device_init_wakeup (bdev->dev, true);if (err)bt_dev_err (hdev,"failed to initialize device wakeup" );
Signature · 1 line
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=652944
---Test result---
Test Summary:
CheckPatch PASS 0.90 seconds GitLint PASS 0.56 seconds SubjectPrefix PASS 0.42 seconds BuildKernel PASS 30.71 seconds BuildKernel32 PASS 27.17 seconds Incremental Build with patchesPASS 37.53 seconds TestRunner: Setup PASS 464.66 seconds TestRunner: l2cap-tester PASS 16.55 seconds TestRunner: bnep-tester PASS 5.60 seconds TestRunner: mgmt-tester PASS 97.86 seconds TestRunner: rfcomm-tester PASS 8.98 seconds TestRunner: sco-tester PASS 8.81 seconds TestRunner: smp-tester PASS 8.87 seconds TestRunner: userchan-tester PASS 5.78 seconds
---
Regards,
Linux Bluetooth
AngeloGioacchino Del Regno
maintainerIl 22/06/22 23:56, [email protected] ha scritto:
Quoted 30 lines
From: Sean Wang <[email protected]>
Commit
ce64b3e94919("Bluetooth: mt7921s: Support wake on bluetooth") adds the wake on bluethooth via a dedicated GPIO.Extend the wake-on-bluetooth to use the SDIO DAT1 pin (in-band wakeup), when supported by the SDIO host driver.
Co-developed-by Yake Yang <[email protected]>Signed-off-by Yake Yang <[email protected]>Signed-off-by Sean Wang <[email protected]>---
v2: enhance the patch description and comments--- drivers/bluetooth/btmtksdio.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/bluetooth/btmtksdio.c +1
-0@@ -118,6 +118,7 @@ MODULE_DEVICE_TABLE(sdio, btmtksdio_table);#define BTMTKSDIO_FUNC_ENABLED 3#define BTMTKSDIO_PATCH_ENABLED 4#define BTMTKSDIO_HW_RESET_ACTIVE 5 +#define BTMTKSDIO_INBAND_WAKEUP 6struct mtkbtsdio_hdr {__le16 len;
drivers/bluetooth/btmtksdio.c static bool btmtksdio_sdio_wakeup(struct hci_dev *hdev) · line 1300
Quoted 6 lines
drivers/bluetooth/btmtksdio.c +3
-0@@ -1294,6 +1295,9 @@ static bool btmtksdio_sdio_wakeup(struct hci_dev *hdev) .wakeup_delay = cpu_to_le16(0x20), }; +if (test_bit (BTMTKSDIO_INBAND_WAKEUP , &bdev->tx_state)) +return may_wakeup; +
Uhm... this flag is either *always* set, or *always not set*... and we decide that during probe time... and we use it in just one function as well.
At this point, I would just avoid the addition of the BTMTKSDIO_INBAND_WAKEUP flag and add a new function for handling the .wakeup() callback - something like:
static bool btmtksdio_sdio_inband_wakeup(struct hci_dev *hdev)
{
struct btmtksdio_dev *bdev = hci_get_drvdata(hdev);
return device_may_wakeup(bdev->dev);
}static int btmtksdio_probe(...)
{
.... code ....
/*
* If SDIO controller supports wake on Bluetooth, sending a wakeon
* command is not necessary.
*/
if (device_can_wakeup(func->card->host->parent))
hdev->wakeup = btmtksdio_sdio_inband_wakeup;
else
hdev->wakeup = btmtksdio_sdio_wakeup;
.... etc ....
}Regards,
Angelo