Skip to contentSkip to conversation

shrink printk timestamp field

PATCH Applied Joe Korty 5 participants 9 messages Aug 27, 2008 – Sep 6, 2008

lore
Share & tools
lore

Joe Korty

author
#0 lore raw

PATCH 1/1 shrink printk timestamp field

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

We eliminate the excessive whitespace the field added to the line, and reduce timestamp precision from six digits (usecs) to three digits (msecs). msecs seems adequate for the purpose of tracking boot sequence timing issues.

kernel/printk.c +2 -2
Index: 2.6.27-rc4-git4/kernel/printk.c
===================================================================
@@ -739,9 +739,9 @@
 
 				t = cpu_clock(printk_cpu);
 				nanosec_rem = do_div(t, 1000000000);
-				tlen = sprintf(tbuf, "[%5lu.%06lu] ",
+				tlen = sprintf(tbuf, "[%3lu.%03lu] ",
 						(unsigned long) t,
-						nanosec_rem / 1000);
+						nanosec_rem / 1000000);
 
 				for (tp = tbuf; tp < tbuf + tlen; tp++)
 					emit_log_char(*tp);
Applied
#1 lore raw
Quoted 11 lines · Joe Korty

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

We eliminate the excessive whitespace the field added to the line, and reduce timestamp precision from six digits (usecs) to three digits (msecs). msecs seems adequate for the purpose of tracking boot sequence timing issues.

applied to tip/core/printk, thanks Joe.

Ingo

#2 lore raw
In reply to Joe Korty
Quoted 18 lines · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

We eliminate the excessive whitespace the field added to the line, and reduce timestamp precision from six digits (usecs) to three digits (msecs). msecs seems adequate for the purpose of tracking boot sequence timing issues.

Index: 2.6.27-rc4-git4/kernel/printk.c
===================================================================

kernel/printk.c +0 -0
@@ -739,9 +739,9 @@
 

kernel/printk.c line 747

Quoted 10 lines
kernel/printk.c +2 -2
 				t = cpu_clock(printk_cpu);
 				nanosec_rem = do_div(t, 1000000000);
-				tlen = sprintf(tbuf, "[%5lu.%06lu] ",
+				tlen = sprintf(tbuf, "[%3lu.%03lu] ",
 						(unsigned long) t,
-						nanosec_rem / 1000);
+						nanosec_rem / 1000000);
 
 				for (tp = tbuf; tp < tbuf + tlen; tp++)
 					emit_log_char(*tp);

This is a significant loss in utility.

[   16.817285] md: Autodetecting RAID arrays.
[   16.817288] md: Scanned 0 and added 0 devices.
[   16.817290] md: autorun ...
[   16.817292] md: ... autorun DONE.

This not-terribly-fast machine can emit printks into the log buffer within two microseconds. That's a pretty useful ad-hoc timing factility.

This patch will reduce the precision by a factor of five hundred.

author
#3 lore raw
Quoted 15 lines · Andrew Morton
Quoted 5 lines · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

This is a significant loss in utility.

[   16.817285] md: Autodetecting RAID arrays.
[   16.817288] md: Scanned 0 and added 0 devices.
[   16.817290] md: autorun ...
[   16.817292] md: ... autorun DONE.
Quoted 5 lines

This not-terribly-fast machine can emit printks into the log buffer within two microseconds. That's a pretty useful ad-hoc timing factility.

This patch will reduce the precision by a factor of five hundred.

I was looking at it from the point of view of finding out where the boot process was too slow. For that millisecs is enough. I am not sure where knowing printk output to the microsec would be useful for solving anything.

Joe

#4 lore raw
Quoted 20 lines · On Sat, 30 Aug 2008 10:38:08 -0400 Joe Korty <[email protected]> wrote:
Quoted 19 lines · Andrew Morton
Quoted 5 lines · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

This is a significant loss in utility.

[   16.817285] md: Autodetecting RAID arrays.
[   16.817288] md: Scanned 0 and added 0 devices.
[   16.817290] md: autorun ...
[   16.817292] md: ... autorun DONE.

This not-terribly-fast machine can emit printks into the log buffer within two microseconds. That's a pretty useful ad-hoc timing factility.

Quoted 7 lines
Quoted 1 line

This patch will reduce the precision by a factor of five hundred.

I was looking at it from the point of view of finding out where the boot process was too slow. For that millisecs is enough. I am not sure where knowing printk output to the microsec would be useful for solving anything.

Of course it's useful. If you're working on performance or latency in a disk, network or USB driver, microsecond resolution is about right.

#5 lore raw

Hello,

Quoted 6 lines · Andrew Morton
Quoted 5 lines · On Sat, 30 Aug 2008 10:38:08 -0400 Joe Korty <[email protected]> wrote:
Quoted 3 lines · Andrew Morton
Quoted 1 line · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Quoted 8 lines
Quoted 4 lines

I was looking at it from the point of view of finding out where the boot process was too slow. For that millisecs is enough. I am not sure where knowing printk output to the microsec would be useful for solving anything.

Of course it's useful. If you're working on performance or latency in a disk, network or USB driver, microsecond resolution is about right.

I second this. If we have timestamps enables, let it be useful for all current uses. The 3 digits extra are very cheap useful information in that area (without resorting to more elaborate methods like the recently merged latency tracer).

Rather than cut 3 digits off, maybe fix some of the too-wide prints would solve the posters issue better.

Can we please have this patch non-committed or reverted?

Regards,

Signature · 1 line
Leon
author
#6 lore raw
Quoted 20 lines · Leon Woestenberg
Quoted 6 lines · Andrew Morton
Quoted 5 lines · On Sat, 30 Aug 2008 10:38:08 -0400 Joe Korty <[email protected]> wrote:
Quoted 3 lines · Andrew Morton
Quoted 1 line · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Quoted 8 lines
Quoted 4 lines

I was looking at it from the point of view of finding out where the boot process was too slow. For that millisecs is enough. I am not sure where knowing printk output to the microsec would be useful for solving anything.

Of course it's useful. If you're working on performance or latency in a disk, network or USB driver, microsecond resolution is about right.

I second this. If we have timestamps enables, let it be useful for all current uses. The 3 digits extra are very cheap useful information in that area (without resorting to more elaborate methods like the recently merged latency tracer).

Quoted 4 lines

Rather than cut 3 digits off, maybe fix some of the too-wide prints would solve the posters issue better.

Can we please have this patch non-committed or reverted?

I have no objection...
Joe

#7 lore raw
Quoted 9 lines · Joe Korty
Quoted 9 lines
Quoted 3 lines

Of course it's useful. If you're working on performance or latency in a disk, network or USB driver, microsecond resolution is about right.

I second this. If we have timestamps enables, let it be useful for all current uses. The 3 digits extra are very cheap useful information in that area (without resorting to more elaborate methods like the recently merged latency tracer).

Quoted 6 lines
Quoted 4 lines

Rather than cut 3 digits off, maybe fix some of the too-wide prints would solve the posters issue better.

Can we please have this patch non-committed or reverted?

I have no objection...

ok, i've zapped it from tip/core/printk.

Ingo

#8 lore raw
In reply to Andrew Morton
Quoted 22 lines · Andrew Morton
Quoted 20 lines · On Sat, 30 Aug 2008 10:38:08 -0400 Joe Korty <[email protected]> wrote:
Quoted 19 lines · Andrew Morton
Quoted 5 lines · On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <[email protected]> wrote:

Shrink the printk timestamp field.

Keep the printk timestamp from occupying more of the scarce, 80-column console line space than it really needs.

This is a significant loss in utility.

[   16.817285] md: Autodetecting RAID arrays.
[   16.817288] md: Scanned 0 and added 0 devices.
[   16.817290] md: autorun ...
[   16.817292] md: ... autorun DONE.

This not-terribly-fast machine can emit printks into the log buffer within two microseconds. That's a pretty useful ad-hoc timing factility.

This patch will reduce the precision by a factor of five hundred.

Quoted 8 lines
Quoted 5 lines

I was looking at it from the point of view of finding out where the boot process was too slow. For that millisecs is enough. I am not sure where knowing printk output to the microsec would be useful for solving anything.

Of course it's useful. If you're working on performance or latency in a disk, network or USB driver, microsecond resolution is about right.

How about supporting a configurable format string either by .config and/or in runtime, e.g. given by a command line parameter?

Benny

Quoted 6 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/