Skip to contentSkip to conversation

ARM Integrator CP flash fix

PATCH New Shawn 2 participants 3 messages Oct 13, 2004 – Jan 12, 2005

lore
Share & tools
lore

Shawn

author
#0 lore raw

PATCH 1/1 ARM Integrator CP flash fix

Hi,

Here is the patch fixing the flash support of ARM Integrator CP board. Now it supports 28F640J3C and 28F128J3C flash chips.

Best regards,
-Shawn.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: integratorcp-flash.patch.gz
Type: application/x-gzip-compressed
Size: 4672 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20041012/14e2e3c1/attachment.bin

#1 lore raw

PATCH 1/1 ARM Integrator CP flash fix

Quoted 3 lines · In message <[email protected]> you wrote:

Here is the patch fixing the flash support of ARM Integrator CP board. Now it supports 28F640J3C and 28F128J3C flash chips.

Added, thanks.

But please follow the Coding Style requirements.

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Mistakes are often the stepping stones to utter failure.
author
#2 lore raw

PATCH 1/1 ARM Integrator CP flash fix

Hi Wolfgang,

Quoted 4 lines
Quoted 2 lines

Here is the patch fixing the flash support of ARM Integrator CP board. Now it supports 28F640J3C and 28F128J3C flash chips.

Added, thanks.

This patch had a bug in udelay(), if I remember correctly. But it's fixed in my latest patch posted on Dec. 20. Also there are more stuff in the latest patch I submitted.

http://sourceforge.net/mailarchive/message.php?msg_id=10359748

Quoted 1 line

But please follow the Coding Style requirements.

Would you please point out where I violated the coding style requirements in the latest patch? I'd like to fix them and submit a clean patch then.

Regards,
-Shawn.