Skip to contentSkip to conversation

net/iavf: fix symmetric rule creating

PATCH Applied Xuan Ding 3 participants 3 messages Jan 22, 2021 – Jan 25, 2021 Network drivers

lore
Share & tools
lore

Xuan Ding

author
#0 lore raw

PATCH 1/1 net/iavf: fix symmetric rule creating

Only allow to create symmetric rule for L3/L4.

Fixes 91f27b2e39ab("net/iavf: refactor RSS")
---
 drivers/net/iavf/iavf_hash.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/iavf/iavf_hash.c +7 -0
index 958c73c4fb..5fa2f3cf59 100644
@@ -927,6 +927,13 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
 		if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
 		    ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
 			return true;
+
+		if (!(rss_type &
+		   (ETH_RSS_IPV4 | ETH_RSS_IPV6 |
+		    ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP |
+		    ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP |
+		    ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP)))
+			return true;
 	}
 
 	/* check invalid combination */
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Friday, January 22, 2021 11:19 AM
To: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Ding, Xuan <[email protected]>; [email protected]
Subject: [PATCH] net/iavf: fix symmetric rule creating

Quoted 6 lines

Only allow to create symmetric rule for L3/L4.

Fixes 91f27b2e39ab("net/iavf: refactor RSS")
Applied
#2 lore raw
Quoted 20 lines

-----Original Message-----
From: Xing, Beilei <[email protected]>
Sent: Friday, January 22, 2021 12:05 PM
To: Ding, Xuan <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>
Cc: [email protected]; [email protected]
Subject: RE: [PATCH] net/iavf: fix symmetric rule creating

Quoted 8 lines

-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Friday, January 22, 2021 11:19 AM
To: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Ding, Xuan <[email protected]>; [email protected]
Subject: [PATCH] net/iavf: fix symmetric rule creating

Quoted 7 lines
Quoted 6 lines

Only allow to create symmetric rule for L3/L4.

Fixes 91f27b2e39ab("net/iavf: refactor RSS")

Applied to dpdk-next-net-intel.

Thanks
Qi