cmd: add exception command
PATCH 1/1 cmd: add exception command
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exception
---
v2:
Split architecture specific code into separate files. Provide include for common code.
Update MAINTAINERS file.
--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++ 11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.h
MAINTAINERS +3 -0
@@ -84,6 +84,7 @@ M: Albert Aribaud <[email protected]> S: Maintained T: git git://git.denx.de/u-boot-arm.git F: arch/arm/ +F: cmd/arm/ ARM ALTERA SOCFPGA M: Marek Vasut <[email protected]>
@@ -624,6 +625,7 @@ M: Rick Chen <[email protected]> S: Maintained T: git git://git.denx.de/u-boot-riscv.git F: arch/riscv/ +F: cmd/riscv/ F: tools/prelink-riscv.c ROCKUSB
@@ -725,6 +727,7 @@ M: Bin Meng <[email protected]> S: Maintained T: git git://git.denx.de/u-boot-x86.git F: arch/x86/ +F: cmd/x86/ XTENSA M: Max Filippov <[email protected]>
cmd/Kconfig +6 -0
@@ -1397,6 +1397,12 @@ config CMD_DISPLAY displayed on a simple board-specific display. Implement display_putc() to use it. +config CMD_EXCEPTION + bool "exception - raise exception" + depends on ARM || RISCV || X86 + help + Enable the 'exception' command which allows to raise an exception. + config CMD_LED bool "led" default y if LED
cmd/Makefile +2 -0
@@ -170,6 +170,8 @@ obj-$(CONFIG_CMD_BLOB) += blob.o # Android Verified Boot 2.0 obj-$(CONFIG_CMD_AVB) += avb.o +obj-$(CONFIG_ARM) += arm/ +obj-$(CONFIG_RISCV) += riscv/ obj-$(CONFIG_X86) += x86/ obj-$(CONFIG_ARCH_MVEBU) += mvebu/
cmd/arm/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0+ + +ifdef CONFIG_ARM64 +obj-$(CONFIG_CMD_EXCEPTION) += exception64.o +else +obj-$(CONFIG_CMD_EXCEPTION) += exception.o +endif
cmd/arm/exception.c new file +61 -0
61 lines not on this page · raw message
cmd/arm/exception64.c new file +33 -0
@@ -0,0 +1,33 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* The 'exception' command can be used for testing exception handling. +* +* Copyright (c) 2018, Heinrich Schuchardt <[email protected]> +*/ + +#include <common.h> +#include <command.h> + +static int do_undefined (cmd_tbl_t *cmdtp,int flag,int argc, +char *const argv[]) +{ +/* +* 0xe7f...f. is undefined in ARM mode +* 0xde.. is undefined in Thumb mode +*/ + asmvolatile (".word 0xe7f7defb\n" ); +return CMD_RET_FAILURE ; +} + +static cmd_tbl_t cmd_sub[] = { +U_BOOT_CMD_MKENT (undefined,CONFIG_SYS_MAXARGS ,1 , do_undefined, +"" ,"" ), +}; + +static char exception_help_text[] = +"<ex>\n" +" The following exceptions are available:\n" +" undefined - undefined instruction\n" + ; + +#include <exception.h>
cmd/riscv/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0+ + +obj-$(CONFIG_CMD_EXCEPTION) += exception.o
cmd/riscv/exception.c new file +29 -0
@@ -0,0 +1,29 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* The 'exception' command can be used for testing exception handling. +* +* Copyright (c) 2018, Heinrich Schuchardt <[email protected]> +*/ + +#include <common.h> +#include <command.h> + +static int do_undefined (cmd_tbl_t *cmdtp,int flag,int argc, +char *const argv[]) +{ + asmvolatile (".word 0xffffffff\n" ); +return CMD_RET_FAILURE ; +} + +static cmd_tbl_t cmd_sub[] = { +U_BOOT_CMD_MKENT (undefined,CONFIG_SYS_MAXARGS ,1 , do_undefined, +"" ,"" ), +}; + +static char exception_help_text[] = +"<ex>\n" +" The following exceptions are available:\n" +" undefined - undefined instruction\n" + ; + +#include <exception.h>
cmd/x86/Makefile +1 -0
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0+ obj-y += mtrr.o +obj-$(CONFIG_CMD_EXCEPTION) += exception.o obj-$(CONFIG_HAVE_FSP) += fsp.o
cmd/x86/exception.c new file +29 -0
@@ -0,0 +1,29 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* The 'exception' command can be used for testing exception handling. +* +* Copyright (c) 2018, Heinrich Schuchardt <[email protected]> +*/ + +#include <common.h> +#include <command.h> + +static int do_undefined (cmd_tbl_t *cmdtp,int flag,int argc, +char *const argv[]) +{ + asmvolatile (".word 0xffff\n" ); +return CMD_RET_FAILURE ; +} + +static cmd_tbl_t cmd_sub[] = { +U_BOOT_CMD_MKENT (undefined,CONFIG_SYS_MAXARGS ,1 , do_undefined, +"" ,"" ), +}; + +static char exception_help_text[] = +"<ex>\n" +" The following exceptions are available:\n" +" undefined - undefined instruction\n" + ; + +#include <exception.h>
include/exception.h new file +58 -0
58 lines not on this page · raw message
Signature · 1 line
2.19.2
PATCH 1/1 cmd: add exception command
Hi Heinrich,
Quoted 26 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>---
v2:
Split architecture specific code into separate files. Provide include for common code.
UpdateMAINTAINERSfile.--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++
Quoted 8 lines
11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.h
This needs something like Series-version: 2 (if you use patman) to set the version number in the header.
Did you look at using a uclass and driver, like sysreset?
Regards,
Simon
PATCH 1/1 cmd: add exception command
Quoted 38 lines · Simon Glass
Hi Heinrich,
Quoted 26 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>---
v2:
Split architecture specific code into separate files. Provide include for common code.
UpdateMAINTAINERSfile.--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++Quoted 8 lines
11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.h
Quoted 2 lines
This needs something like Series-version: 2 (if you use patman) to set the version number in the header.
Sorry for the mishap.
Quoted 2 lines
Did you look at using a uclass and driver, like sysreset?
Yes I have considered using a u-class. But I could not see how adding a separate u-class file would save lines, make the coding less complex, or make the coding easier to maintain. A u-class would make sense if there were other consumers for exceptions but the exception command. But I cannot imagine any.
There are better places to apply u-classes, e.g. I am really missing a u-class for file systems.
Best regards
Heinrich
Quoted 4 lines
Regards,
Simon
PATCH 1/1 cmd: add exception command
Hi Heinrich,
Quoted 46 lines · Heinrich Schuchardt
Quoted 38 lines · Simon Glass
Hi Heinrich,
Quoted 26 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>---
v2:
Split architecture specific code into separate files. Provide include for common code.
UpdateMAINTAINERSfile.--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++Quoted 8 lines
11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.hQuoted 2 lines
This needs something like Series-version: 2 (if you use patman) to set the version number in the header.
Sorry for the mishap.
Quoted 1 line
Quoted 7 lines
Quoted 1 line
Did you look at using a uclass and driver, like sysreset?
Yes I have considered using a u-class. But I could not see how adding a separate u-class file would save lines, make the coding less complex, or make the coding easier to maintain. A u-class would make sense if there were other consumers for exceptions but the exception command. But I cannot imagine any.
In some sense driver model matches consumers and producers. There are clearly multiple producers - you have effectively implemented an API in a few places. We even have multiple impls for each arch.
So I still favour a uclass, but since you are pretty adamant that we should not do it, I'm not going to insist.
Quoted 12 lines
There are better places to apply u-classes, e.g. I am really missing a u-class for file systems.
Best regards
Heinrich
Quoted 4 lines
Regards,
Simon
Regards,
Simon
PATCH 1/1 cmd: add exception command
Quoted 57 lines · Simon Glass
Hi Heinrich,
Quoted 46 lines · Heinrich Schuchardt
Quoted 38 lines · Simon Glass
Hi Heinrich,
Quoted 26 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>---
v2:
Split architecture specific code into separate files. Provide include for common code.
UpdateMAINTAINERSfile.--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++Quoted 8 lines
11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.hQuoted 2 lines
This needs something like Series-version: 2 (if you use patman) to set the version number in the header.
Sorry for the mishap.
Quoted 1 line
Quoted 7 lines
Quoted 1 line
Did you look at using a uclass and driver, like sysreset?
Yes I have considered using a u-class. But I could not see how adding a separate u-class file would save lines, make the coding less complex, or make the coding easier to maintain. A u-class would make sense if there were other consumers for exceptions but the exception command. But I cannot imagine any.
Quoted 6 lines
In some sense driver model matches consumers and producers. There are clearly multiple producers - you have effectively implemented an API in a few places. We even have multiple impls for each arch.
So I still favour a uclass, but since you are pretty adamant that we should not do it, I'm not going to insist.
Hello Tom,
in patchwork this patch is still in status 'NEW'.
It is unclear to me if you are going to merge it as is or if I should rework it.
Best regards
Heinrich
Quoted 21 lines
Quoted 13 lines
There are better places to apply u-classes, e.g. I am really missing a u-class for file systems.
Best regards
Heinrich
Quoted 4 lines
Regards,
SimonRegards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
PATCH 1/1 cmd: add exception command
Quoted 65 lines · Heinrich Schuchardt
Quoted 57 lines · Simon Glass
Hi Heinrich,
Quoted 46 lines · Heinrich Schuchardt
Quoted 38 lines · Simon Glass
Hi Heinrich,
Quoted 26 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>---
v2:
Split architecture specific code into separate files. Provide include for common code.
UpdateMAINTAINERSfile.--- MAINTAINERS | 3 +++ cmd/Kconfig | 6 +++++ cmd/Makefile | 2 ++ cmd/arm/Makefile | 7 +++++ cmd/arm/exception.c | 61 +++++++++++++++++++++++++++++++++++++++++++ cmd/arm/exception64.c | 33 +++++++++++++++++++++++ cmd/riscv/Makefile | 3 +++ cmd/riscv/exception.c | 29 ++++++++++++++++++++ cmd/x86/Makefile | 1 + cmd/x86/exception.c | 29 ++++++++++++++++++++ include/exception.h | 58 ++++++++++++++++++++++++++++++++++++++++Quoted 8 lines
11 files changed, 232 insertions(+) create mode 100644 cmd/arm/Makefile create mode 100644 cmd/arm/exception.c create mode 100644 cmd/arm/exception64.c create mode 100644 cmd/riscv/Makefile create mode 100644 cmd/riscv/exception.c create mode 100644 cmd/x86/exception.c create mode 100644 include/exception.hQuoted 2 lines
This needs something like Series-version: 2 (if you use patman) to set the version number in the header.
Sorry for the mishap.
Quoted 1 line
Quoted 7 lines
Quoted 1 line
Did you look at using a uclass and driver, like sysreset?
Yes I have considered using a u-class. But I could not see how adding a separate u-class file would save lines, make the coding less complex, or make the coding easier to maintain. A u-class would make sense if there were other consumers for exceptions but the exception command. But I cannot imagine any.
Quoted 6 lines
In some sense driver model matches consumers and producers. There are clearly multiple producers - you have effectively implemented an API in a few places. We even have multiple impls for each arch.
So I still favour a uclass, but since you are pretty adamant that we should not do it, I'm not going to insist.
Quoted 6 lines
Hello Tom,
in patchwork this patch is still in status 'NEW'.
It is unclear to me if you are going to merge it as is or if I should rework it.
I guess I hadn't made a decision here. I guess if you're really sure it doesn't need what Simon is suggesting, then yes, I'll pick this up as-is. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190218/8fa68951/attachment.sig>
PATCH 1/1 cmd: add exception command
In reply to Heinrich SchuchardtQuoted 8 lines · Heinrich Schuchardt
The 'exception' command allows to test exception handling.
This implementation supports ARM, x86, RISC-V and the following exceptions:
* 'breakpoint' - prefetch abort exception (ARM 32bit only)
* 'unaligned' - data abort exception (ARM only)
* 'undefined' - undefined instruction exceptionSigned-off-by Heinrich Schuchardt <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/62dc1f27/attachment.sig>