Skip to contentSkip to conversation

app/procinfo: add device private info dump

PATCH Superseded Min Hu (Connor) 6 participants 21 messages Feb 19, 2022 – Jul 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/procinfo: add device private info dump

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
 app/proc-info/main.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
app/proc-info/main.c +32 -0
index 56070a3317..62a8b83bf5 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,29 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1579,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
Signature · 1 line
2.33.0
#1 lore raw
Quoted 6 lines · On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" <[email protected]> wrote:
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

app/proc-info/main.c show_port(void) · line 912

Quoted 10 lines
app/proc-info/main.c +10 -0
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;

Maybe use RTE_ETH_FOREACH_DEV(i) here?

Procinfo is somewhat inconsistent, some code uses, and some does not. The difference is that FOREACH skips ports that are "owned" i.e associated with another port.

There probably should be a clear policy in the comments about how this command should handle ports. My preference would be that it shows all valid ports, all the time since this is a diagnostic command used to debug misconfiguration.

There is RTE_ETH_FOREACH_VALID_DEV but it is marked internal?

#2 lore raw

20/02/2022 02:04, Stephen Hemminger:

Quoted 22 lines
Quoted 6 lines · On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" <[email protected]> wrote:
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

app/proc-info/main.c show_port(void) · line 912

Quoted 10 lines
app/proc-info/main.c +10 -0
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;

Maybe use RTE_ETH_FOREACH_DEV(i) here?

Quoted 3 lines

Procinfo is somewhat inconsistent, some code uses, and some does not. The difference is that FOREACH skips ports that are "owned" i.e associated with another port.

Yes RTE_ETH_FOREACH_DEV is for general usage, you get only the ports you are supposed to manage.

Quoted 6 lines

There probably should be a clear policy in the comments about how this command should handle ports. My preference would be that it shows all valid ports, all the time since this is a diagnostic command used to debug misconfiguration.

There is RTE_ETH_FOREACH_VALID_DEV but it is marked internal?

Yes, you get it right, RTE_ETH_FOREACH_VALID_DEV gets all ports and that should be used only internally or for debugging. If we expose it for debugging purpose, there is a risk of confusion. The goal was to "force" applications to adopt good behaviour, using RTE_ETH_FOREACH_DEV.
It means RTE_MAX_ETHPORTS must be used for debugging.
Is it a good decision?

#3 lore raw

Hi,

Quoted 35 lines · Thomas Monjalon

20/02/2022 02:04, Stephen Hemminger:

Quoted 22 lines
Quoted 6 lines · On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" <[email protected]> wrote:
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

app/proc-info/main.c show_port(void) · line 912

Quoted 10 lines
app/proc-info/main.c +10 -0
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;

Maybe use RTE_ETH_FOREACH_DEV(i) here?

Quoted 3 lines

Procinfo is somewhat inconsistent, some code uses, and some does not. The difference is that FOREACH skips ports that are "owned" i.e associated with another port.

Yes RTE_ETH_FOREACH_DEV is for general usage, you get only the ports you are supposed to manage.

Quoted 5 lines

There probably should be a clear policy in the comments about how this command should handle ports. My preference would be that it shows all valid ports, all the time since this is a diagnostic command used to debug misconfiguration.

Quoted 7 lines
Quoted 1 line

There is RTE_ETH_FOREACH_VALID_DEV but it is marked internal?

Yes, you get it right, RTE_ETH_FOREACH_VALID_DEV gets all ports and that should be used only internally or for debugging. If we expose it for debugging purpose, there is a risk of confusion. The goal was to "force" applications to adopt good behaviour, using RTE_ETH_FOREACH_DEV.

Agree with using RTE_ETH_FOREACH_DEV, v2 has been sent out.

Quoted 6 lines

It means RTE_MAX_ETHPORTS must be used for debugging. Is it a good decision?

.

#4 lore raw
Quoted 38 lines · On Mon, 21 Feb 2022 10:26:38 +0800 "Min Hu (Connor)" <[email protected]> wrote:

Hi,

Quoted 35 lines · Thomas Monjalon

20/02/2022 02:04, Stephen Hemminger:

Quoted 22 lines
Quoted 6 lines · On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" <[email protected]> wrote:
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

app/proc-info/main.c show_port(void) · line 912

Quoted 10 lines
app/proc-info/main.c +10 -0
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;  

Maybe use RTE_ETH_FOREACH_DEV(i) here?

Quoted 3 lines

Procinfo is somewhat inconsistent, some code uses, and some does not. The difference is that FOREACH skips ports that are "owned" i.e associated with another port.

Yes RTE_ETH_FOREACH_DEV is for general usage, you get only the ports you are supposed to manage.

Quoted 5 lines

There probably should be a clear policy in the comments about how this command should handle ports. My preference would be that it shows all valid ports, all the time since this is a diagnostic command used to debug misconfiguration.

Quoted 15 lines
Quoted 7 lines
Quoted 1 line

There is RTE_ETH_FOREACH_VALID_DEV but it is marked internal?

Yes, you get it right, RTE_ETH_FOREACH_VALID_DEV gets all ports and that should be used only internally or for debugging. If we expose it for debugging purpose, there is a risk of confusion. The goal was to "force" applications to adopt good behaviour, using RTE_ETH_FOREACH_DEV.

Agree with using RTE_ETH_FOREACH_DEV, v2 has been sent out.

Quoted 6 lines

It means RTE_MAX_ETHPORTS must be used for debugging. Is it a good decision?

.

Maybe procinfo should have a flag (--all) to show all devices.

#5 lore raw

HI,

Quoted 50 lines · Stephen Hemminger
Quoted 47 lines · On Mon, 21 Feb 2022 10:26:38 +0800 "Min Hu (Connor)" <[email protected]> wrote:

Hi,

Quoted 35 lines · Thomas Monjalon

20/02/2022 02:04, Stephen Hemminger:

Quoted 22 lines
Quoted 6 lines · On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" <[email protected]> wrote:
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

app/proc-info/main.c show_port(void) · line 912

Quoted 10 lines
app/proc-info/main.c +10 -0
+	STATS_BDR_STR(10, bdr_str);
+
+	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		/* Skip if port is unused */
+		if (!rte_eth_dev_is_valid_port(i))
+			continue;

Maybe use RTE_ETH_FOREACH_DEV(i) here?

Quoted 3 lines

Procinfo is somewhat inconsistent, some code uses, and some does not. The difference is that FOREACH skips ports that are "owned" i.e associated with another port.

Yes RTE_ETH_FOREACH_DEV is for general usage, you get only the ports you are supposed to manage.

Quoted 5 lines

There probably should be a clear policy in the comments about how this command should handle ports. My preference would be that it shows all valid ports, all the time since this is a diagnostic command used to debug misconfiguration.

Quoted 7 lines
Quoted 1 line

There is RTE_ETH_FOREACH_VALID_DEV but it is marked internal?

Yes, you get it right, RTE_ETH_FOREACH_VALID_DEV gets all ports and that should be used only internally or for debugging. If we expose it for debugging purpose, there is a risk of confusion. The goal was to "force" applications to adopt good behaviour, using RTE_ETH_FOREACH_DEV.

Agree with using RTE_ETH_FOREACH_DEV, v2 has been sent out.

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

It means RTE_MAX_ETHPORTS must be used for debugging. Is it a good decision?

.

Maybe procinfo should have a flag (--all) to show all devices.

How about keep the patch as v1 shows, like that:
+ for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
+ /* Skip if port is not in mask */
+ if ((enabled_port_mask & (1ul << i)) == 0)
+ continue;
+
+ /* Skip if port is unused */
+ if (!rte_eth_dev_is_valid_port(i))
+ continue;

This can show all devices.

Quoted 2 lines

.

#6 lore raw

PATCH v2 1/1 app/procinfo: add devcie private info dump

In reply to Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v2:
* fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..accb5e716d 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
Signature · 1 line
2.33.0
#7 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

Hi, all,
any comments for this patch?

Quoted 86 lines · Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v2:
* fix way of handling ports.

---
  app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..accb5e716d 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
  /**< Enable show port. */
  static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
  /**< Enable show tm. */
  static uint32_t enable_shw_tm;
  /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
  		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
  		"  --host-id STRING: host id used to identify the system process is running on\n"
  		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
  		"  --show-tm: to display traffic manager information for ports\n"
  		"  --show-crypto: to display crypto information\n"
  		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
  		{"xstats-ids", 1, NULL, 1},
  		{"host-id", 0, NULL, 0},
  		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
  		{"show-tm", 0, NULL, 0},
  		{"show-crypto", 0, NULL, 0},
  		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
  			else if (!strncmp(long_option[option_index].name,
  					"show-port", MAX_LONG_OPT_SZ))
  				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
  			else if (!strncmp(long_option[option_index].name,
  					"show-tm", MAX_LONG_OPT_SZ))
  				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
  	}
  }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
  static void
  display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
  {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
  	/* show information for PMD */
  	if (enable_shw_port)
  		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
  	if (enable_shw_tm)
  		show_tm();
  	if (enable_shw_crypto)
#8 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

Hi, all,
any comments for this patch?

Quoted 2 lines · Min Hu (Connor)

Hi, all,
    any comments for this patch?

#9 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

In reply to Min Hu (Connor)

Hi, Ferruh,
what do you think of this patch?

Quoted 89 lines · Min Hu (Connor)

Hi, all,
    any comments for this patch?

Quoted 76 lines · Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v2:
* fix way of handling ports.
---
  app/proc-info/main.c | 28 ++++++++++++++++++++++++++++

  1 file changed, 28 insertions(+)
app/proc-info/main.c +2 -0
index 56070a3317..accb5e716d 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
   /**< Enable show port. */
   static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
   /**< Enable show tm. */
   static uint32_t enable_shw_tm;
   /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)

          "  --collectd-format: to print statistics to STDOUT in expected by collectd format\n" "  --host-id STRING: host id used to identify the system process is running on\n" "  --show-port: to display ports information\n"
+        "  --show-port-private: to display ports private information\n"
          "  --show-tm: to display traffic manager information for ports\n"
          "  --show-crypto: to display crypto information\n"
          "  --show-ring[=name]: to display ring information\n"

app/proc-info/main.c +23 -0
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
           {"xstats-ids", 1, NULL, 1},
           {"host-id", 0, NULL, 0},
           {"show-port", 0, NULL, 0},
+        {"show-port-private", 0, NULL, 0},
           {"show-tm", 0, NULL, 0},
           {"show-crypto", 0, NULL, 0},
           {"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
               else if (!strncmp(long_option[option_index].name,
                       "show-port", MAX_LONG_OPT_SZ))
                   enable_shw_port = 1;
+            else if (!strncmp(long_option[option_index].name,
+                    "show-port-private", MAX_LONG_OPT_SZ))
+                enable_shw_port_priv = 1;
               else if (!strncmp(long_option[option_index].name,
                       "show-tm", MAX_LONG_OPT_SZ))
                   enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
       }
   }
+static void
+show_port_private_info(void)
+{
+    int i;
+
+    snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+    STATS_BDR_STR(10, bdr_str);
+
+    RTE_ETH_FOREACH_DEV(i) {
+        /* Skip if port is not in mask */
+        if ((enabled_port_mask & (1ul << i)) == 0)
+            continue;
+
+        snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+        STATS_BDR_STR(5, bdr_str);
+        rte_eth_dev_priv_dump(i, stdout);
+    }
+}
+

  static void
  display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap) {

app/proc-info/main.c main(int argc, char **argv) · line 1582

Quoted 8 lines
app/proc-info/main.c +2 -0
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
       /* show information for PMD */
       if (enable_shw_port)
           show_port();
+    if (enable_shw_port_priv)
+        show_port_private_info();
       if (enable_shw_tm)
           show_tm();
       if (enable_shw_crypto)

.

#10 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

In reply to Min Hu (Connor)

Hi, Ferruh,
what do you think of this patch?

Quoted 86 lines · Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v2:
* fix way of handling ports.

---
  app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
  1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..accb5e716d 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
  /**< Enable show port. */
  static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
  /**< Enable show tm. */
  static uint32_t enable_shw_tm;
  /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
  		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
  		"  --host-id STRING: host id used to identify the system process is running on\n"
  		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
  		"  --show-tm: to display traffic manager information for ports\n"
  		"  --show-crypto: to display crypto information\n"
  		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
  		{"xstats-ids", 1, NULL, 1},
  		{"host-id", 0, NULL, 0},
  		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
  		{"show-tm", 0, NULL, 0},
  		{"show-crypto", 0, NULL, 0},
  		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
  			else if (!strncmp(long_option[option_index].name,
  					"show-port", MAX_LONG_OPT_SZ))
  				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
  			else if (!strncmp(long_option[option_index].name,
  					"show-tm", MAX_LONG_OPT_SZ))
  				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
  	}
  }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
  static void
  display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
  {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
  	/* show information for PMD */
  	if (enable_shw_port)
  		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
  	if (enable_shw_tm)
  		show_tm();
  	if (enable_shw_crypto)
#11 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

Quoted 6 lines · Min Hu (Connor)

CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Hi, Ferruh,
    what do you think of this patch?

Hi Connor,

Maryam & Reshma are maintainers of the tool, both are cc'ed.

Quoted 90 lines · Min Hu (Connor)
Quoted 88 lines

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v2:
* fix way of handling ports.
---
  app/proc-info/main.c | 28 ++++++++++++++++++++++++++++

  1 file changed, 28 insertions(+)
app/proc-info/main.c +2 -0
index 56070a3317..accb5e716d 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
   /**< Enable show port. */
   static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
   /**< Enable show tm. */
   static uint32_t enable_shw_tm;
   /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)

              "  --collectd-format: to print statistics to STDOUT in expected by collectd format\n" "  --host-id STRING: host id used to identify the system process is running on\n" "  --show-port: to display ports information\n"
+             "  --show-port-private: to display ports private
information\n"
              "  --show-tm: to display traffic manager information for ports\n"
              "  --show-crypto: to display crypto information\n"
              "  --show-ring[=name]: to display ring information\n"

app/proc-info/main.c +4 -0
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
               {"xstats-ids", 1, NULL, 1},
               {"host-id", 0, NULL, 0},
               {"show-port", 0, NULL, 0},
+             {"show-port-private", 0, NULL, 0},
               {"show-tm", 0, NULL, 0},
               {"show-crypto", 0, NULL, 0},
               {"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
                       else if (!strncmp(long_option[option_index].name,
                                       "show-port", MAX_LONG_OPT_SZ))
                               enable_shw_port = 1;
+                     else if (!strncmp(long_option[option_index].name,
+                                     "show-port-private", 
 MAX_LONG_OPT_SZ))
+                             enable_shw_port_priv = 1;
                       else if (!strncmp(long_option[option_index].name,
                                       "show-tm", MAX_LONG_OPT_SZ))

                              enable_shw_tm = 1;

app/proc-info/main.c +19 -0
@@ -887,6 +894,25 @@ show_port(void)
       }
   }
 
+static void
+show_port_private_info(void)
+{
+     int i;
+
+     snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
+     STATS_BDR_STR(10, bdr_str);
+
+     RTE_ETH_FOREACH_DEV(i) {
+             /* Skip if port is not in mask */
+             if ((enabled_port_mask & (1ul << i)) == 0)
+                     continue;
+
+             snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+             STATS_BDR_STR(5, bdr_str);
+             rte_eth_dev_priv_dump(i, stdout);
+     }
+}
+

  static void
  display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap) {

app/proc-info/main.c +2 -0
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
       /* show information for PMD */
       if (enable_shw_port)
               show_port();
+     if (enable_shw_port_priv)
+             show_port_private_info();
       if (enable_shw_tm)
               show_tm();
       if (enable_shw_crypto)
Acked-by on v2 1/1
#12 lore raw

RE: [PATCH v2] app/procinfo: add devcie private info dump

In reply to Min Hu (Connor)
Quoted 6 lines

-----Original Message-----
From: Min Hu (Connor) <[email protected]>
Subject: [PATCH v2] app/procinfo: add devcie private info dump

Typo: device*

app/proc-info/main.c show_port(void) · line 902

Quoted 6 lines
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

Better to have header message to be "Dump - Ports private information"

Looks ok to me.

#13 lore raw

Re: [PATCH v2] app/procinfo: add devcie private info dump

Hi, Pattan,
V3 has been sent, thanks

Quoted 24 lines · Reshma
Quoted 6 lines

-----Original Message-----
From: Min Hu (Connor) <[email protected]>
Subject: [PATCH v2] app/procinfo: add devcie private info dump

Typo: device*

app/proc-info/main.c show_port(void) · line 902

Quoted 6 lines
app/proc-info/main.c +6 -0
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");

Better to have header message to be "Dump - Ports private information"

Looks ok to me.

.

#14 lore raw

PATCH v3 1/1 app/procinfo: add device private info dump

In reply to Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v3:
* fix wrong spelling.

v2:
* fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..1d350291b9 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " Dump - Ports private information");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
Signature · 1 line
2.33.0
#15 lore raw

PATCH v3 1/1 app/procinfo: add device private info dump

In reply to Min Hu (Connor)

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v3:
* fix wrong spelling.

v2:
* fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..1d350291b9 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " Dump - Ports private information");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
Signature · 1 line
2.33.0
#16 lore raw

PATCH v4 1/1 app/procinfo: add device private info dump

From: "Min Hu (Connor)" <[email protected]>

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v3->v4:
- add Acked-by Reshma.

v2->v3:
- fix wrong spelling.

v1->v2:
- fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..1d350291b9 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " Dump - Ports private information");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
Signature · 1 line
2.22.0
#17 lore raw

Hi Maryam, ferruh

kind ping...

If there are no other comments, could you help to
apply this patch.

Thanks,
Dongdong

Quoted 96 lines · Dongdong Liu

From: "Min Hu (Connor)" <[email protected]>

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v3->v4:
- add Acked-by Reshma.

v2->v3:
- fix wrong spelling.

v1->v2:
- fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +28 -0
index 56070a3317..1d350291b9 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
 		"  --host-id STRING: host id used to identify the system process is running on\n"
 		"  --show-port: to display ports information\n"
+		"  --show-port-private: to display ports private information\n"
 		"  --show-tm: to display traffic manager information for ports\n"
 		"  --show-crypto: to display crypto information\n"
 		"  --show-ring[=name]: to display ring information\n"
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
 		{"show-port", 0, NULL, 0},
+		{"show-port-private", 0, NULL, 0},
 		{"show-tm", 0, NULL, 0},
 		{"show-crypto", 0, NULL, 0},
 		{"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
 			else if (!strncmp(long_option[option_index].name,
 					"show-port", MAX_LONG_OPT_SZ))
 				enable_shw_port = 1;
+			else if (!strncmp(long_option[option_index].name,
+					"show-port-private", MAX_LONG_OPT_SZ))
+				enable_shw_port_priv = 1;
 			else if (!strncmp(long_option[option_index].name,
 					"show-tm", MAX_LONG_OPT_SZ))
 				enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
 	}
 }
 
+static void
+show_port_private_info(void)
+{
+	int i;
+
+	snprintf(bdr_str, MAX_STRING_LEN, " Dump - Ports private information");
+	STATS_BDR_STR(10, bdr_str);
+
+	RTE_ETH_FOREACH_DEV(i) {
+		/* Skip if port is not in mask */
+		if ((enabled_port_mask & (1ul << i)) == 0)
+			continue;
+
+		snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+		STATS_BDR_STR(5, bdr_str);
+		rte_eth_dev_priv_dump(i, stdout);
+	}
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)
 {
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
 	/* show information for PMD */
 	if (enable_shw_port)
 		show_port();
+	if (enable_shw_port_priv)
+		show_port_private_info();
 	if (enable_shw_tm)
 		show_tm();
 	if (enable_shw_crypto)
#18 lore raw

+cc Ferruh ([email protected]).

It seems this email could not be delivered to [email protected].

Thanks,
Dongdong

Quoted 112 lines · Dongdong Liu

Hi Maryam, ferruh

kind ping...

If there are no other comments, could you help to
apply this patch.

Thanks,
Dongdong

Quoted 92 lines · Dongdong Liu

From: "Min Hu (Connor)" <[email protected]>

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

---
v3->v4:
- add Acked-by Reshma.

v2->v3:
- fix wrong spelling.

v1->v2:
- fix way of handling ports.

---
 app/proc-info/main.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
app/proc-info/main.c +2 -0
index 56070a3317..1d350291b9 100644
@@ -84,6 +84,8 @@ static char bdr_str[MAX_STRING_LEN];
 
 /**< Enable show port. */
 static uint32_t enable_shw_port;
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;
 /**< Enable show tm. */
 static uint32_t enable_shw_tm;
 /**< Enable show crypto. */
@@ -123,6 +125,7 @@ proc_info_usage(const char *prgname)
         "  --collectd-format: to print statistics to STDOUT in

expected by collectd format\n"
" --host-id STRING: host id used to identify the system
process is running on\n"

         "  --show-port: to display ports information\n"
+        "  --show-port-private: to display ports private information\n"
         "  --show-tm: to display traffic manager information for
ports\n"
         "  --show-crypto: to display crypto information\n"
         "  --show-ring[=name]: to display ring information\n"
app/proc-info/main.c +23 -0
@@ -232,6 +235,7 @@ proc_info_parse_args(int argc, char **argv)
         {"xstats-ids", 1, NULL, 1},
         {"host-id", 0, NULL, 0},
         {"show-port", 0, NULL, 0},
+        {"show-port-private", 0, NULL, 0},
         {"show-tm", 0, NULL, 0},
         {"show-crypto", 0, NULL, 0},
         {"show-ring", optional_argument, NULL, 0},
@@ -284,6 +288,9 @@ proc_info_parse_args(int argc, char **argv)
             else if (!strncmp(long_option[option_index].name,
                     "show-port", MAX_LONG_OPT_SZ))
                 enable_shw_port = 1;
+            else if (!strncmp(long_option[option_index].name,
+                    "show-port-private", MAX_LONG_OPT_SZ))
+                enable_shw_port_priv = 1;
             else if (!strncmp(long_option[option_index].name,
                     "show-tm", MAX_LONG_OPT_SZ))
                 enable_shw_tm = 1;
@@ -887,6 +894,25 @@ show_port(void)
     }
 }
 
+static void
+show_port_private_info(void)
+{
+    int i;
+
+    snprintf(bdr_str, MAX_STRING_LEN, " Dump - Ports private
 information");
+    STATS_BDR_STR(10, bdr_str);
+
+    RTE_ETH_FOREACH_DEV(i) {
+        /* Skip if port is not in mask */
+        if ((enabled_port_mask & (1ul << i)) == 0)
+            continue;
+
+        snprintf(bdr_str, MAX_STRING_LEN, " Port %u ", i);
+        STATS_BDR_STR(5, bdr_str);
+        rte_eth_dev_priv_dump(i, stdout);
+    }
+}
+
 static void
 display_nodecap_info(int is_leaf, struct rte_tm_node_capabilities *cap)

{

app/proc-info/main.c main(int argc, char **argv) · line 1582

Quoted 8 lines
app/proc-info/main.c +2 -0
@@ -1549,6 +1575,8 @@ main(int argc, char **argv)
     /* show information for PMD */
     if (enable_shw_port)
         show_port();
+    if (enable_shw_port_priv)
+        show_port_private_info();
     if (enable_shw_tm)
         show_tm();
     if (enable_shw_crypto)

.

#19 lore raw
In reply to Dongdong Liu

06/06/2022 16:39, Dongdong Liu:

Quoted 8 lines

From: "Min Hu (Connor)" <[email protected]>

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

Applied, thanks.

[...]

app/proc-info/main.c static char bdr_str[MAX_STRING_LEN]; · line 88

Quoted 4 lines

/**< Enable show port. */
static uint32_t enable_shw_port;

app/proc-info/main.c +2 -0
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;

That's very strange this file is using some (wrong) doxygen syntax. I'll fix this one when applying.
A cleanup may be needed for other comments in the file.

Quoted 3 lines

/**< Enable show tm. */
static uint32_t enable_shw_tm;
/**< Enable show crypto. */

#20 lore raw

Hi Thomas

Quoted 12 lines · Thomas Monjalon

06/06/2022 16:39, Dongdong Liu:

Quoted 8 lines

From: "Min Hu (Connor)" <[email protected]>

This patch adds support for dump the device private info from a running application. It can help developers locate the problem.

Applied, thanks.

Quoted 8 lines

[...]

app/proc-info/main.c static char bdr_str[MAX_STRING_LEN]; · line 88

Quoted 4 lines

/**< Enable show port. */
static uint32_t enable_shw_port;

app/proc-info/main.c +2 -0
+/**< Enable show port private info. */
+static uint32_t enable_shw_port_priv;

That's very strange this file is using some (wrong) doxygen syntax. I'll fix this one when applying.

Many thanks for fixing it.

Quoted 1 line

A cleanup may be needed for other comments in the file.

Will do.

Thanks,
Dongdong

Quoted 9 lines
Quoted 4 lines

/**< Enable show tm. */
static uint32_t enable_shw_tm;
/**< Enable show crypto. */

.