Skip to contentSkip to conversation

remote/memory: Replace share parameter with ram_flags

PATCH Superseded Yang Zhong 3 participants 3 messages Jul 8, 2021

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Yang Zhong

author
#0 lore raw

PATCH v2 1/1 remote/memory: Replace share parameter with ram_flags

Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to

qemu_ram_alloc_from_fd()")

---
 hw/remote/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +1 -1
index 472ed2a272..6e21ab1a45 100644
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
         subregion = g_new(MemoryRegion, 1);
         memory_region_init_ram_from_fd(subregion, NULL,
                                        name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                        sysmem_info->offsets[region],
                                        errp);
 
Signature · 1 line
2.29.2.334.gfaefdd61ec
Reviewed-by on v2 1/1
#1 lore raw
Quoted 2 lines · Yang Zhong
Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to

qemu_ram_alloc_from_fd()")

Oops.

Quoted 20 lines
---
 hw/remote/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +1 -1
index 472ed2a272..6e21ab1a45 100644
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
         subregion = g_new(MemoryRegion, 1);
         memory_region_init_ram_from_fd(subregion, NULL,
                                        name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                        sysmem_info->offsets[region],
                                        errp);
 
Reviewed-by on v2 1/1
#2 lore raw
In reply to Yang Zhong
Quoted 14 lines
Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to

qemu_ram_alloc_from_fd()")

---
 hw/remote/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +0 -0
index 472ed2a272..6e21ab1a45 100644

hw/remote/memory.c void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) · line 52

Quoted 8 lines
hw/remote/memory.c +1 -1
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
         subregion = g_new(MemoryRegion, 1);
         memory_region_init_ram_from_fd(subregion, NULL,
                                        name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                        sysmem_info->offsets[region],
                                        errp);