Skip to contentSkip to conversation

wifi: ata: pata_parport: epat.c Added missing spaces

PATCH In review [email protected] 3 participants 3 messages Jul 18, 2023 1 message not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 wifi: ata: pata_parport: epat.c Added missing spaces

Added spaces needed in the proper places to address:

./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '<' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)

---
 drivers/ata/pata_parport/epat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_parport/epat.c +1 -1
index 016bd96..efc18e2 100644
@@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
     epat_disconnect(pi);
 
     epat_connect(pi);
-    for (j=0;j<2;j++) {
+    for (j = 0; j < 2; j++) {
         WRi(6, 0xa0 + j * 0x10);
         for (k = 0; k < 256; k++) {
             WRi(2, k ^ 0xaa);
maintainer
#2 lore raw
Quoted 1 line · On 7/18/23 16:57, [email protected] wrote:

Added spaces needed in the proper places to address:

wifi ? I do not think so. Please fix the patch title.

Quoted 29 lines

./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '=' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '<' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)

---
  drivers/ata/pata_parport/epat.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_parport/epat.c +1 -1
index 016bd96..efc18e2 100644
@@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
      epat_disconnect(pi);
 
      epat_connect(pi);
-    for (j=0;j<2;j++) {
+    for (j = 0; j < 2; j++) {
          WRi(6, 0xa0 + j * 0x10);
          for (k = 0; k < 256; k++) {
              WRi(2, k ^ 0xaa);
Signature · 2 lines
Damien Le Moal
Western Digital Research
Reviewed-by Sergey Shtylyov on v1 1/1
#3 lore raw
In reply to [email protected]
Quoted 6 lines · On 7/18/23 10:57 AM, [email protected] wrote:

Added spaces needed in the proper places to address:

./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '=' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '<' (ctx:VxV) ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)

Is that from checkpatch.pl?

Quoted 1 line

Aside from the issue with the subject:

MBR, Sergey