busybox: add rev and pgrep
PATCH 1/1 busybox: add rev and pgrep
From: akuster <[email protected]>
--- meta/recipes-core/busybox/busybox/pgrep.cfg | 1 + meta/recipes-core/busybox/busybox/rev.cfg | 1 + meta/recipes-core/busybox/busybox_1.32.0.bb | 2 ++ 3 files changed, 4 insertions(+) create mode 100644 meta/recipes-core/busybox/busybox/pgrep.cfg create mode 100644 meta/recipes-core/busybox/busybox/rev.cfg
meta/recipes-core/busybox/busybox/pgrep.cfg new file +1 -0
@@ -0,0 +1 @@ +CONFIG_PGREP=y
meta/recipes-core/busybox/busybox/rev.cfg new file +1 -0
@@ -0,0 +1 @@ +CONFIG_REV=y
meta/recipes-core/busybox/busybox_1.32.0.bb +2 -0
@@ -44,6 +44,8 @@ SRC_URI = "https://busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \ file://0001-du-l-works-fix-to-use-145-instead-of-144.patch \ file://0001-sysctl-ignore-EIO-of-stable_secret-below-proc-sys-ne.patch \ file://0001-hwclock-make-glibc-2.31-compatible.patch \ + file://rev.cfg \ + file://pgrep.cfg \ " SRC_URI_append_libc-musl = " file://musl.cfg "
Signature · 1 line
2.17.1
Quoted 4 lines · akuster
From: akuster <[email protected]>
Signed-off-by akuster <[email protected]>
Quoted 44 lines
--- meta/recipes-core/busybox/busybox/pgrep.cfg | 1 + meta/recipes-core/busybox/busybox/rev.cfg | 1 + meta/recipes-core/busybox/busybox_1.32.0.bb | 2 ++ 3 files changed, 4 insertions(+) create mode 100644 meta/recipes-core/busybox/busybox/pgrep.cfg create mode 100644 meta/recipes-core/busybox/busybox/rev.cfgmeta/recipes-core/busybox/busybox/pgrep.cfg new file +1
-0@@ -0,0 +1 @@ +CONFIG_PGREP=ymeta/recipes-core/busybox/busybox/rev.cfg new file +1
-0@@ -0,0 +1 @@ +CONFIG_REV=ymeta/recipes-core/busybox/busybox_1.32.0.bb +2
-0@@ -44,6 +44,8 @@ SRC_URI = "https://busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \ file://0001-du-l-works-fix-to-use-145-instead-of-144.patch \ file://0001-sysctl-ignore-EIO-of-stable_secret-below-proc-sys-ne.patch \ file://0001-hwclock-make-glibc-2.31-compatible.patch \ + file://rev.cfg \ + file://pgrep.cfg \ "SRC_URI_append_libc-musl = " file://musl.cfg "
Signature · 1 line
2.17.1
Andrej Valek
Reviewed-by Diego SueiroHello,
Why are you not enabling these configs correctly via defconfig?
Regard,
Andrej
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Diego Sueiro
Sent: Thursday, October 15, 2020 11:08 AM
To: [email protected]
Subject: Re: [OE-core] [PATCH] busybox: add rev and pgrep
Quoted 4 lines · akuster
From: akuster <[email protected]>
Signed-off-by akuster <[email protected]>
Quoted 44 lines
--- meta/recipes-core/busybox/busybox/pgrep.cfg | 1 + meta/recipes-core/busybox/busybox/rev.cfg | 1 + meta/recipes-core/busybox/busybox_1.32.0.bb | 2 ++ 3 files changed, 4 insertions(+) create mode 100644 meta/recipes-core/busybox/busybox/pgrep.cfg create mode 100644 meta/recipes-core/busybox/busybox/rev.cfgmeta/recipes-core/busybox/busybox/pgrep.cfg new file +1
-0@@ -0,0 +1 @@ +CONFIG_PGREP=ymeta/recipes-core/busybox/busybox/rev.cfg new file +1
-0@@ -0,0 +1 @@ +CONFIG_REV=ymeta/recipes-core/busybox/busybox_1.32.0.bb +2
-0@@ -44,6 +44,8 @@ SRC_URI = "https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbusybox.net%2Fdownloads%2Fbusybox-%24&data=02%7C01%7Candrej.valek%40siemens.com%7C80ba39dac31e43e1548d08d870e9e36a%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637383497126679103&sdata=lfT1ZQw1pl%2BkmM5xMuBMWX1kWlEqeyzgfhOX%2B%2FFFHYg%3D&reserved=0{PV}.tar.bz2;name=tarball \ file://0001-du-l-works-fix-to-use-145-instead-of-144.patch \ file://0001-sysctl-ignore-EIO-of-stable_secret-below-proc-sys-ne.patch \ file://0001-hwclock-make-glibc-2.31-compatible.patch \ + file://rev.cfg \ + file://pgrep.cfg \ "SRC_URI_append_libc-musl = " file://musl.cfg "
Signature · 1 line
2.17.1
Quoted 1 line · Andrej Valek
Why are you not enabling these configs correctly via defconfig?
I'd wondered about that. I didn't really want to block the fixes on that discussion and am trying to pick the best places for discussion but I'd take patches tweaking this.
Cheers,
Richard
Quoted 6 lines · Richard Purdie
Quoted 1 line · Andrej Valek
Why are you not enabling these configs correctly via defconfig?
I'd wondered about that. I didn't really want to block the fixes on that discussion and am trying to pick the best places for discussion but I'd take patches tweaking this.
It would be good to clarify this. At one stage the advice was "the more fragmented the better". Does that no longer apply?
https://lists.openembedded.org/g/openembedded-core/topic/72273944#68672
Quoted 10 lines · Andre McCurdy
Quoted 7 lines · Richard Purdie
Quoted 1 line · Andrej Valek
Why are you not enabling these configs correctly via defconfig?
I'd wondered about that. I didn't really want to block the fixes on that discussion and am trying to pick the best places for discussion
but I'd take patches tweaking this.
Quoted 5 lines
It would be good to clarify this. At one stage the advice was "the more fragmented the better". Does that no longer apply?
https://lists.openembedded.org/g/openembedded-core/topic/72273944#68672
The fragments need to be useful. We could create a fragment per config option but that would clearly not be particularly useful/usable. Its a question of common sense, which is hard to document explicitly :/.
Cheers,
Richard
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Andre McCurdy
Quoted 7 lines · Richard Purdie
Quoted 1 line · Andrej Valek
Why are you not enabling these configs correctly via defconfig?
I'd wondered about that. I didn't really want to block the fixes on that discussion and am trying to pick the best places for discussion
but I'd take patches tweaking this.It would be good to clarify this. At one stage the advice was "the more fragmented the better". Does that no longer apply?
Quoted 6 lines
The fragments need to be useful. We could create a fragment per config option but that would clearly not be particularly useful/usable. Its a question of common sense, which is hard to document explicitly :/.
We have individual config fragments for sha1 and sha256 based on your advice in 2015. Has that been useful or usable?
Quoted 22 lines · Andre McCurdy
Quoted 20 lines · Richard Purdie
Quoted 18 lines · Andre McCurdy
Quoted 9 lines · Richard Purdie
Quoted 2 lines · Andrej Valek
Why are you not enabling these configs correctly via defconfig?
I'd wondered about that. I didn't really want to block the fixes on
that discussion and am trying to pick the best places for discussion
but I'd take patches tweaking this.It would be good to clarify this. At one stage the advice was "the
more fragmented the better". Does that no longer apply?https://lists.openembedded.org/g/openembedded-core/topic/72273944#68672
Quoted 8 lines
Quoted 5 lines
The fragments need to be useful. We could create a fragment per config
option but that would clearly not be particularly useful/usable. Its a
question of common sense, which is hard to document explicitly :/.We have individual config fragments for sha1 and sha256 based on your advice in 2015. Has that been useful or usable?
I said I was torn, there was a second opinion that the fragments in question were useful so we ran with that. I didn't say "the more the better". My comment was specifically directed at keeping the login pieces separate which I do still believe is the right move.
The distro situation was different 5 years ago, it would be interesting to see if any layers did end up overriding the checksum pieces. If they didn't, they likely can be merged IMO. Or maybe there should be one checksum fragment with our defaults in?
Cheers,
Richard