net/bnx2x: release port upon close
PATCH 1/1 net/bnx2x: release port upon close
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback.
--- drivers/net/bnx2x/bnx2x_ethdev.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/net/bnx2x/bnx2x_ethdev.c +15 -2
@@ -287,6 +287,10 @@ bnx2x_dev_close(struct rte_eth_dev *dev)PMD_INIT_FUNC_TRACE (sc); +/* only close in case of the primary process */ +if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) +return ; +if (IS_VF (sc))bnx2x_vf_close (sc);
@@ -295,6 +299,9 @@ bnx2x_dev_close(struct rte_eth_dev *dev)/* free ilt */ bnx2x_free_ilt_mem (sc); + +/* mac_addrs must not be freed alone because part of dev_private */ + dev->data->mac_addrs =NULL ; } static int
@@ -726,6 +733,11 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf) goto out; } +/* Pass the information to the rte_eth_dev_close() that it should also +* release the private port resources. +*/ + eth_dev->data->dev_flags |=RTE_ETH_DEV_CLOSE_REMOVE ; +return 0 ; out:
@@ -753,8 +765,9 @@ eth_bnx2xvf_dev_init(struct rte_eth_dev *eth_dev)static int eth_bnx2x_dev_uninit (struct rte_eth_dev *eth_dev) { -/* mac_addrs must not be freed alone because part of dev_private */ - eth_dev->data->mac_addrs =NULL ; +struct bnx2x_softc *sc = eth_dev->data->dev_private; +PMD_INIT_FUNC_TRACE (sc); +bnx2x_dev_close (eth_dev);return 0 ; }
Signature · 1 line
2.18.1
PATCH 1/1 net/qede: release port upon close
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback.
--- drivers/net/qede/qede_ethdev.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
drivers/net/qede/qede_ethdev.c +13 -12
@@ -1550,6 +1550,10 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)PMD_INIT_FUNC_TRACE (edev); +/* only close in case of the primary process */ +if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) +return ; +/* dev_stop() shall cleanup fp resources in hw but without releasing * dma memories and sw structures so that dev_start() can be called * by the app without reconfiguration. However, in dev_close() we
@@ -1586,6 +1590,10 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)if (ECORE_IS_CMT (edev))rte_eal_alarm_cancel (qede_poll_sp_sb_cb, (void *)eth_dev); + + eth_dev->dev_ops =NULL ; + eth_dev->rx_pkt_burst =NULL ; + eth_dev->tx_pkt_burst =NULL ; } static int
@@ -2701,6 +2709,11 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) adapter->ipgre.enable = false; } +/* Pass the information to the rte_eth_dev_close() that it should also +* release the private port resources. +*/ + eth_dev->data->dev_flags |=RTE_ETH_DEV_CLOSE_REMOVE ; + DP_INFO(edev, "MAC address : %02x:%02x:%02x:%02x:%02x:%02x\n", adapter->primary_mac.addr_bytes[0], adapter->primary_mac.addr_bytes[1],
@@ -2735,20 +2748,8 @@ static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev) {struct qede_dev *qdev = eth_dev->data->dev_private;struct ecore_dev *edev = &qdev->edev; -PMD_INIT_FUNC_TRACE (edev); - -/* only uninitialize in the primary process */ -if (rte_eal_process_type () !=RTE_PROC_PRIMARY ) -return 0 ; - -/* safe to close dev here */ qede_dev_close (eth_dev); - - eth_dev->dev_ops =NULL ; - eth_dev->rx_pkt_burst =NULL ; - eth_dev->tx_pkt_burst =NULL ; -return 0 ; }
Signature · 1 line
2.18.1
Quoted 6 lines · Rasesh Mody
Set
RTE_ETH_DEV_CLOSE_REMOVEupon probe so all the private resources for the port can be freed byrte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback.Signed-off-by Rasesh Mody <[email protected]>
It looks like it has ICC compiler errors in this patch[1]. I don't think, it is introduced by this patch. It is from CPT crypto driver.
[1]
http://mails.dpdk.org/archives/test-report/2020-September/155058.html
Quoted 6 lines · Jerin Jacob
Quoted 5 lines · Rasesh Mody
Set
RTE_ETH_DEV_CLOSE_REMOVEupon probe so all the private resources for the port can be freed byrte_eth_dev_close(). With this change the private port resources are released in the .dev_close callback.
Quoted 9 lines
Quoted 1 line
Signed-off-by Rasesh Mody <[email protected]>It looks like it has ICC compiler errors in this patch[1]. I don't think, it is introduced by this patch. It is from CPT crypto driver.
[1]
http://mails.dpdk.org/archives/test-report/2020-September/155058.html
These patches seems pulled to the Thomas' "cleanup ethdev close operation" patchset:
[v3,17/29] net/qede: release port upon close (https://patches.dpdk.org/patch/79083/)
[v3,06/29] net/bnx2x: release port upon close (https://patches.dpdk.org/patch/79072/)
Can you please review the patches in that patchset? And they can be merged with the whole patchset. I will mark this set as superseded.
Btw, agree that compile error looks unrelated.