tests/perf_pmu: Compare against requested freq in frequency subtest
PATCH 1/1 tests/perf_pmu: Compare against requested freq in frequency subtest
In igt@perf_pmu@frequency subtest, compare the requested freq reported by PMU not against the set freq but against the requested freq reported in sysfs. If requested freq differs from the set freq (even when min == max freq) for whatever reason, the sysfs requested freq should be closer to the PMU measured requested freq which should minimize sporadic failures.
--- tests/i915/perf_pmu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
tests/i915/perf_pmu.c +5 -3
@@ -1546,7 +1546,7 @@ test_interrupts_sync(int gem_fd)static void test_frequency (int gem_fd) { -uint32_t min_freq, max_freq, boost_freq; +uint32_t min_freq, max_freq, boost_freq, min_req, max_req;uint64_t val[2 ], start[2 ], slept;double min[2 ], max[2 ];igt_spin_t *spin;
@@ -1587,6 +1587,7 @@ test_frequency(int gem_fd) min[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; min[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + min_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);/* Don't leak busy bo into the next phase */
@@ -1613,6 +1614,7 @@ test_frequency(int gem_fd) max[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; max[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + max_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);
@@ -1633,12 +1635,12 @@ test_frequency(int gem_fd)igt_info ("Max frequency: requested %.1f, actual %.1f\n" , max[0 ], max[1 ]); -assert_within_epsilon (min[0 ], min_freq, tolerance); +assert_within_epsilon (min[0 ], min_req, tolerance);/* * On thermally throttled devices we cannot be sure maximum frequency * can be reached so use larger tolerance downards. */ -__assert_within_epsilon (max[0 ], max_freq, tolerance,0.15f ); +__assert_within_epsilon (max[0 ], max_req, tolerance,0.15f ); } static void
Signature · 1 line
2.38.0
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for tests/perf_pmu: Compare against requested freq in frequency subtest
== Series Details ==
== Series Details ==
Series: tests/perf_pmu: Compare against requested freq in frequency subtest
URL : https://patchwork.freedesktop.org/series/110574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12347 -> IGTPW_8050
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
Participating hosts (38 -> 27)
------------------------------
Missing (11): bat-dg2-8 bat-dg2-9 bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Known issues
------------
Here are the changes found in IGTPW_8050 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-pnv-d510/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-ivb-3770/igt@[email protected]
- fi-bsw-kefka: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-bsw-kefka/igt@[email protected]
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][5] ([i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-bsw-nick/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-mst}: [DMESG-WARN][6] ([i915#6434]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/fi-tgl-mst/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-tgl-mst/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][8] ([i915#2940]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/fi-bsw-kefka/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-bsw-kefka/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-ivb-3770: [INCOMPLETE][10] ([i915#3303] / [i915#7122]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/fi-ivb-3770/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/fi-ivb-3770/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#7122]: https://gitlab.freedesktop.org/drm/intel/issues/7122
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7044 -> IGTPW_8050
CI-20190529: 20190529
CI_DRM_12347: 3aa97a74d622aa26fe79cf4bd819b6a4fd176e90 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8050: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for tests/perf_pmu: Compare against requested freq in frequency subtest
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: tests/perf_pmu: Compare against requested freq in frequency subtest
URL : https://patchwork.freedesktop.org/series/110574/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12347_full -> IGTPW_8050_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
Participating hosts (9 -> 6)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Known issues
------------
Here are the changes found in IGTPW_8050_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@chamelium:
- shard-tglb: NOTRUN -> [SKIP][1] ([fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][2] ([fdo#111827])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb6/igt@[email protected]
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#4991])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@[email protected]
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-snb2/igt@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-iclb: NOTRUN -> [SKIP][5] ([i915#4525])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-glk2/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk3/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl1/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb1/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb7/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-glk: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk6/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-glk: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk5/igt@[email protected]
* igt@gem_pxp@create-regular-buffer:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#4270]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb5/igt@[email protected]
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#4270]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb3/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271]) +110 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@[email protected]
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#768]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#3297]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb7/igt@[email protected]
* igt@gem_userptr_blits@readonly-unsync:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#3297]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb6/igt@[email protected]
* igt@gem_vm_create@invalid-create:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +81 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-snb5/igt@[email protected]
* igt@gen3_mixed_blits:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109289]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb1/igt@gen3_mixed_blits.html
* igt@gen3_render_linear_blits:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#109289])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb6/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@bb-start-param:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#2856])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#658])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#1904])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb8/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][32] -> [FAIL][33] ([i915#3989] / [i915#454])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb7/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#1902])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#1902])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb5/igt@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109506] / [i915#2411])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109293] / [fdo#109506])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb7/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][38] -> [DMESG-FAIL][39] ([i915#5334])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl8/igt@i915_selftest@live@gt_heartbeat.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl8/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#5286]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#5286]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111614]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110725] / [fdo#111614]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111615])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb6/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278] / [i915#3886]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278]) +14 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3689] / [i915#6095]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3886]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk8/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#6095]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@kms_ccs@pipe-c-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#3689]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb3/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#111615] / [i915#3689]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb3/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@dp-crc-single:
- shard-snb: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-snb4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +7 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk2/igt@[email protected]
* igt@kms_color@ctm-0-25@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][57] ([i915#315] / [i915#6946]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb3/igt@kms_color@[email protected]
* igt@kms_color_chamelium@ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109284] / [fdo#111827]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb3/igt@[email protected]
* igt@kms_content_protection@atomic-dpms@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][59] ([i915#7121] / [i915#7173])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl3/igt@kms_content_protection@[email protected]
* igt@kms_content_protection@legacy:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#7118])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb2/igt@[email protected]
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][61] ([i915#1319] / [i915#7121] / [i915#7173])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl2/igt@kms_content_protection@[email protected]
* igt@kms_content_protection@lic:
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#7118]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@cursor-random-512x170:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#3359])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb1/igt@[email protected]
* igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109274] / [fdo#111825])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274]) +6 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb7/igt@[email protected]
* igt@kms_flip@2x-nonexisting-fb-interruptible:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109274] / [fdo#111825] / [i915#3637])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2587] / [i915#2672])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#2672]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#2672] / [i915#3555])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#2587] / [i915#2672]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#3555]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271]) +106 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109280] / [fdo#111825]) +9 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#6497]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109280]) +18 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb1/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#1839])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb6/igt@[email protected]
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [FAIL][77] ([i915#4573]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@kms_plane_alpha_blend@[email protected]
* igt@kms_plane_lowres@tiling-y@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#3536]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb7/igt@kms_plane_lowres@[email protected]
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#3536]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][80] -> [SKIP][81] ([i915#5235]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb5/igt@kms_plane_scaling@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@kms_plane_scaling@[email protected]
* igt@kms_prime@basic-modeset-hybrid:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#6524])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][83] ([i915#6524])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk7/igt@[email protected]
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109642] / [fdo#111068] / [i915#658])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb6/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_basic:
- shard-tglb: NOTRUN -> [FAIL][87] ([i915#132] / [i915#3467])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb7/igt@kms_psr@psr2_basic.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][88] -> [SKIP][89] ([fdo#109441]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109441]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [PASS][91] -> [SKIP][92] ([i915#5519])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb1/igt@[email protected]
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][93] -> [SKIP][94] ([i915#5519])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb2/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb3/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#111615] / [i915#5289])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb2/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2437])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-glk: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk1/igt@[email protected]
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2994])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb5/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-iclb: NOTRUN -> [SKIP][100] ([i915#2994]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb5/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][101] ([i915#4525]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb5/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl8/igt@gem_exec_fair@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-queues-priority:
- shard-iclb: [INCOMPLETE][105] ([i915#6453]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb6/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb8/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][107] ([i915#2190]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb2/igt@[email protected]
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [FAIL][109] ([i915#4171]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb3/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb8/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][111] ([i915#5566] / [i915#716]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-glk6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk8/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][113] ([i915#5591]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb5/igt@i915_selftest@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-apl: [FAIL][115] ([i915#2346]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl2/igt@kms_cursor_legacy@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@kms_cursor_legacy@[email protected]
- shard-iclb: [FAIL][117] ([i915#2346]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb7/igt@kms_cursor_legacy@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@kms_cursor_legacy@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][119] ([i915#433]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb7/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +4 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl6/igt@kms_hdr@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl1/igt@kms_hdr@[email protected]
* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-a-dp-1:
- shard-apl: [DMESG-WARN][123] ([i915#7166]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl6/igt@kms_plane_scaling@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl7/igt@kms_plane_scaling@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][125] ([fdo#109441]) -> [PASS][126] +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb5/igt@kms_psr@psr2_cursor_render.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
#### Warnings ####
* igt@gem_pread@exhaustion:
- shard-apl: [WARN][127] ([i915#2658]) -> [INCOMPLETE][128] ([i915#7248])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl7/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl8/igt@[email protected]
- shard-tglb: [INCOMPLETE][129] ([i915#7248]) -> [WARN][130] ([i915#2658])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-tglb6/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-tglb8/igt@[email protected]
- shard-glk: [INCOMPLETE][131] ([i915#7248]) -> [WARN][132] ([i915#2658]) +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-glk1/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-glk6/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: [INCOMPLETE][133] ([i915#7248]) -> [WARN][134] ([i915#2658])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][135] ([i915#658]) -> [SKIP][136] ([i915#2920])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb8/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][137] ([fdo#111068] / [i915#658]) -> [SKIP][138] ([i915#2920]) +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-iclb7/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][144], [FAIL][145]) ([i915#3002] / [i915#4312])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl1/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl2/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl8/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl8/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12347/shard-apl6/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl7/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/shard-apl6/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7166]: https://gitlab.freedesktop.org/drm/intel/issues/7166
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7044 -> IGTPW_8050
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12347: 3aa97a74d622aa26fe79cf4bd819b6a4fd176e90 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8050: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
IGT_7044: dbeb6f92720292f8303182a0e649284cea5b11a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8050/index.html
Quoted 7 lines · Ashutosh Dixit
In igt@perf_pmu@frequency subtest, compare the requested freq reported by PMU not against the set freq but against the requested freq reported in sysfs. If requested freq differs from the set freq (even when min == max freq) for whatever reason, the sysfs requested freq should be closer to the PMU measured requested freq which should minimize sporadic failures.
So this bug describes the failure looks like this:
Starting subtest: frequency
(perf_pmu:1798) CRITICAL: Test assertion failure function test_frequency, file ../tests/i915/perf_pmu.c:1636:
(perf_pmu:1798) CRITICAL: Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq) (perf_pmu:1798) CRITICAL: 'min[0]' != 'min_freq' (347.914580 not within +5.0%/-5.0% tolerance of 300.000000)
Subtest frequency failed.
Which is this in code:
min_freq = igt_sysfs_get_u32(sysfs, "gt_RPn_freq_mhz");
...
/*
* Set GPU to min frequency and read PMU counters.
*/
igt_require(igt_sysfs_set_u32(sysfs, "gt_min_freq_mhz", min_freq));
igt_require(igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz") == min_freq);
igt_require(igt_sysfs_set_u32(sysfs, "gt_max_freq_mhz", min_freq));
igt_require(igt_sysfs_get_u32(sysfs, "gt_max_freq_mhz") == min_freq);
igt_require(igt_sysfs_set_u32(sysfs, "gt_boost_freq_mhz", min_freq));
igt_require(igt_sysfs_get_u32(sysfs, "gt_boost_freq_mhz") == min_freq);
...
gem_quiescent_gpu(gem_fd); /* Idle to be sure the change takes effect */
spin = spin_sync_flags(gem_fd, ahnd, 0, I915_EXEC_DEFAULT);
slept = pmu_read_multi(fd[0], 2, start);
measured_usleep(batch_duration_ns / 1000);
slept = pmu_read_multi(fd[0], 2, val) - slept;
min[0] = 1e9*(val[0] - start[0]) / slept;
min[1] = 1e9*(val[1] - start[1]) / slept;
...
/*
* Restore min/max.
*/
igt_sysfs_set_u32(sysfs, "gt_min_freq_mhz", min_freq);
if (igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz") != min_freq)
igt_warn("Unable to restore min frequency to saved value [%u MHz], now %u MHz\n",
min_freq, igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz"));
close(fd[0]);
close(fd[1]);
put_ahnd(ahnd);
igt_info("Min frequency: requested %.1f, actual %.1f\n",
min[0], min[1]);
igt_info("Max frequency: requested %.1f, actual %.1f\n",
max[0], max[1]);
assert_within_epsilon(min[0], min_freq, tolerance);Which means sysfs told the test which is the minimum frequency. But it really isn't - it turns out 350 MHz is the real minimum? Or setting of gt_max_freq_mhz/gt_boost_freq_mhz is not actually respected by SLPC? It sounds trivial to respect the minimum frequency so I don't see what is the excuse.
Regards,
Tvrtko
Quoted 50 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/perf_pmu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)tests/i915/perf_pmu.c +5
-3@@ -1546,7 +1546,7 @@ test_interrupts_sync(int gem_fd)static void test_frequency (int gem_fd) { -uint32_t min_freq, max_freq, boost_freq; +uint32_t min_freq, max_freq, boost_freq, min_req, max_req;uint64_t val[2 ], start[2 ], slept;double min[2 ], max[2 ];igt_spin_t *spin;@@ -1587,6 +1587,7 @@ test_frequency(int gem_fd) min[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; min[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + min_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);/* Don't leak busy bo into the next phase */ @@ -1613,6 +1614,7 @@ test_frequency(int gem_fd) max[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; max[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + max_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);@@ -1633,12 +1635,12 @@ test_frequency(int gem_fd)igt_info ("Max frequency: requested %.1f, actual %.1f\n" , max[0 ], max[1 ]); -assert_within_epsilon (min[0 ], min_freq, tolerance); +assert_within_epsilon (min[0 ], min_req, tolerance);/* * On thermally throttled devices we cannot be sure maximum frequency * can be reached so use larger tolerance downards. */ -__assert_within_epsilon (max[0 ], max_freq, tolerance,0.15f ); +__assert_within_epsilon (max[0 ], max_req, tolerance,0.15f ); } static void
Quoted 1 line · Tvrtko Ursulin
Hi Tvrtko,
Quoted 60 lines · Ashutosh Dixit
Quoted 7 lines
In igt@perf_pmu@frequency subtest, compare the requested freq reported by PMU not against the set freq but against the requested freq reported in sysfs. If requested freq differs from the set freq (even when min == max freq) for whatever reason, the sysfs requested freq should be closer to the PMU measured requested freq which should minimize sporadic failures.
So this bug describes the failure looks like this:
Starting subtest: frequency
(perf_pmu:1798) CRITICAL: Test assertion failure functiontest_frequency, file../tests/i915/perf_pmu.c:1636:
(perf_pmu:1798) CRITICAL: Failed assertion: (double)(min[0]) <= (1.0 + (tolerance)) * (double)(min_freq) && (double)(min[0]) >= (1.0 - (tolerance)) * (double)(min_freq) (perf_pmu:1798) CRITICAL: 'min[0]' != 'min_freq' (347.914580 not within +5.0%/-5.0% tolerance of 300.000000)
Subtest frequency failed.Which is this in code:
min_freq = igt_sysfs_get_u32(sysfs, "gt_RPn_freq_mhz"); ... /* * Set GPU to min frequency and read PMU counters. */ igt_require(igt_sysfs_set_u32(sysfs, "gt_min_freq_mhz", min_freq)); igt_require(igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz") == min_freq); igt_require(igt_sysfs_set_u32(sysfs, "gt_max_freq_mhz", min_freq)); igt_require(igt_sysfs_get_u32(sysfs, "gt_max_freq_mhz") == min_freq); igt_require(igt_sysfs_set_u32(sysfs, "gt_boost_freq_mhz", min_freq)); igt_require(igt_sysfs_get_u32(sysfs, "gt_boost_freq_mhz") == min_freq); ... gem_quiescent_gpu(gem_fd); /* Idle to be sure the change takes effect */ spin = spin_sync_flags(gem_fd, ahnd, 0, I915_EXEC_DEFAULT); slept = pmu_read_multi(fd[0], 2, start); measured_usleep(batch_duration_ns / 1000); slept = pmu_read_multi(fd[0], 2, val) - slept; min[0] = 1e9*(val[0] - start[0]) / slept; min[1] = 1e9*(val[1] - start[1]) / slept; ... /* * Restore min/max. */ igt_sysfs_set_u32(sysfs, "gt_min_freq_mhz", min_freq); if (igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz") != min_freq) igt_warn("Unable to restore min frequency to saved value [%u MHz], now %u MHz\n", min_freq, igt_sysfs_get_u32(sysfs, "gt_min_freq_mhz")); close(fd[0]); close(fd[1]); put_ahnd(ahnd); igt_info("Min frequency: requested %.1f, actual %.1f\n", min[0], min[1]); igt_info("Max frequency: requested %.1f, actual %.1f\n", max[0], max[1]); assert_within_epsilon(min[0], min_freq, tolerance);
Quoted 5 lines
Which means sysfs told the test which is the minimum frequency. But it really isn't - it turns out 350 MHz is the real minimum? Or setting of gt_max_freq_mhz/gt_boost_freq_mhz is not actually respected by SLPC? It sounds trivial to respect the minimum frequency so I don't see what is the excuse.
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```
So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
Thanks.
--
Ashutosh
Quoted 49 lines
Regards,
Tvrtko
Quoted 44 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>--- tests/i915/perf_pmu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)tests/i915/perf_pmu.c +5
-2@@ -1546,7 +1546,7 @@ test_interrupts_sync(int gem_fd)static void test_frequency (int gem_fd) { -uint32_t min_freq, max_freq, boost_freq; +uint32_t min_freq, max_freq, boost_freq, min_req, max_req;uint64_t val[2 ], start[2 ], slept;double min[2 ], max[2 ];igt_spin_t *spin;@@ -1587,6 +1587,7 @@ test_frequency(int gem_fd) min[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; min[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + min_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);/* Don't leak busy bo into the next phase */ @@ -1613,6 +1614,7 @@ test_frequency(int gem_fd) max[0 ] =1e9 *(val[0 ] - start[0 ]) / slept; max[1 ] =1e9 *(val[1 ] - start[1 ]) / slept; + max_req =igt_sysfs_get_u32 (sysfs,"gt_cur_freq_mhz" );igt_spin_free (gem_fd, spin);gem_quiescent_gpu (gem_fd);@@ -1633,12 +1635,12 @@ test_frequency(int gem_fd)igt_info ("Max frequency: requested %.1f, actual %.1f\n" , max[0 ], max[1 ]); -assert_within_epsilon (min[0 ], min_freq, tolerance); +assert_within_epsilon (min[0 ], min_req, tolerance);/* * On thermally throttled devices we cannot be sure maximum frequency * can be reached so use larger tolerance downards. */ -__assert_within_epsilon (max[0 ], max_freq, tolerance,0.15f ); +__assert_within_epsilon (max[0 ], max_req, tolerance,0.15f ); } static void
Quoted 1 line · Ashutosh
Hi Vinay,
A question for you below.
Quoted 31 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
Quoted 3 lines
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Thanks.
--
Ashutosh
Quoted 36 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 31 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
Quoted 6 lines
Quoted 3 lines
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Does adding a delay help (around 20 ms for the h2g to go through typically)? Also, is there a workload running when we change the min=max=boost to 300?
We already check these things in our SLPC selftests.
Thanks,
Vinay.
Quoted 4 lines
Thanks.
--
Ashutosh
Quoted 43 lines · Vinay
Quoted 40 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 34 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
Quoted 6 lines
Quoted 3 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls gem_quiescent_gpu() after setting 'min == max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time for the h2g) and still the requested freq is 350 MHz.
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling gem_quiescent_gpu().
Quoted 11 lines
We already check these things in our SLPC selftests.
Thanks,
Vinay.
Quoted 4 lines
Thanks.
--
Ashutosh
Quoted 54 lines · Ashutosh
Quoted 41 lines · Vinay
Quoted 40 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 34 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
Quoted 6 lines
Quoted 3 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min == max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time for the h2g) and still the requested freq is 350 MHz.
Quoted 5 lines
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().
Implication here seems to be that gem_quiescent_gpu() would need to cover H2G communication - does it?
Quoted 1 line
Quoted 1 line
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
Regards,
Tvrtko
Quoted 57 lines · Tvrtko Ursulin
Quoted 55 lines · Ashutosh
Quoted 42 lines · Vinay
Quoted 41 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 35 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
Quoted 6 lines
Quoted 3 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min == max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time for the h2g) and still the requested freq is 350 MHz.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().Implication here seems to be that
gem_quiescent_gpu()would need to cover H2G communication - does it?
No, more like there needs to be a WL running in order for SLPC to actively make changes to the requested frequency.
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
It should respect the 300 Mhz. The only question in my mind is regarding efficient frequency. Can we print out what the RP1 is here?
Thanks,
Vinay.
Quoted 5 lines
Regards,
Tvrtko
Quoted 76 lines · Vinay
Quoted 73 lines · Tvrtko Ursulin
Quoted 71 lines · Ashutosh
Quoted 51 lines · Vinay
Quoted 50 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 44 lines
So I submitted this patch to repro the issue and to print out the requested
freq from sysfs:https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is
measuring what sysfs is showing). In general PCODE is the final arbiter in
such cases and we do occasionally see instances where set freq limits are
not honored.I would say if igt@perf_pmu@frequency is testing freq measured by PMU then
the patch below is correct. Whether SLPC/PCODE is honoring the set freq
limits should be tested in a SLPC test (which we also have).Quoted 8 lines
Quoted 5 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still
see the requested freq to be 350 MHz. Do we have a SLPC test covering this
scenario or should we add one? This is failing on one of the DG2's.Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min
== max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time
for the h2g) and still the requested freq is 350 MHz.Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().Implication here seems to be that
gem_quiescent_gpu()would need to cover H2G communication - does it?No, more like there needs to be a WL running in order for SLPC to actively make changes to the requested frequency.
Well here we set the freq's first and later when the WL runs FW should select an appropriate requested freq.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
It should respect the 300 Mhz. The only question in my mind is regarding efficient frequency. Can we print out what the RP1 is here?
RP1 is also 300. We can see it here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8071/bat-dg2-11/igt@[email protected]
with this patch:
https://patchwork.freedesktop.org/series/110630/#rev3
In this case, min == max == 300, but requested freq is 400 (previously it was 350).
Thanks.
--
Ashutosh
Quoted 87 lines · Ashutosh
Quoted 68 lines · Vinay
Quoted 66 lines · Tvrtko Ursulin
Quoted 65 lines · Ashutosh
Quoted 50 lines · Vinay
Quoted 49 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 44 lines
So I submitted this patch to repro the issue and to print out the requested
freq from sysfs:https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is
measuring what sysfs is showing). In general PCODE is the final arbiter in
such cases and we do occasionally see instances where set freq limits are
not honored.I would say if igt@perf_pmu@frequency is testing freq measured by PMU then
the patch below is correct. Whether SLPC/PCODE is honoring the set freq
limits should be tested in a SLPC test (which we also have).Quoted 7 lines
Quoted 5 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still
see the requested freq to be 350 MHz. Do we have a SLPC test covering this
scenario or should we add one? This is failing on one of the DG2's.Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min
== max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time
for the h2g) and still the requested freq is 350 MHz.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().Implication here seems to be that
gem_quiescent_gpu()would need to cover H2G communication - does it?No, more like there needs to be a WL running in order for SLPC to actively make changes to the requested frequency.
Well here we set the freq's first and later when the WL runs FW should select an appropriate requested freq.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
It should respect the 300 Mhz. The only question in my mind is regarding efficient frequency. Can we print out what the RP1 is here?
RP1 is also 300. We can see it here:
Quoted 8 lines
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8071/bat-dg2-11/igt@[email protected]
with this patch:
https://patchwork.freedesktop.org/series/110630/#rev3
In this case, min == max == 300, but requested freq is 400 (previously it was 350).
Ok, this might be happening due to the following -
1. We have efficient frequency enabled now, so GuC will use that instead of min even on light loads etc.
2. It is also known that this efficient frequency is "dynamic", especially on DG2.
3. When we set min freq to a value lower than efficient, we will turn off efficient frequency usage. But, here min = efficient = 300, so it will remain ON.
This is why we see 350 or even 400 sometimes as we are not bound to the min (or even a single freq level) when efficient freq usage is allowed. The solution for this case may be to turn off efficient frequency forcibly for this test and see if that helps. We do that in the selftests to ensure proper frequency bounds.
Thanks,
Vinay.
Quoted 4 lines
Thanks.
--
Ashutosh
Quoted 106 lines · Vinay
Quoted 87 lines · Ashutosh
Quoted 68 lines · Vinay
Quoted 66 lines · Tvrtko Ursulin
Quoted 65 lines · Ashutosh
Quoted 50 lines · Vinay
Quoted 49 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 44 lines
So I submitted this patch to repro the issue and to print out the requested
freq from sysfs:https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is
measuring what sysfs is showing). In general PCODE is the final arbiter in
such cases and we do occasionally see instances where set freq limits are
not honored.I would say if igt@perf_pmu@frequency is testing freq measured by PMU then
the patch below is correct. Whether SLPC/PCODE is honoring the set freq
limits should be tested in a SLPC test (which we also have).Quoted 7 lines
Quoted 5 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still
see the requested freq to be 350 MHz. Do we have a SLPC test covering this
scenario or should we add one? This is failing on one of the DG2's.Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min
== max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time
for the h2g) and still the requested freq is 350 MHz.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().Implication here seems to be that
gem_quiescent_gpu()would need to cover H2G communication - does it?No, more like there needs to be a WL running in order for SLPC to actively make changes to the requested frequency.
Well here we set the freq's first and later when the WL runs FW should select an appropriate requested freq.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
It should respect the 300 Mhz. The only question in my mind is regarding efficient frequency. Can we print out what the RP1 is here?
RP1 is also 300. We can see it here:
Quoted 8 lines
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8071/bat-dg2-11/igt@[email protected]
with this patch:
https://patchwork.freedesktop.org/series/110630/#rev3
In this case, min == max == 300, but requested freq is 400 (previously it was 350).
Ok, this might be happening due to the following -
1. We have efficient frequency enabled now, so GuC will use that instead of min even on light loads etc.
2. It is also known that this efficient frequency is "dynamic", especially on DG2.
Quoted 6 lines
3. When we set min freq to a value lower than efficient, we will turn off efficient frequency usage. But, here min = efficient = 300, so it will remain ON.
This is why we see 350 or even 400 sometimes as we are not bound to the min (or even a single freq level) when efficient freq usage is allowed.
Hi Vinay, thanks for the explanation, makes sense.
Quoted 3 lines
The solution for this case may be to turn off efficient frequency forcibly for this test and see if that helps. We do that in the selftests to ensure proper frequency bounds.
I don't believe we can do this from userland, can we?
Thanks.
--
Ashutosh
Quoted 56 lines · Tvrtko Ursulin
Quoted 54 lines · Ashutosh
Quoted 41 lines · Vinay
Quoted 40 lines · Ashutosh
On Mon, 07 Nov 2022 16:18:31 -0800, Dixit, Ashutosh wrote:
Hi Vinay,A question for you below.
Quoted 34 lines
So I submitted this patch to repro the issue and to print out the requested freq from sysfs:
https://patchwork.freedesktop.org/series/110630/
And we can see the output here:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8061/bat-dg2-11/igt@[email protected]
``` IGT-Version: 1.26-g1bef4d081 (x86_64) (Linux: 6.1.0-rc4-CI_DRM_12352-gc55ac6a74bd1+ x86_64) Starting subtest: frequency Frequency: min=300, max=2050, boost=2050 MHz Min frequency: requested 349.7, actual 349.7 Max frequency: requested 2048.0, actual 2048.0 Sysfs requested: min 350, max 2050 Stack trace: #0 ../../../usr/src/igt-gpu-tools/lib/igt_core.c:1908 __igt_fail_assert() #1 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:1656 __igt_unique____real_main2147() #2 ../../../usr/src/igt-gpu-tools/tests/i915/perf_pmu.c:2147 main() #3 [__libc_start_main+0xf3] #4 [_start+0x2e] Subtest frequency: FAIL (2.212s) ```So we clearly see the requested freq from sysfs is indeed 350 MHz so SLPC/PCODE is not honoring the set min == max == boost freq (and PMU is measuring what sysfs is showing). In general PCODE is the final arbiter in such cases and we do occasionally see instances where set freq limits are not honored.
I would say if igt@perf_pmu@frequency is testing freq measured by PMU then the patch below is correct. Whether SLPC/PCODE is honoring the set freq limits should be tested in a SLPC test (which we also have).
Quoted 6 lines
Quoted 3 lines
igt@perf_pmu@frequency sets 'min == max == boost == 300 MHz' but we still see the requested freq to be 350 MHz. Do we have a SLPC test covering this scenario or should we add one? This is failing on one of the DG2's.
Does adding a delay help (around 20 ms for the h2g to go through typically)?
There is no delay but the test calls
gem_quiescent_gpu()after setting 'min == max == boost == 300 MHz' and then launches a spinner. We are checking the requested freq 500 ms after the spinner is started (so plenty of time for the h2g) and still the requested freq is 350 MHz.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Also, is there a workload running when we change the min=max=boost to 300?
No, the workload is started after setting the freq and calling
gem_quiescent_gpu().Implication here seems to be that
gem_quiescent_gpu()would need to cover H2G communication - does it?
Don't think gem_quiescent_gpu should cover h2g delays. I have added a separate 100 ms delay (which I've used elsewhere too) in v2. I am not sure what is the delay caused by gem_quiescent_gpu and if that is sufficient we don't need this additional 100 ms delay. Anyway the delay will make PMU measurements a little more accurate but does not affect the overall result.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
We already check these things in our SLPC selftests.
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
The max is set to 300 MHz but is not respected. So the sysfs readback shows max as 300 MHz but actual requested freq is higher. The flow is that i915 sets min/max using h2g. GuC FW validates the parameters in the top-half and returns success (which results in max freq being set in i915 to 300 MHz) but the actual min/max freq change in PCODE is done later in the bottom-half because of which the delay is needed.
Though Vinay we never read the max freq back from FW, that is we call intel_rps_get_max_frequency and not intel_guc_slpc_get_max_freq when displaying in sysfs. That is we display i915 cached values rather than interrogate FW, assuming that FW min/max values are same as the cached values. I can add a couple more prints and see what actual FW values are.
Thanks.
--
Ashutosh
Quoted 11 lines · Ashutosh
Quoted 3 lines
Is it then expected to respect the 300MHz max in this case? Or if it can't, should it be reflected in the sysfs readback?
The max is set to 300 MHz but is not respected. So the sysfs readback shows max as 300 MHz but actual requested freq is higher. The flow is that i915 sets min/max using h2g. GuC FW validates the parameters in the top-half and returns success (which results in max freq being set in i915 to 300 MHz) but the actual min/max freq change in PCODE is done later in the bottom-half because of which the delay is needed.
Quoted 5 lines
Though Vinay we never read the max freq back from FW, that is we call
intel_rps_get_max_frequencyand notintel_guc_slpc_get_max_freqwhen displaying in sysfs. That is we display i915 cached values rather than interrogate FW, assuming that FW min/max values are same as the cached values. I can add a couple more prints and see what actual FW values are.
So I submitted this patch which queries freq's from FW rather than displaying cached values:
https://patchwork.freedesktop.org/series/110685/
But here also we see the same min/max freq's:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110685v1/bat-dg2-11/igt@[email protected]
So this means freq's set in FW match the cached values in i915.
(Compare the above results against:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8071/bat-dg2-11/igt@[email protected]
which uses cached values).
So again we are back to the earlier conclusion that "max is set to 300 MHz but is not respected".
So finally let's think about whether v1 or v2 of the IGT patch makes sense:
https://patchwork.freedesktop.org/series/110574/
Thanks.
--
Ashutosh