wifi: rtw88: add quirks to disable PCI ASPM and deep LPS for HP P3S95EA#ACB
Ping-Ke Shih
maintainerPATCH 1/1 wifi: rtw88: add quirks to disable PCI ASPM and deep LPS for HP P3S95EA#ACB
On an HP laptop (P3S95EA#ACB) equipped with a Realtek RTL8821CE 802.11ac PCIe adapter (PCI ID: 10ec:c821), the system experiences a hard lockup (complete freeze of the UI and kernel, sysrq doesn't work, requires holding the power button) when the WiFi adapter enters the power saving state. Disable PCI ASPM to avoid system freeze.
In addition, driver throws messages periodically. Though this doesn't always cause unstable connection, missing H2C commands might cause unpredictable results. Disable deep LPS to avoid this as well.
rtw88_8821ce 0000:13:00.0: firmware failed to leave lps state rtw88_8821ce 0000:13:00.0: failed to send h2c command rtw88_8821ce 0000:13:00.0: failed to send h2c command
--- drivers/net/wireless/realtek/rtw88/main.h | 5 ++++ drivers/net/wireless/realtek/rtw88/pci.c | 31 +++++++++++++++++++++++ 2 files changed, 36 insertions(+)
drivers/net/wireless/realtek/rtw88/main.h +5 -0
@@ -432,6 +432,11 @@ enum rtw_wow_flags { RTW_WOW_FLAG_MAX, }; +enum rtw_quirk_dis_caps { +QUIRK_DIS_CAP_PCI_ASPM , +QUIRK_DIS_CAP_LPS_DEEP , +}; +/* the power index is represented by differences, which cck-1s & ht40-1s are * the base values, so for 1s's differences, there are only ht20 & ofdm */
drivers/net/wireless/realtek/rtw88/pci.c +31 -0
@@ -2,6 +2,7 @@/* Copyright(c) 2018-2019 Realtek Corporation */ +#include <linux/dmi.h> #include <linux/module.h> #include <linux/pci.h> #include "main.h"
@@ -1744,6 +1745,34 @@ const struct pci_error_handlers rtw_pci_err_handler = { };EXPORT_SYMBOL (rtw_pci_err_handler); +static int rtw_pci_disable_caps (const struct dmi_system_id *dmi) +{ +uintptr_t dis_caps = (uintptr_t )dmi->driver_data; + +if (dis_caps &BIT (QUIRK_DIS_CAP_PCI_ASPM )) + rtw_pci_disable_aspm = true; + +if (dis_caps &BIT (QUIRK_DIS_CAP_LPS_DEEP )) + rtw_disable_lps_deep_mode = true; + +return 1 ; +} + +static const struct dmi_system_id rtw_pci_quirks[] = { + { + .callback = rtw_pci_disable_caps, + .ident ="HP Notebook - P3S95EA#ACB" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"HP" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"HP Notebook" ), +DMI_MATCH (DMI_PRODUCT_SKU ,"P3S95EA#ACB" ), + }, + .driver_data = (void *)(BIT (QUIRK_DIS_CAP_PCI_ASPM ) | +BIT (QUIRK_DIS_CAP_LPS_DEEP )), + }, + {} +}; +int rtw_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) {
@@ -1771,6 +1800,8 @@ int rtw_pci_probe(struct pci_dev *pdev, rtwpci = (struct rtw_pci *)rtwdev->priv;atomic_set (&rtwpci->link_usage,1 ); +dmi_check_system (rtw_pci_quirks); + ret =rtw_core_init (rtwdev);if (ret) goto err_release_hw;
base-commit: 039cd522dc70151da13329a5e3ae19b1736f468a
Signature · 1 line
2.25.1
Quoted 8 lines · Ping-Ke Shih
On an HP laptop (P3S95EA#ACB) equipped with a Realtek RTL8821CE 802.11ac PCIe adapter (PCI ID: 10ec:c821), the system experiences a hard lockup (complete freeze of the UI and kernel, sysrq doesn't work, requires holding the power button) when the WiFi adapter enters the power saving state. Disable PCI ASPM to avoid system freeze.
In addition, driver throws messages periodically. Though this doesn't always cause unstable connection, missing H2C commands might cause unpredictable results. Disable deep LPS to avoid this as well.
Tested on HP Notebook P3S95EA#ACB (kernel 6.19.7-1-cachyos):
- No hard freeze observed during idle or active usage.
- Zero h2c or lps errors in dmesg across idle (10 min), load stress (100MB download), and suspend/resume cycle.
- Both quirk flags confirmed active via sysfs without any manual modprobe parameters.
Best regards,
Oleksandr Havrylov
Ping-Ke Shih
maintainerQuoted 11 lines · LB F
Quoted 8 lines · Ping-Ke Shih
On an HP laptop (P3S95EA#ACB) equipped with a Realtek RTL8821CE 802.11ac PCIe adapter (PCI ID: 10ec:c821), the system experiences a hard lockup (complete freeze of the UI and kernel, sysrq doesn't work, requires holding the power button) when the WiFi adapter enters the power saving state. Disable PCI ASPM to avoid system freeze.
In addition, driver throws messages periodically. Though this doesn't always cause unstable connection, missing H2C commands might cause unpredictable results. Disable deep LPS to avoid this as well.
Quoted 7 lines
Tested on HP Notebook P3S95EA#ACB (kernel 6.19.7-1-cachyos):
- No hard freeze observed during idle or active usage.
- Zero h2c or lps errors in dmesg across idle (10 min), load stress (100MB download), and suspend/resume cycle.
- Both quirk flags confirmed active via sysfs without any manual modprobe parameters.
Thanks for your test. I'd add this information to commit message during getting merged.
Quoted 3 lines
Tested-by Oleksandr Havrylov <[email protected]>
As well as your Tested-by.
Ping-Ke
Ping-Ke Shih
maintainerQuoted 10 lines · Ping-Ke Shih
On an HP laptop (P3S95EA#ACB) equipped with a Realtek RTL8821CE 802.11ac PCIe adapter (PCI ID: 10ec:c821), the system experiences a hard lockup (complete freeze of the UI and kernel, sysrq doesn't work, requires holding the power button) when the WiFi adapter enters the power saving state. Disable PCI ASPM to avoid system freeze.
In addition, driver throws messages periodically. Though this doesn't always cause unstable connection, missing H2C commands might cause unpredictable results. Disable deep LPS to avoid this as well.
Quoted 8 lines
rtw88_8821ce0000:13:00.0: firmware failed to leave lps statertw88_8821ce0000:13:00.0: failed to send h2c commandrtw88_8821ce0000:13:00.0: failed to send h2c command
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
b2bf9d61e14a wifi: rtw88: add quirks to disable PCI ASPM and deep LPS for HP P3S95EA#ACB