update-linux-headers: Remove "asm-s390/unistd_32.h"
PATCH 1/1 update-linux-headers: Remove "asm-s390/unistd_32.h"
The "asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit 4ac286c4a8d9 ("s390/syscalls: Switch to generic system call table generation")
unistd_32.h is no longer generated when running make header_install. Remove it.
--- scripts/update-linux-headers.sh | 1 - 1 file changed, 1 deletion(-)
scripts/update-linux-headers.sh +0 -1
@@ -154,7 +154,6 @@ EOF mkdir -p "$output/include/standard-headers/asm-$arch" if [ $arch = s390 ]; then cp_portable "$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-s390/" cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/asm-s390/" fi if [ $arch = arm64 ]; then
Signature · 1 line
2.52.0
Quoted 20 lines · Cédric Le Goater
The "
asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit4ac286c4a8d9("s390/syscalls: Switch to generic system call table generation")
unistd_32.his no longer generated when running makeheader_install. Remove it.Reported-by Shameer Kolothum <[email protected]>Cc Thomas Huth <[email protected]>Signed-off-by Cédric Le Goater <[email protected]>--- scripts/update-linux-headers.sh | 1 - 1 file changed, 1 deletion(-)scripts/update-linux-headers.sh +0
-0
scripts/update-linux-headers.sh EOF · line 158
Quoted 6 lines
scripts/update-linux-headers.sh +0
-1@@ -154,7 +154,6 @@ EOF mkdir -p "$output/include/standard-headers/asm-$arch" if [ $arch = s390 ]; then cp_portable "$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-s390/" cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/asm-s390/" fi
I think it would make sense to remove linux-headers/asm-s390/unistd_32.h in this patch, too, otherwise this will stay around as a stale file, I guess?
Anyway,
Quoted 16 lines · Thomas Huth
Quoted 15 lines · Cédric Le Goater
The "
asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit4ac286c4a8d9("s390/syscalls: Switch to generic system call table generation")
unistd_32.his no longer generated when running makeheader_install. Remove it.Reported-by Shameer Kolothum <[email protected]>Cc Thomas Huth <[email protected]>Signed-off-by Cédric Le Goater <[email protected]>---
scripts/update-linux-headers.sh| 1 -1 file changed, 1 deletion(-)
Quoted 13 lines
Quoted 11 lines
scripts/update-linux-headers.sh +0
-0@@ -154,7 +154,6 @@ EOFmkdir -p "$output/include/standard-headers/asm-$arch"
if [ $arch = s390 ]; then
cp_portable"$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-s390/"
cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/asm-s390/"
fiI think it would make sense to remove
linux-headers/asm-s390/unistd_32.hin this patch, too, otherwise this will stay around as a stale file, I guess?
AFAICT, it will be removed at the first update of linux-headers. See :
https://lore.kernel.org/qemu-devel/[email protected]/
Quoted 2 lines
Anyway,
Reviewed-by Thomas Huth <[email protected]>
Thanks,
C.
Cornelia Huck
Reviewed-byQuoted 31 lines · Cédric Le Goater
Quoted 16 lines · Thomas Huth
Quoted 15 lines · Cédric Le Goater
The "
asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit4ac286c4a8d9("s390/syscalls: Switch to generic system call table generation")
unistd_32.his no longer generated when running makeheader_install. Remove it.Reported-by Shameer Kolothum <[email protected]>Cc Thomas Huth <[email protected]>Signed-off-by Cédric Le Goater <[email protected]>---
scripts/update-linux-headers.sh| 1 -1 file changed, 1 deletion(-)Quoted 13 lines
Quoted 11 lines
scripts/update-linux-headers.sh +0
-0@@ -154,7 +154,6 @@ EOFmkdir -p "$output/include/standard-headers/asm-$arch"
if [ $arch = s390 ]; then
cp_portable"$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-s390/"
cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/asm-s390/"
fiI think it would make sense to remove
linux-headers/asm-s390/unistd_32.hin this patch, too, otherwise this will stay around as a stale file, I guess?
Quoted 3 lines
AFAICT, it will be removed at the first update of linux-headers. See :
https://lore.kernel.org/qemu-devel/[email protected]/
Yes, the script purges the old files before installing the new versions.
Quoted 6 lines
Quoted 3 lines
Anyway,
Reviewed-by Thomas Huth <[email protected]>Thanks,
C.
Quoted 32 lines · Cédric Le Goater
Quoted 16 lines · Thomas Huth
Quoted 15 lines · Cédric Le Goater
The "
asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit4ac286c4a8d9("s390/syscalls: Switch to generic system call table generation")
unistd_32.his no longer generated when running makeheader_install. Remove it.Reported-by Shameer Kolothum <[email protected]>Cc Thomas Huth <[email protected]>Signed-off-by Cédric Le Goater <[email protected]>---
scripts/update-linux-headers.sh| 1 -1 file changed, 1 deletion(-)Quoted 14 lines
Quoted 5 lines
scripts/update-linux-headers.sh +0
-0@@ -154,7 +154,6 @@ EOFQuoted 7 lines
mkdir -p "$output/include/standard-headers/asm-$arch"
if [ $arch = s390 ]; then
cp_portable"$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-
s390/"
cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/ asm-s390/"
fiI think it would make sense to remove
linux-headers/asm-s390/unistd_32.hin this patch, too, otherwise this will stay around as a stale file, I guess?
Quoted 4 lines
AFAICT, it will be removed at the first update of linux-headers. See :
https://lore.kernel.org/qemu-devel/20251222135357.143339-2-
[email protected]/
Ah, perfect, that's fine, too!
Thomas
Quoted 7 lines
Quoted 3 lines
Anyway,
Reviewed-by Thomas Huth <[email protected]>Thanks,
C.
Cédric Le Goater
AppliedQuoted 20 lines · Cédric Le Goater
The "
asm/unistd_32.h" file was generated for the 31-bit compatibility mode on the s390 architecture and support was removed in v6.19-rc1, commit4ac286c4a8d9("s390/syscalls: Switch to generic system call table generation")
unistd_32.his no longer generated when running makeheader_install. Remove it.Reported-by Shameer Kolothum <[email protected]>Cc Thomas Huth <[email protected]>Signed-off-by Cédric Le Goater <[email protected]>--- scripts/update-linux-headers.sh | 1 - 1 file changed, 1 deletion(-)scripts/update-linux-headers.sh +0
-0
scripts/update-linux-headers.sh EOF · line 159
Quoted 7 lines
scripts/update-linux-headers.sh +0
-1@@ -154,7 +154,6 @@ EOF mkdir -p "$output/include/standard-headers/asm-$arch" if [ $arch = s390 ]; then cp_portable "$hdrdir/include/asm/virtio-ccw.h" "$output/include/standard-headers/asm-s390/" - cp "$hdrdir/include/asm/unistd_32.h" "$output/linux-headers/asm-s390/" cp "$hdrdir/include/asm/unistd_64.h" "$output/linux-headers/asm-s390/" fi if [ $arch = arm64 ]; then
Applied to vfio-next.
Thanks,
C.