ARM: OMAP2+: TEMP: Round of the carve out memory requested to section_size

PATCH Superseded R Sricharan 2 participants 3 messages Sep 12, 2012

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

R Sricharan

author

2012-09-12 05:51 UTC #0 lore raw

PATCH 1/1 ARM: OMAP2+: TEMP: Round of the carve out memory requested to section_size

memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

https://lkml.org/lkml/2012/6/28/112

The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary.

Signed-off-by R Sricharan <[email protected]>

---
 arch/arm/mach-omap2/omap-secure.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/omap-secure.c +2 -2

index d9ae4a5..26edfec 100644
@@ -61,8 +61,8 @@ int __init omap_secure_ram_reserve_memblock(void)
 {
 	u32 size = OMAP_SECURE_RAM_STORAGE;
 
-	size = ALIGN(size, SZ_1M);
-	omap_secure_memblock_base = arm_memblock_steal(size, SZ_1M);
+	size = ALIGN(size, SECTION_SIZE);
+	omap_secure_memblock_base = arm_memblock_steal(size, SECTION_SIZE);
 
 	return 0;
 }

Signature · 1 line

1.7.9.5

Shilimkar, Santosh

2012-09-12 05:58 UTC #1 lore raw

PATCH 1/1 ARM: OMAP2+: TEMP: Round of the carve out memory requested to section_size

Quoted 6 lines · R Sricharan

memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

Quoted 6 lines

https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary.
Signed-off-by R Sricharan <[email protected]>

Why is the TEMP in the subject line. From patch it doesn't be temporary version. Can you please clarify that ?

Regards
Santosh

Sricharan R

author

2012-09-12 08:42 UTC #2 lore raw

PATCH 1/1 ARM: OMAP2+: TEMP: Round of the carve out memory requested to section_size

[..]

Quoted 6 lines

Quoted 6 lines
memblock_steal tries to reserve physical memory during boot. When the requested size is not aligned on the section size then, the remaining memory available for lowmem becomes unaligned on the section boundary. There is a issue with this, which is discussed in the thread below.

Quoted 9 lines

Quoted 6 lines
https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary.
Signed-off-by R Sricharan <[email protected]>
Why is the TEMP in the subject line. From patch it doesn't be temporary version. Can you please clarify that ?

Oops, that was a mistake. Reposted by correcting it.

Thanks,
Sricharan