Skip to contentSkip to conversation

xtf-runner: python3 fix

PATCH In review Anthony PERARD 2 participants 2 messages Aug 17, 2023 – Aug 18, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xtf-runner: python3 fix

issue:
File "/home/xtf/xtf-runner", line 410, in interpret_selection
if not line.startswith("xen_caps"):
^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Adding universal_newlines open stdout as text file, so line should be a str. universal_newlines is available on python 2.7. A new alias text is only available in python 3.7.

---

Notes:
I've only tested the patch on Debian Bookworm, with python-is-python3 package (python symlink) as osstest run ./xtf-runner ....

I haven't tried python2.7.

 xtf-runner | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xtf-runner +1 -1
index 6352a5b..5741e64 100755
@@ -403,7 +403,7 @@ def interpret_selection(opts):
 
         host_envs = []
 
-        cmd = Popen(['xl', 'info'], stdout = PIPE)
+        cmd = Popen(['xl', 'info'], stdout = PIPE, universal_newlines=True)
         stdout, _ = cmd.communicate()
 
         for line in stdout.splitlines():
Signature · 1 line
Anthony PERARD
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Anthony PERARD

issue:
File "/home/xtf/xtf-runner", line 410, in interpret_selection
if not line.startswith("xen_caps"):
^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Adding universal_newlines open stdout as text file, so line should be a str. universal_newlines is available on python 2.7. A new alias text is only available in python 3.7.

Quoted 8 lines

---

Notes:
I've only tested the patch on Debian Bookworm, with python-is-python3 package (python symlink) as osstest run ./xtf-runner ....

I haven't tried python2.7.

Seems to work on Py2.7.