Skip to contentSkip to conversation

drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

PATCH In review Thomas Zimmermann 2 participants 3 messages Jan 11, 2022 – Jan 12, 2022

Subsystems (2)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy

Set the source-buffer address after mapping the buffer into the kernel's address space. Makes MIPI DBI helpers work again.

Fixes c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
Cc Thomas Zimmermann <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
---
 drivers/gpu/drm/drm_mipi_dbi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_mipi_dbi.c +1 -1
index ded8968b3e8a..0327d595e028 100644
@@ -209,11 +209,11 @@ int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
 	ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
 	if (ret)
 		return ret;
-	src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
 
 	ret = drm_gem_fb_vmap(fb, map, data);
 	if (ret)
 		goto out_drm_gem_fb_end_cpu_access;
+	src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
 
 	switch (fb->format->format) {
 	case DRM_FORMAT_RGB565:
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Den 11.01.2022 14.26, skrev Thomas Zimmermann:

Quoted 11 lines

Set the source-buffer address after mapping the buffer into the kernel's address space. Makes MIPI DBI helpers work again.

Fixes c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
Cc Thomas Zimmermann <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>

---

author maintainer Applied
#2 lore raw

Hi

Am 11.01.22 um 14:32 schrieb Noralf Trønnes:

Quoted 15 lines

Den 11.01.2022 14.26, skrev Thomas Zimmermann:

Quoted 11 lines

Set the source-buffer address after mapping the buffer into the kernel's address space. Makes MIPI DBI helpers work again.

Fixes c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
Cc Thomas Zimmermann <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>

---

Quoted 1 line

Merged into drm-misc-next.

Best regards
Thomas

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev