powerpc/powernv/elog: Reduce elog message severity
PATCH 1/1 powerpc/powernv/elog: Reduce elog message severity
OPAL interrupts kernel whenever it has new error log. Kernel calls interrupt handler (elog_event()) to retrieve event. elog_event makes OPAL API call (opal_get_elog_size()) to retrieve elog info.
In some case before kernel makes opal_get_elog_size() call, it gets interrupt again. So second time when elog_event() calls opal_get_elog_size API OPAL returns error. Its safe to ignore this error. Hence reduce the severity of log message.
--- arch/powerpc/platforms/powernv/opal-elog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/platforms/powernv/opal-elog.c +1 -1
@@ -247,7 +247,7 @@ static irqreturn_t elog_event(int irq, void *data) rc =opal_get_elog_size (&id, &size, &type);if (rc !=OPAL_SUCCESS ) { -pr_err ("ELOG: OPAL log info read failed\n" ); +pr_debug ("ELOG: OPAL log info read failed\n" );return IRQ_HANDLED ; }
Signature · 1 line
2.26.2
Michael Ellerman
reviewerQuoted 7 lines · Vasant Hegde
OPAL interrupts kernel whenever it has new error log. Kernel calls interrupt handler (
elog_event()) to retrieve event.elog_eventmakes OPAL API call (opal_get_elog_size()) to retrieve elog info.In some case before kernel makes
opal_get_elog_size()call, it gets interrupt again. So second time whenelog_event()callsopal_get_elog_sizeAPI OPAL returns error.
Can you give more detail there? Do you have a stack trace?
We use IRQF_ONESHOT for elog_event(), which (I thought) meant it shouldn't be called again until it has completed.
So I'm unclear how you're seeing the behaviour you describe.
cheers
Quoted 24 lines
Its safe to ignore this error. Hence reduce the severity of log message.
CC Mahesh Salgaonkar <[email protected]>Signed-off-by Vasant Hegde <[email protected]>--- arch/powerpc/platforms/powernv/opal-elog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/platforms/powernv/opal-elog.c +1
-1@@ -247,7 +247,7 @@ static irqreturn_t elog_event(int irq, void *data) rc =opal_get_elog_size (&id, &size, &type);if (rc !=OPAL_SUCCESS ) { -pr_err ("ELOG: OPAL log info read failed\n" ); +pr_debug ("ELOG: OPAL log info read failed\n" );return IRQ_HANDLED ; }Signature · 1 line
2.26.2
Quoted 10 lines · Michael Ellerman
Quoted 7 lines · Vasant Hegde
OPAL interrupts kernel whenever it has new error log. Kernel calls interrupt handler (
elog_event()) to retrieve event.elog_eventmakes OPAL API call (opal_get_elog_size()) to retrieve elog info.In some case before kernel makes
opal_get_elog_size()call, it gets interrupt again. So second time whenelog_event()callsopal_get_elog_sizeAPI OPAL returns error.Can you give more detail there? Do you have a stack trace?
I observe below log in dmesg
[ 615.708709] ELOG: OPAL log info read failed
That means elog_event called twice for same error log event. I don't have stack trace.
Quoted 3 lines
We use
IRQF_ONESHOTforelog_event(), which (I thought) meant it shouldn't be called again until it has completed.
Yes. I thought so.. But once in a while we get above message (mostly when we have multiple event bits are set).
-Vasant
Quoted 29 lines
So I'm unclear how you're seeing the behaviour you describe.
cheers
Quoted 24 lines
Its safe to ignore this error. Hence reduce the severity of log message.
CC Mahesh Salgaonkar <[email protected]>Signed-off-by Vasant Hegde <[email protected]>--- arch/powerpc/platforms/powernv/opal-elog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/platforms/powernv/opal-elog.c +1
-1@@ -247,7 +247,7 @@ static irqreturn_t elog_event(int irq, void *data) rc =opal_get_elog_size (&id, &size, &type);if (rc !=OPAL_SUCCESS ) { -pr_err ("ELOG: OPAL log info read failed\n" ); +pr_debug ("ELOG: OPAL log info read failed\n" );return IRQ_HANDLED ; }Signature · 1 line
2.26.2